From e6f2ecafaf0efecacfd4256f280e26ee74cb7e16 Mon Sep 17 00:00:00 2001 From: Timothy Liang Date: Wed, 13 Jun 2018 17:12:52 -0400 Subject: added 565 to 8888 conversion for gpu LCD text rendering for macOS Bug: skia: Change-Id: Ie24160bb098d388bf4ad69d0c2f9f8ed4beb215c Reviewed-on: https://skia-review.googlesource.com/134508 Commit-Queue: Timothy Liang Reviewed-by: Jim Van Verth --- src/gpu/text/GrAtlasManager.cpp | 2 -- src/gpu/text/GrAtlasManager.h | 15 +++++++++++++++ src/gpu/text/GrGlyphCache.cpp | 29 +++++++++++++++++++++++++++++ 3 files changed, 44 insertions(+), 2 deletions(-) (limited to 'src/gpu/text') diff --git a/src/gpu/text/GrAtlasManager.cpp b/src/gpu/text/GrAtlasManager.cpp index ec07429180..e589b20814 100644 --- a/src/gpu/text/GrAtlasManager.cpp +++ b/src/gpu/text/GrAtlasManager.cpp @@ -7,10 +7,8 @@ #include "GrAtlasManager.h" -#include "GrCaps.h" #include "GrGlyph.h" #include "GrGlyphCache.h" -#include "GrProxyProvider.h" void GrAtlasManager::ComputeAtlasLimits(int maxTextureSize, size_t maxTextureBytes, int* maxDim, int* minDim, int* maxPlot, int* minPlot) { diff --git a/src/gpu/text/GrAtlasManager.h b/src/gpu/text/GrAtlasManager.h index 38e2781d4d..6c168534ad 100644 --- a/src/gpu/text/GrAtlasManager.h +++ b/src/gpu/text/GrAtlasManager.h @@ -8,8 +8,10 @@ #ifndef GrAtlasManager_DEFINED #define GrAtlasManager_DEFINED +#include "GrCaps.h" #include "GrDrawOpAtlas.h" #include "GrOnFlushResourceProvider.h" +#include "GrProxyProvider.h" class GrAtlasGlypCache; class GrTextStrike; @@ -28,11 +30,23 @@ public: float maxTextureBytes, GrDrawOpAtlas::AllowMultitexturing); ~GrAtlasManager() override; + // Change an expected 565 mask format to 8888 if 565 is not supported (will happen when using + // Metal on macOS). The actual conversion of the data is handled in get_packed_glyph_image() in + // GrGlyphCache.cpp + GrMaskFormat resolveMaskFormat(GrMaskFormat format) const { + if (kA565_GrMaskFormat == format && + !fProxyProvider->caps()->isConfigTexturable(kRGB_565_GrPixelConfig)) { + format = kARGB_GrMaskFormat; + } + return format; + } + // if getProxies returns nullptr, the client must not try to use other functions on the // GrGlyphCache which use the atlas. This function *must* be called first, before other // functions which use the atlas. Note that we can have proxies available but none active // (i.e., none instantiated). const sk_sp* getProxies(GrMaskFormat format, unsigned int* numActiveProxies) { + format = this->resolveMaskFormat(format); if (this->initAtlas(format)) { *numActiveProxies = this->getAtlas(format)->numActivePages(); return this->getAtlas(format)->getProxies(); @@ -127,6 +141,7 @@ private: } GrDrawOpAtlas* getAtlas(GrMaskFormat format) const { + format = this->resolveMaskFormat(format); int atlasIndex = MaskFormatToAtlasIndex(format); SkASSERT(fAtlases[atlasIndex]); return fAtlases[atlasIndex].get(); diff --git a/src/gpu/text/GrGlyphCache.cpp b/src/gpu/text/GrGlyphCache.cpp index f6a18c3271..78b9dc3d12 100644 --- a/src/gpu/text/GrGlyphCache.cpp +++ b/src/gpu/text/GrGlyphCache.cpp @@ -8,10 +8,15 @@ #include "GrGlyphCache.h" #include "GrAtlasManager.h" #include "GrCaps.h" +#include "GrColor.h" #include "GrDistanceFieldGenFromVector.h" #include "SkAutoMalloc.h" #include "SkDistanceFieldGen.h" +#include "SkMasks.h" + +static std::unique_ptr k565Masks(SkMasks::CreateMasks({0xF800, 0x07E0, 0x001F, 0}, + GrMaskFormatBytesPerPixel(kA565_GrMaskFormat) * 8)); GrGlyphCache::GrGlyphCache(const GrCaps* caps, size_t maxTextureBytes) : fPreserveStrike(nullptr), fGlyphSizeLimit(0) { @@ -128,6 +133,29 @@ static bool get_packed_glyph_image(SkGlyphCache* cache, const SkGlyph& glyph, in return false; } + // Convert if the glyph uses a 565 mask format since it is using LCD text rendering but the + // expected format is 8888 (will happen on macOS with Metal since that combination does not + // support 565). + if (kA565_GrMaskFormat == get_packed_glyph_mask_format(glyph) && + kARGB_GrMaskFormat == expectedMaskFormat) { + const int a565Bpp = GrMaskFormatBytesPerPixel(kA565_GrMaskFormat); + const int argbBpp = GrMaskFormatBytesPerPixel(kARGB_GrMaskFormat); + for (int y = 0; y < height; y++) { + for (int x = 0; x < width; x++) { + uint16_t color565 = 0; + memcpy(&color565, src, a565Bpp); + uint32_t colorRGBA = GrColorPackRGBA(k565Masks->getRed(color565), + k565Masks->getGreen(color565), + k565Masks->getBlue(color565), + 0xFF); + memcpy(dst, &colorRGBA, argbBpp); + src = (char*)src + a565Bpp; + dst = (char*)dst + argbBpp; + } + } + return true; + } + // crbug:510931 // Retrieving the image from the cache can actually change the mask format. This case is very // uncommon so for now we just draw a clear box for these glyphs. @@ -237,6 +265,7 @@ GrDrawOpAtlas::ErrorCode GrTextStrike::addGlyphToAtlas( SkASSERT(cache); SkASSERT(fCache.find(glyph->fPackedID)); + expectedMaskFormat = fullAtlasManager->resolveMaskFormat(expectedMaskFormat); int bytesPerPixel = GrMaskFormatBytesPerPixel(expectedMaskFormat); int width = glyph->width(); int height = glyph->height(); -- cgit v1.2.3