From 26e18b593ab65e4d92dfbce92579d8bc180d4c2c Mon Sep 17 00:00:00 2001 From: "bsalomon@google.com" Date: Fri, 29 Mar 2013 19:22:36 +0000 Subject: Add support for reading the dst pixel value in an effect. Use in a new effect for the kDarken xfer mode. The current implementation is to always make a copy of the entire dst before the draw. It will only succeed if the RT is also a texture. Obviously, there is lots of room for improvement. Review URL: https://codereview.chromium.org/13314002 git-svn-id: http://skia.googlecode.com/svn/trunk@8449 2bbb7eff-a529-9590-31e7-b0007b416f81 --- src/gpu/SkGpuDevice.cpp | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) (limited to 'src/gpu/SkGpuDevice.cpp') diff --git a/src/gpu/SkGpuDevice.cpp b/src/gpu/SkGpuDevice.cpp index 49d6562cea..45176cf8c9 100644 --- a/src/gpu/SkGpuDevice.cpp +++ b/src/gpu/SkGpuDevice.cpp @@ -493,17 +493,27 @@ inline bool skPaint2GrPaintNoShader(SkGpuDevice* dev, grPaint->setDither(skPaint.isDither()); grPaint->setAntiAlias(skPaint.isAntiAlias()); - SkXfermode::Coeff sm = SkXfermode::kOne_Coeff; - SkXfermode::Coeff dm = SkXfermode::kISA_Coeff; + SkXfermode::Coeff sm; + SkXfermode::Coeff dm; SkXfermode* mode = skPaint.getXfermode(); GrEffectRef* xferEffect = NULL; - if (SkXfermode::AsNewEffect(mode, dev->context(), &xferEffect, &sm, &dm)) { - SkSafeUnref(grPaint->colorStage(kXfermodeEffectIdx)->setEffect(xferEffect)); + if (SkXfermode::AsNewEffectOrCoeff(mode, dev->context(), &xferEffect, &sm, &dm)) { + if (NULL != xferEffect) { + grPaint->colorStage(kXfermodeEffectIdx)->setEffect(xferEffect)->unref(); + // This may not be the right place to have this logic but we set the GPU blend to + // src-over so that fractional coverage will be accounted for correctly. + sm = SkXfermode::kOne_Coeff; + dm = SkXfermode::kISA_Coeff; + } } else { //SkDEBUGCODE(SkDebugf("Unsupported xfer mode.\n");) #if 0 return false; +#else + // Fall back to src-over + sm = SkXfermode::kOne_Coeff; + dm = SkXfermode::kISA_Coeff; #endif } grPaint->setBlendFunc(sk_blend_to_grblend(sm), sk_blend_to_grblend(dm)); -- cgit v1.2.3