From f6bfccd562f4ac071db9902097ad4bea83294085 Mon Sep 17 00:00:00 2001 From: benjaminwagner Date: Thu, 25 Feb 2016 10:28:11 -0800 Subject: Cleanups related to SkFixed. This CL relands https://codereview.chromium.org/1683743005/ with two fixes: - Removing the test for vertical text. Vertical text doesn't work on Windows and breakText isn't supported for non-trivial text. - Omit PaintBreakTextTest in Google3 because we don't have the correct font setup yet. Remove SK_FixedNaN. It does not seem to be supported or used anywhere in Skia, Chromium, Android, or Google3, (except accidentally by TwoPtRadial::kDontDrawT). I think supporting it would erase any benefit of SkFixed over float. Remove SkBitmapFilter::lookup. It does not appear to be used anywhere in Skia, Chromium, Android, or Google3. Fix a bug in SkPaint::breakText that limited it to ~5kB of text. Now it can handle more than 1GB. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683743005 Committed: https://skia.googlesource.com/skia/+/7ea5cb18389db11a94175de95c9db2b44972630c patch from issue 1683743005 at patchset 120001 (http://crrev.com/1683743005#ps120001) Review URL: https://codereview.chromium.org/1739453002 --- src/effects/gradients/SkTwoPointConicalGradient.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/effects/gradients') diff --git a/src/effects/gradients/SkTwoPointConicalGradient.h b/src/effects/gradients/SkTwoPointConicalGradient.h index f468de8007..954b09698e 100644 --- a/src/effects/gradients/SkTwoPointConicalGradient.h +++ b/src/effects/gradients/SkTwoPointConicalGradient.h @@ -15,6 +15,7 @@ // Should only be initialized once via init(). Immutable afterwards. struct TwoPtRadial { enum { + // This value is outside the range SK_FixedMin to SK_FixedMax. kDontDrawT = 0x80000000 }; -- cgit v1.2.3