From 152f524fd325b7776b01f84afbfe2fa071648a05 Mon Sep 17 00:00:00 2001 From: robertphillips Date: Wed, 7 Jan 2015 09:01:12 -0800 Subject: It is dangerous to ignore SkRect::intersect's return value Review URL: https://codereview.chromium.org/833943002 --- src/effects/SkBlurMaskFilter.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/effects/SkBlurMaskFilter.cpp') diff --git a/src/effects/SkBlurMaskFilter.cpp b/src/effects/SkBlurMaskFilter.cpp index aa576697e3..97ae436367 100644 --- a/src/effects/SkBlurMaskFilter.cpp +++ b/src/effects/SkBlurMaskFilter.cpp @@ -1184,7 +1184,9 @@ bool SkBlurMaskFilterImpl::canFilterMaskGPU(const SkRect& srcBounds, // Outset srcRect and clipRect by 3 * sigma, to compute affected blur area. srcRect.outset(sigma3, sigma3); clipRect.outset(sigma3, sigma3); - srcRect.intersect(clipRect); + if (!srcRect.intersect(clipRect)) { + srcRect.setEmpty(); + } *maskRect = srcRect; return true; } -- cgit v1.2.3