From 6dcd716293dd41cb1e8215fb1060ed548614aefc Mon Sep 17 00:00:00 2001 From: Adrienne Walker Date: Fri, 29 Jun 2018 10:47:40 -0700 Subject: Fix chrome memory dump crashes using out of process strike caches When using out of process raster in Chrome, it uses SkTypefaceProxy in the gpu process. When SkStrikeCache::DumpMemoryStatistics, this asserts on getFamilyName. Stub this function out to fix the issue. Punt for now on forwarding real family names to SkTypefaceProxy until somebody complains about it. Change-Id: Idbd870c4990e5725a97cfe3501f3943f8a83dea2 Reviewed-on: https://skia-review.googlesource.com/138602 Commit-Queue: Adrienne Walker Commit-Queue: Mike Klein Reviewed-by: Mike Klein --- src/core/SkTypeface_remote.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/core') diff --git a/src/core/SkTypeface_remote.h b/src/core/SkTypeface_remote.h index 47a68fd08d..1b4ad89025 100644 --- a/src/core/SkTypeface_remote.h +++ b/src/core/SkTypeface_remote.h @@ -83,7 +83,8 @@ protected: return 0; } void onGetFamilyName(SkString* familyName) const override { - SK_ABORT("Should never be called."); + // Used by SkStrikeCache::DumpMemoryStatistics. + *familyName = ""; } SkTypeface::LocalizedStrings* onCreateFamilyNameIterator() const override { SK_ABORT("Should never be called."); -- cgit v1.2.3