From 8a21c9fe7f5fef9e87115defef27bd7218419f28 Mon Sep 17 00:00:00 2001 From: reed Date: Tue, 8 Mar 2016 18:50:00 -0800 Subject: use Make instead of Create to return a shared shader Partially updated call sites. Undefine the flag in SkSHader.h to convert the remaining sites. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1772463002 Review URL: https://codereview.chromium.org/1772463002 --- samplecode/SamplePatch.cpp | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) (limited to 'samplecode/SamplePatch.cpp') diff --git a/samplecode/SamplePatch.cpp b/samplecode/SamplePatch.cpp index 5347b0182a..c9ecb70990 100644 --- a/samplecode/SamplePatch.cpp +++ b/samplecode/SamplePatch.cpp @@ -28,21 +28,21 @@ #include "SkGeometry.h" // private include :( -static SkShader* make_shader0(SkIPoint* size) { +static sk_sp make_shader0(SkIPoint* size) { SkBitmap bm; // SkImageDecoder::DecodeFile("/skimages/progressivejpg.jpg", &bm); SkImageDecoder::DecodeFile("/skimages/logo.png", &bm); size->set(bm.width(), bm.height()); - return SkShader::CreateBitmapShader(bm, SkShader::kClamp_TileMode, - SkShader::kClamp_TileMode); + return SkShader::MakeBitmapShader(bm, SkShader::kClamp_TileMode, + SkShader::kClamp_TileMode); } -static SkShader* make_shader1(const SkIPoint& size) { +static sk_sp make_shader1(const SkIPoint& size) { SkPoint pts[] = { { 0, 0, }, { SkIntToScalar(size.fX), SkIntToScalar(size.fY) } }; SkColor colors[] = { SK_ColorRED, SK_ColorGREEN, SK_ColorBLUE, SK_ColorRED }; - return SkGradientShader::CreateLinear(pts, colors, nullptr, + return SkGradientShader::MakeLinear(pts, colors, nullptr, SK_ARRAY_COUNT(colors), SkShader::kMirror_TileMode); } @@ -211,8 +211,8 @@ const SkScalar DY = 0; class PatchView : public SampleView { SkScalar fAngle; - SkShader* fShader0; - SkShader* fShader1; + sk_sp fShader0; + sk_sp fShader1; SkIPoint fSize0, fSize1; SkPoint fPts[12]; @@ -243,11 +243,6 @@ public: this->setBGColor(SK_ColorGRAY); } - virtual ~PatchView() { - SkSafeUnref(fShader0); - SkSafeUnref(fShader1); - } - protected: // overrides from SkEventSink bool onQuery(SkEvent* evt) override { -- cgit v1.2.3