From 29121ebd9e4673d7ca6ac1ba3dd905fbdc9d50aa Mon Sep 17 00:00:00 2001 From: Matt Sarett Date: Mon, 17 Oct 2016 14:32:46 -0400 Subject: Avoid integer overflow in SkIcoCodec and SkImageInfo Original Commit Message: """ Avoid integer overflow in SkIcoCodec Definitely good to avoid overflow here. FWIW, this looks to be harmless for Android's current use. They will just fail later on when trying to allocate the bitmap. BUG=skia:5857 """ With the new test, ASAN also caught an integer overflow bug in SkImageInfo. Fix this as well. CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN;master.client.skia.android:Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Debug-GN_Android BUG=skia:5857 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3568 Change-Id: I0d777a547850474ea6cea87e36efa05434e33635 Reviewed-on: https://skia-review.googlesource.com/3568 Reviewed-by: Kevin Lubick --- resources/invalid_images/int_overflow.ico | Bin 0 -> 323 bytes 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 resources/invalid_images/int_overflow.ico (limited to 'resources') diff --git a/resources/invalid_images/int_overflow.ico b/resources/invalid_images/int_overflow.ico new file mode 100644 index 0000000000..ba675666b6 Binary files /dev/null and b/resources/invalid_images/int_overflow.ico differ -- cgit v1.2.3