From 6dce0a72e0a9e5302246aa716741ed1faa620b30 Mon Sep 17 00:00:00 2001 From: Brian Osman Date: Thu, 31 May 2018 12:57:22 -0400 Subject: Enable GPU support in MSAN builds Don't want to test GPU with MSAN, but I'd like to make GPU support required for DM and other internal tools. Bug: skia: Change-Id: I5f1a7669242be9767aa3b579b39740a1741977f3 Reviewed-on: https://skia-review.googlesource.com/131143 Reviewed-by: Mike Klein Commit-Queue: Brian Osman --- infra/bots/recipe_modules/build/default.py | 1 - .../examples/full.expected/Build-Debian9-Clang-x86_64-Debug-MSAN.json | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) (limited to 'infra/bots/recipe_modules/build') diff --git a/infra/bots/recipe_modules/build/default.py b/infra/bots/recipe_modules/build/default.py index cb98d21e21..af293d9712 100644 --- a/infra/bots/recipe_modules/build/default.py +++ b/infra/bots/recipe_modules/build/default.py @@ -158,7 +158,6 @@ def compile_fn(api, checkout_root, out_dir): chrome_dir = checkout_root api.run.run_once(build_command_buffer, api, chrome_dir, skia_dir, out_dir) if 'MSAN' in extra_tokens: - args['skia_enable_gpu'] = 'false' args['skia_use_fontconfig'] = 'false' if 'ASAN' in extra_tokens or 'UBSAN' in extra_tokens: args['skia_enable_spirv_validation'] = 'false' diff --git a/infra/bots/recipe_modules/build/examples/full.expected/Build-Debian9-Clang-x86_64-Debug-MSAN.json b/infra/bots/recipe_modules/build/examples/full.expected/Build-Debian9-Clang-x86_64-Debug-MSAN.json index 81bbf346e6..56f92fe648 100644 --- a/infra/bots/recipe_modules/build/examples/full.expected/Build-Debian9-Clang-x86_64-Debug-MSAN.json +++ b/infra/bots/recipe_modules/build/examples/full.expected/Build-Debian9-Clang-x86_64-Debug-MSAN.json @@ -32,7 +32,7 @@ "[START_DIR]/cache/work/skia/bin/gn", "gen", "[START_DIR]/cache/work/skia/out/Build-Debian9-Clang-x86_64-Debug-MSAN/Debug", - "--args=cc=\"[START_DIR]/clang_linux/bin/clang\" cxx=\"[START_DIR]/clang_linux/bin/clang++\" extra_cflags=[\"-B[START_DIR]/clang_linux/bin\", \"-DDUMMY_clang_linux_version=42\", \"-O1\"] extra_ldflags=[\"-B[START_DIR]/clang_linux/bin\", \"-fuse-ld=lld\", \"-L[START_DIR]/clang_linux/msan\"] sanitize=\"MSAN\" skia_enable_gpu=false skia_use_fontconfig=false target_cpu=\"x86_64\"" + "--args=cc=\"[START_DIR]/clang_linux/bin/clang\" cxx=\"[START_DIR]/clang_linux/bin/clang++\" extra_cflags=[\"-B[START_DIR]/clang_linux/bin\", \"-DDUMMY_clang_linux_version=42\", \"-O1\"] extra_ldflags=[\"-B[START_DIR]/clang_linux/bin\", \"-fuse-ld=lld\", \"-L[START_DIR]/clang_linux/msan\"] sanitize=\"MSAN\" skia_use_fontconfig=false target_cpu=\"x86_64\"" ], "cwd": "[START_DIR]/cache/work/skia", "env": { -- cgit v1.2.3