From cb92b26e5ca6063bcf1a922109b8224e0b6eb4da Mon Sep 17 00:00:00 2001 From: Greg Daniel Date: Wed, 27 Jun 2018 15:03:36 +0000 Subject: Revert "Let client pass in full extension to GrVkBackendContext." This reverts commit 45c9dab4c3ec43cedb28d1b8c08e166fe0c2e767. Reason for revert: fucshia uses GrVkBackendContext. Need to revert earlier changes Original change's description: > Let client pass in full extension to GrVkBackendContext. > > Bug: skia: > Change-Id: I772ab4ccbca0f4f7e7d429d6c421b07d97f0606f > Reviewed-on: https://skia-review.googlesource.com/131880 > Reviewed-by: Jim Van Verth > Commit-Queue: Greg Daniel TBR=egdaniel@google.com,jvanverth@google.com,bsalomon@google.com Change-Id: I1a765ff406c83cb234c3614b804fbed677d5a382 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/137901 Reviewed-by: Greg Daniel Commit-Queue: Greg Daniel --- include/gpu/vk/GrVkBackendContext.h | 1 + include/gpu/vk/GrVkExtensions.h | 35 ----------------------------------- include/gpu/vk/GrVkInterface.h | 21 ++++----------------- 3 files changed, 5 insertions(+), 52 deletions(-) delete mode 100644 include/gpu/vk/GrVkExtensions.h (limited to 'include') diff --git a/include/gpu/vk/GrVkBackendContext.h b/include/gpu/vk/GrVkBackendContext.h index 3775c345ce..fe018e494f 100644 --- a/include/gpu/vk/GrVkBackendContext.h +++ b/include/gpu/vk/GrVkBackendContext.h @@ -49,6 +49,7 @@ struct SK_API GrVkBackendContext { uint32_t fFeatures; sk_sp fInterface; sk_sp fMemoryAllocator; + // This is deprecated and should be set to false. The client is responsible for managing the // lifetime of the VkInstance and VkDevice objects. bool fOwnsInstanceAndDevice = false; diff --git a/include/gpu/vk/GrVkExtensions.h b/include/gpu/vk/GrVkExtensions.h deleted file mode 100644 index a6badcd33f..0000000000 --- a/include/gpu/vk/GrVkExtensions.h +++ /dev/null @@ -1,35 +0,0 @@ -/* - * Copyright 2016 Google Inc. - * - * Use of this source code is governed by a BSD-style license that can be - * found in the LICENSE file. - */ - -#ifndef GrVkExtensions_DEFINED -#define GrVkExtensions_DEFINED - -#include "../private/SkTArray.h" -#include "SkString.h" - -/** - * Helper class that eats in an array of extensions strings for instance and device and allows for - * quicker querying if an extension is present. - */ -class GrVkExtensions { -public: - GrVkExtensions(uint32_t instanceExtensionCount, const char* const* instanceExtensions, - uint32_t deviceExtensionCount, const char* const* deviceExtensions); - // TODO: Remove once we remove the old fExtensions from GrVkBackendContext - GrVkExtensions(uint32_t extensionFlags); - - // TODO: Remove once we remove the old fExtensions from GrVkBackendContext - static void GetExtensionArrayFromFlags(uint32_t extensionFlags, - SkTArray* extensions); - - bool hasExtension(const char[]) const; - -private: - SkTArray fExtensionStrings; -}; - -#endif diff --git a/include/gpu/vk/GrVkInterface.h b/include/gpu/vk/GrVkInterface.h index b4691e8994..05ce561829 100644 --- a/include/gpu/vk/GrVkInterface.h +++ b/include/gpu/vk/GrVkInterface.h @@ -11,7 +11,6 @@ #include "SkRefCnt.h" #include "vk/GrVkDefines.h" -#include "vk/GrVkExtensions.h" //////////////////////////////////////////////////////////////////////////////// @@ -51,25 +50,17 @@ public: GrVkInterface(GetProc getProc, VkInstance instance, VkDevice device, - uint32_t instanceExtensionCount, - const char* const* instanceExtensions, - uint32_t deviceExtensionCount, - const char* const* deviceExtensions); + uint32_t extensionFlags); - // TODO: This is deprecated. Remove onces clients have switch to new interface - GrVkInterface(GetProc getProc, + GrVkInterface(const GetInstanceProc&, + const GetDeviceProc&, VkInstance instance, VkDevice device, uint32_t extensionFlags); // Validates that the GrVkInterface supports its advertised standard. This means the necessary // function pointers have been initialized for Vulkan version. - bool validate() const; - - // This is deprecated since the extensions information is stored already on the GrVkInterface. - bool validate(uint32_t /*extensionFlags*/) const { - return this->validate(); - } + bool validate(uint32_t extensionFlags) const; /** * The function pointers are in a struct so that we can have a compiler generated assignment @@ -217,10 +208,6 @@ public: VkPtr fDestroyDebugReportCallbackEXT; } fFunctions; - GrVkExtensions fExtensions; - -private: - void init(GetProc getProc, VkInstance instance, VkDevice device); }; #endif -- cgit v1.2.3