From 9ec70c6bd3dfe6338fbbae9c0447a5cbae770a75 Mon Sep 17 00:00:00 2001 From: Ben Wagner Date: Thu, 12 Jul 2018 13:30:47 -0400 Subject: Remove SkSafeSetNull. Update all users to sk_sp. Change-Id: I6453b9456b9a8f9e2b756381797f1382ef9e6561 Reviewed-on: https://skia-review.googlesource.com/141052 Commit-Queue: Ben Wagner Reviewed-by: Herb Derby --- include/core/SkRefCnt.h | 7 ------- include/gpu/GrRenderTarget.h | 3 ++- 2 files changed, 2 insertions(+), 8 deletions(-) (limited to 'include') diff --git a/include/core/SkRefCnt.h b/include/core/SkRefCnt.h index d919c8114c..adebd9b8a6 100644 --- a/include/core/SkRefCnt.h +++ b/include/core/SkRefCnt.h @@ -199,13 +199,6 @@ template static inline void SkSafeUnref(T* obj) { } } -template static inline void SkSafeSetNull(T*& obj) { - if (obj) { - obj->unref(); - obj = nullptr; - } -} - /////////////////////////////////////////////////////////////////////////////// // This is a variant of SkRefCnt that's Not Virtual, so weighs 4 bytes instead of 8 or 16. diff --git a/include/gpu/GrRenderTarget.h b/include/gpu/GrRenderTarget.h index 784e15f8b0..32c6225d29 100644 --- a/include/gpu/GrRenderTarget.h +++ b/include/gpu/GrRenderTarget.h @@ -110,6 +110,7 @@ public: protected: GrRenderTarget(GrGpu*, const GrSurfaceDesc&, GrStencilAttachment* = nullptr); + ~GrRenderTarget() override; // override of GrResource void onAbandon() override; @@ -125,7 +126,7 @@ private: friend class GrRenderTargetPriv; int fSampleCnt; - GrStencilAttachment* fStencilAttachment; + sk_sp fStencilAttachment; SkIRect fResolveRect; -- cgit v1.2.3