From 744908e5e81f81f34288a1b5547aa4ea990ad13d Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Fri, 11 Nov 2016 12:51:36 -0500 Subject: Fix SkModeColorFilter in 565 It has been incorrectly interpreting its SkColor as sRGB all the time. Now, we plumb through the destintation color space and some scratch space, letting it decide how to interpret its SkColor later when it knows about the dst color space. The scratch space is blitter scoped, which lets this be thread safe (this is much like SkShader::Context). This only corrects the gamma transformation for now. I've kept my previous TODO about gamut transformation. Everything assumes sRGB gamut for now. Shaders will get the same treatement in this pipeline. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4725 Change-Id: I55b0c7d5db9ad8d7dcdd6295c9dac61d10aeaed4 Reviewed-on: https://skia-review.googlesource.com/4725 Reviewed-by: Brian Osman Commit-Queue: Mike Klein --- include/effects/SkLumaColorFilter.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'include/effects') diff --git a/include/effects/SkLumaColorFilter.h b/include/effects/SkLumaColorFilter.h index 69edbc9ed2..5cddec6846 100644 --- a/include/effects/SkLumaColorFilter.h +++ b/include/effects/SkLumaColorFilter.h @@ -42,7 +42,8 @@ protected: private: SkLumaColorFilter(); - bool onAppendStages(SkRasterPipeline*, bool shaderIsOpaque) const override; + bool onAppendStages(SkRasterPipeline*, SkColorSpace*, SkFallbackAlloc*, + bool shaderIsOpaque) const override; typedef SkColorFilter INHERITED; }; -- cgit v1.2.3