From 0cf45f607cfc5d22ef9e6fbe0c7480a409349704 Mon Sep 17 00:00:00 2001 From: Greg Daniel Date: Mon, 17 Apr 2017 10:46:51 -0400 Subject: Split SkCrossContextImageData into Image and BackendTexture subclasses This is needed for a follow up CL where we switch from using GrBackendTextureDesc to GrBackendTexture. Bug: skia: Change-Id: Id12d3357af1cc7f30c7f9196e614089779dc0715 Reviewed-on: https://skia-review.googlesource.com/13588 Reviewed-by: Brian Osman Commit-Queue: Greg Daniel --- include/core/SkCrossContextImageData.h | 47 ++++++++++++++++++++++++++-------- 1 file changed, 37 insertions(+), 10 deletions(-) (limited to 'include/core') diff --git a/include/core/SkCrossContextImageData.h b/include/core/SkCrossContextImageData.h index bbee6e742b..beaaaa6a28 100644 --- a/include/core/SkCrossContextImageData.h +++ b/include/core/SkCrossContextImageData.h @@ -32,15 +32,45 @@ public: static std::unique_ptr MakeFromEncoded( GrContext*, sk_sp, SkColorSpace* dstColorSpace); + virtual ~SkCrossContextImageData() {} + +protected: + SkCrossContextImageData() {} + private: - SkCrossContextImageData(sk_sp image) : fImage(std::move(image)) { + virtual sk_sp makeImage(GrContext*) = 0; + + friend class SkImage; +}; + +class SkCCIDImage : public SkCrossContextImageData { +public: + ~SkCCIDImage() override {} + +private: + SkCCIDImage(sk_sp image) : fImage(std::move(image)) { SkASSERT(!fImage->isTextureBacked()); } + sk_sp makeImage(GrContext*) override { + return fImage; + } + + sk_sp fImage; + + friend class SkCrossContextImageData; + friend class SkImage; +}; + #if SK_SUPPORT_GPU - SkCrossContextImageData(const GrBackendTextureDesc& desc, - std::unique_ptr textureData, - SkAlphaType alphaType, sk_sp colorSpace) +class SkCCIDBackendTexture : public SkCrossContextImageData { +public: + ~SkCCIDBackendTexture() override {} + +private: + SkCCIDBackendTexture(const GrBackendTextureDesc& desc, + std::unique_ptr textureData, + SkAlphaType alphaType, sk_sp colorSpace) : fAlphaType(alphaType) , fColorSpace(std::move(colorSpace)) , fDesc(desc) @@ -48,21 +78,18 @@ private: // Point our texture desc at our copy of the backend information fDesc.fTextureHandle = fTextureData->getBackendObject(); } -#endif - // For non-GPU backed images - sk_sp fImage; + sk_sp makeImage(GrContext*) override; -#if SK_SUPPORT_GPU // GPU-backed images store some generic information (needed to reconstruct the SkImage), // and some backend-specific info (to reconstruct the texture). SkAlphaType fAlphaType; sk_sp fColorSpace; GrBackendTextureDesc fDesc; std::unique_ptr fTextureData; -#endif - friend class SkImage; + friend class SkCrossContextImageData; }; +#endif #endif -- cgit v1.2.3