From c87dd2ce965cd1bbc8a74abe0c141658a469d7f2 Mon Sep 17 00:00:00 2001 From: djsollen Date: Fri, 14 Nov 2014 11:11:46 -0800 Subject: Enable unused param checking for public includes. This CL cleans up the existing violations and enables the build time check to ensure that we don't regress. The motiviation behind this change is to allow clients who include our headers to be able to build with this warning enabled. Review URL: https://codereview.chromium.org/726923002 --- include/core/SkImageDecoder.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'include/core/SkImageDecoder.h') diff --git a/include/core/SkImageDecoder.h b/include/core/SkImageDecoder.h index 21077cccff..b384708d30 100644 --- a/include/core/SkImageDecoder.h +++ b/include/core/SkImageDecoder.h @@ -348,13 +348,13 @@ protected: // If the decoder wants to support tiled based decoding, // this method must be overridden. This guy is called by buildTileIndex(...) - virtual bool onBuildTileIndex(SkStreamRewindable*, int *width, int *height) { + virtual bool onBuildTileIndex(SkStreamRewindable*, int* /*width*/, int* /*height*/) { return false; } // If the decoder wants to support tiled based decoding, // this method must be overridden. This guy is called by decodeRegion(...) - virtual bool onDecodeSubset(SkBitmap* bitmap, const SkIRect& rect) { + virtual bool onDecodeSubset(SkBitmap*, const SkIRect&) { return false; } @@ -364,8 +364,9 @@ protected: updates componentSizes to the final image size. Returns whether the decoding was successful. */ - virtual bool onDecodeYUV8Planes(SkStream* stream, SkISize componentSizes[3], void* planes[3], - size_t rowBytes[3], SkYUVColorSpace*) { + virtual bool onDecodeYUV8Planes(SkStream*, SkISize[3] /*componentSizes*/, + void*[3] /*planes*/, size_t[3] /*rowBytes*/, + SkYUVColorSpace*) { return false; } -- cgit v1.2.3