From 297c3c8e85bdb7ed79aaa6a596f52874d79e7a25 Mon Sep 17 00:00:00 2001 From: Ben Wagner Date: Thu, 19 Jul 2018 08:55:10 -0400 Subject: Ignore NTDDI_VERSION with DirectWrite. Some builds set NTDDI_VERSION to a very old version of Windows to ensure they run on those older versions of Windows. The dwrite_3.h header uses NTDDI_VERSION in an odd manner, hiding immutable declarations of enums, structs, and interfaces. NTDDI_VERSION was indended to hide functions and extensions to structs. DWrite has one function (to create the factory) and no structs which will be extended. Skia is already tested to run on the oldest supported Windows platform (Windows 7), so an external build building Skia with NTDDI_VERSION as a build define should have no issues at runtime if Skia ignores it. If Skia doesn't ignore NTDDI_VERSION in this case the DWrite backend will be runtime limited to interfaces in very old versions of Windows, instead of using newer interfaces which become available at runtime. Change-Id: I3e9ac2c4116d75588bfff391928d3cd446d6363a Reviewed-on: https://skia-review.googlesource.com/142324 Commit-Queue: Ben Wagner Reviewed-by: Brian Osman Reviewed-by: Herb Derby --- gn/utils.gni | 1 + 1 file changed, 1 insertion(+) (limited to 'gn') diff --git a/gn/utils.gni b/gn/utils.gni index 95c4e937c7..7d014b0a0c 100644 --- a/gn/utils.gni +++ b/gn/utils.gni @@ -77,6 +77,7 @@ skia_utils_sources = [ "$_src/utils/win/SkDWriteFontFileStream.h", "$_src/utils/win/SkDWriteGeometrySink.cpp", "$_src/utils/win/SkDWriteGeometrySink.h", + "$_src/utils/win/SkDWriteNTDDI_VERSION.h", "$_src/utils/win/SkHRESULT.h", "$_src/utils/win/SkHRESULT.cpp", "$_src/utils/win/SkIStream.h", -- cgit v1.2.3