From d34c4a37276c240733a6d17812653636dc3656b5 Mon Sep 17 00:00:00 2001 From: Brian Osman Date: Wed, 6 Dec 2017 13:26:38 -0500 Subject: Add win_toolchain_version to support MSVC 2017 Updates To make this simpler in the future, add a python script that finds the most recent 2017 toolchain, and use that. If/when we update the bot toolchain, this will be even more helpful, because the Chromium toolchain isn't perfectly in sync with the general update channel, so people are likely to have a newer/older release locally. Note that explicitly setting win_toolchain_version in your GN args suppresses the python script, so you can choose to build with whatever version you need. Bug: skia: Change-Id: Iaf6d0dd9be2623472118c3ad27b20023a205d67c Reviewed-on: https://skia-review.googlesource.com/81162 Commit-Queue: Brian Osman Reviewed-by: Mike Klein --- gn/toolchain/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gn/toolchain') diff --git a/gn/toolchain/BUILD.gn b/gn/toolchain/BUILD.gn index 59d83e43d7..7497bcb690 100644 --- a/gn/toolchain/BUILD.gn +++ b/gn/toolchain/BUILD.gn @@ -41,7 +41,7 @@ toolchain("msvc") { env_setup = "cmd /c $windk/win_sdk/bin/SetEnv.cmd /x86 && " } } else { - bin = "$windk/VC/Tools/MSVC/14.10.25017/bin/HostX64/$target_cpu" + bin = "$windk/VC/Tools/MSVC/$win_toolchain_version/bin/HostX64/$target_cpu" env_setup = "" if (target_cpu == "x86") { print("Be sure to run") -- cgit v1.2.3