From 1b9b7d539335030e3d269a57d418a4fa6d62c038 Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Tue, 27 Feb 2018 10:37:40 -0500 Subject: Reland "Reland "make SkJumper stages normal Skia code"" This is a reland of 78cb579f33943421afc8423a39867fcfd69fed44 This time, lowp stages are controlled by !defined(JUMPER_IS_SCALAR), not by defined(__clang__). The two are usually the same, except when we opt Clang builds into JUMPER_IS_SCALAR artificially. Some Google3 builds use compilers old enough that they barf when compiling our NEON code. It's conceivably also possible to define JUMPER_IS_SCALAR yourself, but I don't think anyone does that. Original change's description: > Reland "make SkJumper stages normal Skia code" > > This is a reland of 22e536e3a1a09405d1c0e6f071717a726d86e8d4 > > Now with fixed #include paths in SkRasterPipeline_opts.h, > and -ffp-contract=fast for the :hsw target to minimize > diffs on non-Windows Clang AVX2/AVX-512 bots. > > Original change's description: > > make SkJumper stages normal Skia code > > > > Enough clients are using Clang now that we can say, use Clang to build > > if you want these software pipeline stages to go fast. > > > > This lets us drop the offline build aspect of SkJumper stages, instead > > building as part of Skia using the SkOpts framework. > > > > I think everything should work, except I've (temporarily) removed > > AVX-512 support. I will put this back in a follow up. > > > > I have had to drop Windows down to __vectorcall and our narrower > > stage calling convention that keeps the d-registers on the stack. > > I tried forcing sysv_abi, but that crashed Clang. :/ > > > > Added a TODO to up the same narrower stage calling convention > > for lowp stages... we just *don't* today, for no good reason. > > > > Change-Id: Iaaa792ffe4deab3508d2dc5d0008c163c24b3383 > > Reviewed-on: https://skia-review.googlesource.com/110641 > > Commit-Queue: Mike Klein > > Reviewed-by: Herb Derby > > Reviewed-by: Florin Malita > > Change-Id: I44f2c03d33958e3807747e40904b6351957dd448 > Reviewed-on: https://skia-review.googlesource.com/112742 > Reviewed-by: Mike Klein Change-Id: I3d71197d4bbb19ca4a94961a97fa2e54d5cbfb0d Reviewed-on: https://skia-review.googlesource.com/112744 Reviewed-by: Mike Klein Commit-Queue: Mike Klein --- gn/shared_sources.gni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gn/shared_sources.gni') diff --git a/gn/shared_sources.gni b/gn/shared_sources.gni index 29cac671a4..6df999921a 100644 --- a/gn/shared_sources.gni +++ b/gn/shared_sources.gni @@ -24,7 +24,7 @@ skia_opts = { sse41_sources = sse41 sse42_sources = sse42 avx_sources = avx - hsw_sources = [] # remove after we update Chrome + hsw_sources = hsw } # Skia Chromium defines. These flags will be defined in chromium If these -- cgit v1.2.3