From 804d0f28ba6de89b7e671c0e9192e16b7494944d Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Thu, 31 May 2018 13:16:59 -0400 Subject: turn on pointer-overflow on ASAN/UBSAN bots I know SkRasterPipelineBlitter will add back offsets to the mask pointer to make these fMaskPtr.pixels safe. SkImageInfo wasn't making out-of-bounds pointers, but was moving between two in-bounds pointers by subtracting large (negative) size_t. Switching to explicit negate and add quiets this down. Bug: chromium:836282 Change-Id: Ia65e380ec41dbfedce0659106830fbacb1a5cf4a Reviewed-on: https://skia-review.googlesource.com/131147 Reviewed-by: Mike Reed Reviewed-by: Cary Clark Commit-Queue: Mike Klein --- gn/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gn/BUILD.gn') diff --git a/gn/BUILD.gn b/gn/BUILD.gn index 9d65118c96..80b7f3f1bc 100644 --- a/gn/BUILD.gn +++ b/gn/BUILD.gn @@ -228,7 +228,7 @@ config("default") { fyi_sanitizers = fyi_sanitize if (sanitize == "ASAN" || sanitize == "UBSAN") { # ASAN implicitly runs all UBSAN checks also. - sanitizers = "bool,float-cast-overflow,integer-divide-by-zero,nonnull-attribute,null,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound" + sanitizers = "bool,float-cast-overflow,integer-divide-by-zero,nonnull-attribute,null,pointer-overflow,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound" if (fyi_sanitize == "" && !is_android) { fyi_sanitizers = "float-divide-by-zero" -- cgit v1.2.3