From 314d7c267f968643966d0e9678db9ef4e53456a4 Mon Sep 17 00:00:00 2001 From: Ben Wagner Date: Wed, 3 Jan 2018 11:04:30 -0500 Subject: Add Win UBSAN jobs. Bug: skia:2679 Change-Id: Ia462af01b9832da90206b9e9be2278cb48c6c502 Reviewed-on: https://skia-review.googlesource.com/86401 Reviewed-by: Mike Klein Commit-Queue: Ben Wagner --- gn/BUILD.gn | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) (limited to 'gn/BUILD.gn') diff --git a/gn/BUILD.gn b/gn/BUILD.gn index 52c0838737..c94d2372d8 100644 --- a/gn/BUILD.gn +++ b/gn/BUILD.gn @@ -206,13 +206,22 @@ config("default") { # You can either pass the sanitizers directly, e.g. "address,undefined", # or pass one of the couple common aliases used by the bots. sanitizers = sanitize - if (sanitize == "ASAN") { - sanitizers = "address,bool,float-cast-overflow,integer-divide-by-zero,nonnull-attribute,null,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound,vptr" - if (!is_mac) { - sanitizers += ",function" # Not supported on Mac. + if (sanitize == "ASAN" || sanitize == "UBSAN") { + # ASAN implicitly runs all UBSAN checks also. + sanitizers = "bool,float-cast-overflow,integer-divide-by-zero,nonnull-attribute,null,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound" + if (!is_mac && !is_win) { + sanitizers += ",function" # Not supported on Mac or Win. } - if (!is_debug) { - sanitizers += ",object-size" # No-op with somewhat annoying warning at -O0. + if (!is_win) { + sanitizers += ",vptr" # Not supported on Win. + } + if (!is_debug && !is_win) { + # No-op with somewhat annoying warning at -O0. + # Seems to be broken on Win. + sanitizers += ",object-size" + } + if (sanitize == "ASAN") { + sanitizers += ",address" } } else if (sanitize == "TSAN") { sanitizers = "thread" -- cgit v1.2.3