From 532b3f944a4991064963aee8f535c695f4068368 Mon Sep 17 00:00:00 2001 From: Brian Osman Date: Wed, 11 Jul 2018 10:02:07 -0400 Subject: Remove clamping of kPlus with F16 configs The most common use-case for F16 is to draw things that are explicitly outside of [0,1]. We can't prevent out-of-range values in general, users could just draw out-of-range content in src mode. We've decided that it's best to avoid surprising behavior, and trust the user in these situations. This effectively reverts https://skia-review.googlesource.com/c/skia/+/48183 Bug: skia: Change-Id: I71c2dd925c567e2862d96ab70c752f19245a69c4 Reviewed-on: https://skia-review.googlesource.com/140500 Reviewed-by: Mike Klein Reviewed-by: Brian Salomon Commit-Queue: Brian Osman --- gm/beziereffects.cpp | 5 ++--- gm/convexpolyeffect.cpp | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) (limited to 'gm') diff --git a/gm/beziereffects.cpp b/gm/beziereffects.cpp index 9f3bcd74ec..d3af3db802 100644 --- a/gm/beziereffects.cpp +++ b/gm/beziereffects.cpp @@ -29,10 +29,9 @@ class BezierTestOp : public GrMeshDrawOp { public: FixedFunctionFlags fixedFunctionFlags() const override { return FixedFunctionFlags::kNone; } - RequiresDstTexture finalize(const GrCaps& caps, const GrAppliedClip* clip, - GrPixelConfigIsClamped dstIsClamped) override { + RequiresDstTexture finalize(const GrCaps& caps, const GrAppliedClip* clip) override { auto analysis = fProcessorSet.finalize(fColor, GrProcessorAnalysisCoverage::kSingleChannel, - clip, false, caps, dstIsClamped, &fColor); + clip, false, caps, &fColor); return analysis.requiresDstTexture() ? RequiresDstTexture::kYes : RequiresDstTexture::kNo; } diff --git a/gm/convexpolyeffect.cpp b/gm/convexpolyeffect.cpp index 3c825dc78a..78dcfe1add 100644 --- a/gm/convexpolyeffect.cpp +++ b/gm/convexpolyeffect.cpp @@ -58,10 +58,9 @@ public: FixedFunctionFlags fixedFunctionFlags() const override { return FixedFunctionFlags::kNone; } - RequiresDstTexture finalize(const GrCaps& caps, const GrAppliedClip* clip, - GrPixelConfigIsClamped dstIsClamped) override { + RequiresDstTexture finalize(const GrCaps& caps, const GrAppliedClip* clip) override { auto analysis = fProcessors.finalize(fColor, GrProcessorAnalysisCoverage::kNone, clip, - false, caps, dstIsClamped, &fColor); + false, caps, &fColor); return analysis.requiresDstTexture() ? RequiresDstTexture::kYes : RequiresDstTexture::kNo; } -- cgit v1.2.3