From d494b09f554d470fc6411d0924879bbfb0cb0e95 Mon Sep 17 00:00:00 2001 From: "commit-bot@chromium.org" Date: Thu, 10 Oct 2013 20:13:51 +0000 Subject: Align SkLumaColorFilter with the spec. The spec requires the resulting RGB channels for LuminanceToAlpha to be 0 (and not just scaled by the luminance value): | R' | | 0 0 0 0 0 | | R | | G' | | 0 0 0 0 0 | | G | | B' | = | 0 0 0 0 0 | * | B | | A' | | 0.2125 0.7154 0.0721 0 0 | | A | | 1 | | 0 0 0 0 1 | | 1 | (http://www.w3.org/TR/2011/REC-SVG11-20110816/filters.html#feColorMatrixElement) This doesn't affect luminance masking (which depends only on the resulting alpha channel), but other color filter users may care about all color components. R=bsalomon@google.com, reed@google.com, robertphillips@google.com Author: fmalita@chromium.org Review URL: https://codereview.chromium.org/26467003 git-svn-id: http://skia.googlecode.com/svn/trunk@11713 2bbb7eff-a529-9590-31e7-b0007b416f81 --- gm/lumafilter.cpp | 1 + 1 file changed, 1 insertion(+) (limited to 'gm/lumafilter.cpp') diff --git a/gm/lumafilter.cpp b/gm/lumafilter.cpp index 69a4f073f0..c12bae0ba5 100644 --- a/gm/lumafilter.cpp +++ b/gm/lumafilter.cpp @@ -34,6 +34,7 @@ static void draw_scene(SkCanvas* canvas, SkColorFilter* filter, c = bounds; c.fRight = bounds.centerX(); + paint.setARGB(0x20, 0, 0, 0xff); canvas->drawRect(bounds, paint); canvas->saveLayer(&bounds, NULL); -- cgit v1.2.3