From e4636aa17307b00c76e228fc5ddda1bd4904e0dd Mon Sep 17 00:00:00 2001 From: mtklein Date: Wed, 9 Jul 2014 13:10:58 -0700 Subject: Merge Replay and Quilt tasks, adding in all BBH implementations. Replay isn't that helpful of a test any more now that we have the more stringent Quilt tests. Quilt was missing bounding box hierarchies, though, while Replay was sort of testing RTree (pointlessly, as it was drawing without any clip). Now Quilt does everything, testing RTree, QuadTree, and TileGrid. Quilt mode now falls back to drawing all at once (i.e. Replay) for GMs that don't tile perfectly. Still a TODO to make this check more flexible than exact pixel matches. Two GMs fail when using a BBH: - imageresizetiled - resizeimagefilter We think we're not adjusting the bounds of save layers by their paint. This is probably a bug, but one to be fixed separately from adding new tests. BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/377373003 --- gm/imageresizetiled.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'gm/imageresizetiled.cpp') diff --git a/gm/imageresizetiled.cpp b/gm/imageresizetiled.cpp index ff02020813..ec602749ac 100644 --- a/gm/imageresizetiled.cpp +++ b/gm/imageresizetiled.cpp @@ -22,6 +22,8 @@ public: } protected: + virtual uint32_t onGetFlags() const SK_OVERRIDE { return kNoBBH_Flag; } + virtual SkString onShortName() SK_OVERRIDE { return SkString("imageresizetiled"); } -- cgit v1.2.3