From 898235c4864df66aa7f6d32bc2a8b8551040ce1e Mon Sep 17 00:00:00 2001 From: brianosman Date: Wed, 6 Apr 2016 07:38:23 -0700 Subject: SkSurfaceProps now has a gamma-correct ("AllowSRGBInputs") flag. That's propagated in a few places so that the backend can do the right thing for L32 vs S32 mode. Also added SkSurfaceProps to SkSpecialImage, so that Image -> Surface conversion can preserve the desired behavior during filtering. Many small changes, including a bunch of comments about places where we may be losing information right now. My approach was to ensure that if anything fails, it will always fall back to "legacy" mode - gamma-correctness is opt-in, so I'll just have to feed things through as missing cases are exposed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1838953007 Review URL: https://codereview.chromium.org/1845283003 --- gm/constcolorprocessor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'gm/constcolorprocessor.cpp') diff --git a/gm/constcolorprocessor.cpp b/gm/constcolorprocessor.cpp index 8c91a722ec..37295c78cc 100644 --- a/gm/constcolorprocessor.cpp +++ b/gm/constcolorprocessor.cpp @@ -104,7 +104,8 @@ protected: } else { skPaint.setColor(kPaintColors[paintType]); } - SkAssertResult(SkPaintToGrPaint(context, skPaint, viewMatrix, &grPaint)); + // SRGBTODO: No sRGB inputs allowed here? + SkAssertResult(SkPaintToGrPaint(context, skPaint, viewMatrix, false, &grPaint)); GrConstColorProcessor::InputMode mode = (GrConstColorProcessor::InputMode) m; GrColor color = kColors[procColor]; -- cgit v1.2.3