From 7cdc1ee11545a10708e857adf1d4a94a2f1e2a48 Mon Sep 17 00:00:00 2001 From: mtklein Date: Mon, 7 Jul 2014 10:41:04 -0700 Subject: Add always-threaded SkRecord quilt tests. Now that we're drawing tiles threaded like implside painting, remove the checks that those lock counts are balanced. They're just not right for anyone anymore. SkBitmaps themselves are not threadsafe (even const ones), so shallow copy them on playback of an SkRecord. (The underlying SkPixelRefs are threadsafe.) Simplify quilt drawing by using SkBitmap::extractSubset. No need for locking. Bump up to 256x256 tiles. 16x16 tiles just murders performance (way too much contention). This has the nice side effect of letting us enable a bunch more GMs for quilt mode; they drew wrong with small tiles but exactly right with large. BUG=171776 R=reed@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/371023005 --- gm/blurroundrect.cpp | 8 -------- 1 file changed, 8 deletions(-) (limited to 'gm/blurroundrect.cpp') diff --git a/gm/blurroundrect.cpp b/gm/blurroundrect.cpp index 3e6f1bdd98..d78335f2a6 100644 --- a/gm/blurroundrect.cpp +++ b/gm/blurroundrect.cpp @@ -42,10 +42,6 @@ public: fRRect.setRectRadii(r, radii); } - virtual uint32_t onGetFlags() const SK_OVERRIDE { - return kSkipTiled_Flag; - } - virtual SkString onShortName() SK_OVERRIDE { return fName; } @@ -104,10 +100,6 @@ public: } protected: - virtual uint32_t onGetFlags() const SK_OVERRIDE { - return kSkipTiled_Flag; - } - virtual SkString onShortName() SK_OVERRIDE { return fName; } -- cgit v1.2.3