From e083f7c9f2ed6640866e2d974aabb98e6f3d0712 Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Wed, 7 Feb 2018 12:54:27 -0500 Subject: Reland "remove SkCanvas::kIsOpaque_SaveLayerFlag" This reverts the revert 9ff8c8c073ba553dc8b22bb9aacc23949292f72f. Original: This is a performance-only hint that no one but fuzzers is using. It's even explicitly filtered out in Android. The fuzzers have noticed they can trick us into allocating uninitialized memory and treating it as opaque, blending uninitialized pixels, etc. Since no one's using this, we can just kill the bit. Bug: skia:7566, chromium:808830 Docs-Preview: https://skia.org/?cl=105282 Change-Id: I4326c663f777aa373ff7ec9f319519da9729350d Reviewed-on: https://skia-review.googlesource.com/105282 Reviewed-by: Mike Klein Commit-Queue: Mike Klein --- fuzz/FuzzCanvas.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'fuzz') diff --git a/fuzz/FuzzCanvas.cpp b/fuzz/FuzzCanvas.cpp index 0334d85d36..ffc8781e6b 100644 --- a/fuzz/FuzzCanvas.cpp +++ b/fuzz/FuzzCanvas.cpp @@ -1150,9 +1150,6 @@ static void fuzz_canvas(Fuzz* fuzz, SkCanvas* canvas, int depth = 9) { } // _DumpCanvas can't handle this. // if (make_fuzz_t(fuzz)) { - // saveLayerRec.fSaveLayerFlags |= SkCanvas::kIsOpaque_SaveLayerFlag; - // } - // if (make_fuzz_t(fuzz)) { // saveLayerRec.fSaveLayerFlags |= SkCanvas::kPreserveLCDText_SaveLayerFlag; // } -- cgit v1.2.3