From 9a7a2ee5ad8453a985d7d76c1e0ebb50d17fec63 Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Tue, 6 Feb 2018 14:53:47 -0500 Subject: remove SkCanvas::kIsOpaque_SaveLayerFlag This is a performance-only hint that no one but fuzzers is using. It's even explicitly filtered out in Android. The fuzzers have noticed they can trick us into allocating uninitialized memory and treating it as opaque, blending uninitialized pixels, etc. Since no one's using this, we can just kill the bit. Bug: skia:7566, chromium:808830 Change-Id: Id74a85e51bc4d0907b4127eb9ac5b02576f8f0a7 Reviewed-on: https://skia-review.googlesource.com/104441 Reviewed-by: Mike Reed Commit-Queue: Mike Klein --- fuzz/FuzzCanvas.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'fuzz/FuzzCanvas.cpp') diff --git a/fuzz/FuzzCanvas.cpp b/fuzz/FuzzCanvas.cpp index 0334d85d36..ffc8781e6b 100644 --- a/fuzz/FuzzCanvas.cpp +++ b/fuzz/FuzzCanvas.cpp @@ -1150,9 +1150,6 @@ static void fuzz_canvas(Fuzz* fuzz, SkCanvas* canvas, int depth = 9) { } // _DumpCanvas can't handle this. // if (make_fuzz_t(fuzz)) { - // saveLayerRec.fSaveLayerFlags |= SkCanvas::kIsOpaque_SaveLayerFlag; - // } - // if (make_fuzz_t(fuzz)) { // saveLayerRec.fSaveLayerFlags |= SkCanvas::kPreserveLCDText_SaveLayerFlag; // } -- cgit v1.2.3