From b09bfcb7b1c755c996ed76bba377201048e454af Mon Sep 17 00:00:00 2001 From: "commit-bot@chromium.org" Date: Tue, 17 Dec 2013 23:37:38 +0000 Subject: add virtual destructor for SkExample to fix build error. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The original SkExample have virtual function draw(), but have no virtual destructor. This may lead to memory leak when free the instance of derived class of SkExample. The latest skia code show error when build SkiaExamples by "ninja -C out/Release SkiaExamples": error: ‘class SkExample’ has virtual functions and accessible non-virtual destructor. R=caryclark@google.com Author: yunchao.he@intel.com Review URL: https://codereview.chromium.org/98463013 git-svn-id: http://skia.googlecode.com/svn/trunk@12728 2bbb7eff-a529-9590-31e7-b0007b416f81 --- experimental/SkiaExamples/SkExample.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'experimental') diff --git a/experimental/SkiaExamples/SkExample.h b/experimental/SkiaExamples/SkExample.h index bea3aec4fc..4b84723ac2 100644 --- a/experimental/SkiaExamples/SkExample.h +++ b/experimental/SkiaExamples/SkExample.h @@ -23,6 +23,8 @@ class SkExample : public SkNoncopyable { public: SkExample(SkExampleWindow* window) : fWindow(window) {} + virtual ~SkExample() {} + // Your class should override this method to do its thing. virtual void draw(SkCanvas* canvas) = 0; -- cgit v1.2.3