From 641cce90c99f17e7c4d3d6407c3c4bbf591c5a3f Mon Sep 17 00:00:00 2001 From: "edisonn@google.com" Date: Tue, 30 Jul 2013 12:09:14 +0000 Subject: pdfviewer: fix condition for element in array, reset back the default color to white, and verify type before value in PDF API mapper Review URL: https://codereview.chromium.org/21017004 git-svn-id: http://skia.googlecode.com/svn/trunk@10427 2bbb7eff-a529-9590-31e7-b0007b416f81 --- experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'experimental/PdfViewer/pdfparser/native') diff --git a/experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp b/experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp index e54ba825bc..9e89b84424 100644 --- a/experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp +++ b/experimental/PdfViewer/pdfparser/native/SkNativeParsedPDF.cpp @@ -504,12 +504,12 @@ SkPdfObject* SkNativeParsedPDF::resolveReference(const SkPdfObject* ref) { SkASSERT(!(id < 0 || id > fObjects.count())); - if (id < 0 || id > fObjects.count()) { + // TODO(edisonn): verify id and gen expected + if (id < 0 || id >= fObjects.count()) { + // TODO(edisonn): report error/warning return NULL; } - // TODO(edisonn): verify id and gen expected - if (fObjects[id].fResolvedReference != NULL) { return fObjects[id].fResolvedReference; } -- cgit v1.2.3