From 7035a8e797eba8ccccff057525d01cf02c1f2a02 Mon Sep 17 00:00:00 2001 From: Brian Osman Date: Fri, 15 Dec 2017 14:25:11 -0500 Subject: Fix benches that aren't really timing what we want Remove full clears from benches Fix unbounded canvas modification in GM benches Bug: skia: Change-Id: Ie3d67282714a7b4e980aec399056c0e9df330993 Reviewed-on: https://skia-review.googlesource.com/86040 Reviewed-by: Mike Klein Commit-Queue: Brian Osman --- bench/BlurOccludedRRectBench.cpp | 2 -- bench/ChartBench.cpp | 3 --- bench/GMBench.cpp | 1 + 3 files changed, 1 insertion(+), 5 deletions(-) (limited to 'bench') diff --git a/bench/BlurOccludedRRectBench.cpp b/bench/BlurOccludedRRectBench.cpp index a3c9e193ac..2de50c509a 100644 --- a/bench/BlurOccludedRRectBench.cpp +++ b/bench/BlurOccludedRRectBench.cpp @@ -27,8 +27,6 @@ public: void onDraw(int loops, SkCanvas* canvas) override { for (int l = 0; l < loops; ++l) { - canvas->clear(0xFFFAFAFA); - SkPaint opaque; opaque.setAntiAlias(true); opaque.setColor(SK_ColorWHITE); diff --git a/bench/ChartBench.cpp b/bench/ChartBench.cpp index 71e311c2b3..944f6104b7 100644 --- a/bench/ChartBench.cpp +++ b/bench/ChartBench.cpp @@ -132,9 +132,6 @@ protected: } for (int frame = 0; frame < loops; ++frame) { - - canvas->clear(0xFFE0F0E0); - SkPath plotPath; SkPath fillPath; diff --git a/bench/GMBench.cpp b/bench/GMBench.cpp index 6037a8221c..297ff42b74 100644 --- a/bench/GMBench.cpp +++ b/bench/GMBench.cpp @@ -27,6 +27,7 @@ void GMBench::onDraw(int loops, SkCanvas* canvas) { // Does the GM ever rely on drawBackground to lazily compute something? fGM->drawBackground(canvas); for (int i = 0; i < loops; ++i) { + SkAutoCanvasRestore acr(canvas, true); fGM->drawContent(canvas); } } -- cgit v1.2.3