From 05af1afd429808913683da75644e48bece12e820 Mon Sep 17 00:00:00 2001 From: "humper@google.com" Date: Mon, 7 Jan 2013 16:47:43 +0000 Subject: eliminate all warnings in non-thirdparty code on mac Most of these issues were due to functions whose definitions appear in header files; I changed those functions to be 'static inline' instead of just 'static' or 'inline', which kills the warning for such functions. Other functions that were static or anonymous-namespaced but were unused in cpp files were probably called at some point but are no longer; someone who knows more than I do should probably scrub all the functions I either deleted or #if 0'ed out and make sure that the right thing is happening here. Lots of unused variables removed, and one nasty const issue handled. There remains a single warning in thirdparty/externals/cityhash/src/city.cc on line 146 related to a signed/unsigned mismatch. I don't know if we have control over this library so I didn't fix this one, but perhaps someone could do something about that one. BUG= Review URL: https://codereview.appspot.com/7067044 git-svn-id: http://skia.googlecode.com/svn/trunk@7051 2bbb7eff-a529-9590-31e7-b0007b416f81 --- bench/ChromeBench.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'bench/ChromeBench.cpp') diff --git a/bench/ChromeBench.cpp b/bench/ChromeBench.cpp index f045573bea..ea5cb00878 100644 --- a/bench/ChromeBench.cpp +++ b/bench/ChromeBench.cpp @@ -491,7 +491,7 @@ private: typedef SkBenchmark INHERITED; }; -static SkBenchmark* ScrollGmailFactory(void* p) { +static inline SkBenchmark* ScrollGmailFactory(void* p) { return SkNEW_ARGS(ScrollGmailBench, (p)); } -- cgit v1.2.3