From 4e97607d9a1cef66fac16f347c5ca813ec4f9515 Mon Sep 17 00:00:00 2001 From: mtklein Date: Mon, 8 Aug 2016 09:06:27 -0700 Subject: Use sse4.2 CRC32 instructions to hash when available. About 9x faster than Murmur3 for long inputs. Most of this is a mechanical change from SkChecksum::Murmur3(...) to SkOpts::hash(...). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review-Url: https://codereview.chromium.org/2208903002 --- bench/ChecksumBench.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'bench/ChecksumBench.cpp') diff --git a/bench/ChecksumBench.cpp b/bench/ChecksumBench.cpp index 4c2ac1a396..f84cd3d3bc 100644 --- a/bench/ChecksumBench.cpp +++ b/bench/ChecksumBench.cpp @@ -7,13 +7,14 @@ #include "Benchmark.h" #include "SkCanvas.h" #include "SkChecksum.h" +#include "SkOpts.h" #include "SkMD5.h" #include "SkRandom.h" #include "SkTemplates.h" enum ChecksumType { kMD5_ChecksumType, - kMurmur3_ChecksumType, + kHash_ChecksumType, }; class ComputeChecksumBench : public Benchmark { @@ -40,7 +41,7 @@ protected: const char* onGetName() override { switch (fType) { case kMD5_ChecksumType: return "compute_md5"; - case kMurmur3_ChecksumType: return "compute_murmur3"; + case kHash_ChecksumType: return "compute_hash"; default: SK_ABORT("Invalid Type"); return ""; } @@ -56,9 +57,9 @@ protected: md5.finish(digest); } } break; - case kMurmur3_ChecksumType: { + case kHash_ChecksumType: { for (int i = 0; i < loops; i++) { - volatile uint32_t result = SkChecksum::Murmur3(fData, sizeof(fData)); + volatile uint32_t result = SkOpts::hash(fData, sizeof(fData)); sk_ignore_unused_variable(result); } }break; @@ -73,4 +74,4 @@ private: /////////////////////////////////////////////////////////////////////////////// DEF_BENCH( return new ComputeChecksumBench(kMD5_ChecksumType); ) -DEF_BENCH( return new ComputeChecksumBench(kMurmur3_ChecksumType); ) +DEF_BENCH( return new ComputeChecksumBench(kHash_ChecksumType); ) -- cgit v1.2.3