From 3361471a3504ecd0351ff70f4c42d8d6fee963d4 Mon Sep 17 00:00:00 2001 From: "commit-bot@chromium.org" Date: Tue, 3 Dec 2013 18:17:16 +0000 Subject: Simplify benchmark internal API. I'm not quite sure why I wrote such a convoluted API with setLoops()/getLoops(). This replaces it with a loops argument passed to onDraw(). This CL is largely mechanical translation from the old API to the new one. MathBench used this->getLoops() outside onDraw(), which seems incorrect. I fixed it. BUG= R=djsollen@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/99893003 git-svn-id: http://skia.googlecode.com/svn/trunk@12466 2bbb7eff-a529-9590-31e7-b0007b416f81 --- bench/AAClipBench.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'bench/AAClipBench.cpp') diff --git a/bench/AAClipBench.cpp b/bench/AAClipBench.cpp index dfafe97671..ab0f4f9a00 100644 --- a/bench/AAClipBench.cpp +++ b/bench/AAClipBench.cpp @@ -43,12 +43,12 @@ public: protected: virtual const char* onGetName() { return fName.c_str(); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(const int loops, SkCanvas* canvas) { SkPaint paint; this->setupPaint(&paint); - for (int i = 0; i < this->getLoops(); ++i) { + for (int i = 0; i < loops; ++i) { // jostle the clip regions each time to prevent caching fClipRect.offset((i % 2) == 0 ? SkIntToScalar(10) : SkIntToScalar(-10), 0); fClipPath.reset(); @@ -158,9 +158,9 @@ protected: canvas->restore(); } - virtual void onDraw(SkCanvas* canvas) { + virtual void onDraw(const int loops, SkCanvas* canvas) { - for (int i = 0; i < this->getLoops(); ++i) { + for (int i = 0; i < loops; ++i) { SkPoint offset = SkPoint::Make(0, 0); this->recurse(canvas, 0, offset); } @@ -195,11 +195,11 @@ public: protected: virtual const char* onGetName() { return fName.c_str(); } - virtual void onDraw(SkCanvas*) { + virtual void onDraw(const int loops, SkCanvas*) { SkPaint paint; this->setupPaint(&paint); - for (int i = 0; i < this->getLoops(); ++i) { + for (int i = 0; i < loops; ++i) { SkAAClip clip; if (fDoPath) { clip.setPath(fPath, &fRegion, fDoAA); @@ -230,8 +230,8 @@ public: protected: virtual const char* onGetName() { return "aaclip_setregion"; } - virtual void onDraw(SkCanvas*) { - for (int i = 0; i < this->getLoops(); ++i) { + virtual void onDraw(const int loops, SkCanvas*) { + for (int i = 0; i < loops; ++i) { SkAAClip clip; clip.setRegion(fRegion); } -- cgit v1.2.3