From 8c6a43a1c06de67311f1fd0d16338f50f4f4c1d6 Mon Sep 17 00:00:00 2001 From: Ravi Mistry Date: Wed, 23 Nov 2016 13:26:34 -0500 Subject: Do not use post upload hooks for 'GOLD_TRYBOT_URL' That information will be provided via a plugin soon. # This code is not exercised by trybots. NOTRY=true BUG=skia:6000 Change-Id: I6ea60783c0581e32317a781e4349e95b38b71da0 Reviewed-on: https://skia-review.googlesource.com/5207 Commit-Queue: Ravi Mistry Reviewed-by: Eric Boren --- PRESUBMIT.py | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'PRESUBMIT.py') diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 4dc21c9fde..a61f732dae 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -448,7 +448,6 @@ def PostUploadHook(cl, change, output_api): """git cl upload will call this hook after the issue is created/modified. This hook does the following: - * Adds a link to the CL's Gold trybot results. * Adds a link to preview docs changes if there are any docs changes in the CL. * Adds 'NOTRY=true' if the CL contains only docs changes. * Adds 'NOTREECHECKS=true' for non master branch changes since they do not @@ -486,15 +485,6 @@ def PostUploadHook(cl, change, output_api): new_description = original_description - # Add GOLD_TRYBOT_URL if it does not exist yet. - if not re.search(r'^GOLD_TRYBOT_URL=', new_description, re.M | re.I): - new_description += '\nGOLD_TRYBOT_URL= %s%s' % (GOLD_TRYBOT_URL, issue) - results.append( - output_api.PresubmitNotifyResult( - 'Added link to Gold trybot runs to the CL\'s description.\n' - 'Note: Results may take sometime to be populated after trybots ' - 'complete.')) - # If the change includes only doc changes then add NOTRY=true in the # CL's description if it does not exist yet. if all_docs_changes and not re.search( -- cgit v1.2.3