From 60b0a2d85cb8f9a8fcb91a77b1994a6177f3725f Mon Sep 17 00:00:00 2001 From: borenet Date: Tue, 4 Oct 2016 12:45:41 -0700 Subject: Add --test to gen_tasks.go, add presubmit check BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392083002 Review-Url: https://codereview.chromium.org/2392083002 --- PRESUBMIT.py | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) (limited to 'PRESUBMIT.py') diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 8115b497b6..4798a02d59 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -183,6 +183,24 @@ def _RecipeSimulationTest(input_api, output_api): '`%s` failed:\n%s' % (' '.join(cmd), e.output))) return results + +def _GenTasksTest(input_api, output_api): + """Run gen_tasks.go test.""" + results = [] + if not any(f.LocalPath().startswith('infra') + for f in input_api.AffectedFiles()): + return results + + gen_tasks = os.path.join('infra', 'bots', 'gen_tasks.go') + cmd = ['go', 'run', gen_tasks, '--test'] + try: + subprocess.check_output(cmd) + except subprocess.CalledProcessError as e: + results.append(output_api.PresubmitError( + '`%s` failed:\n%s' % (' '.join(cmd), e.output))) + return results + + def _CheckGNFormatted(input_api, output_api): """Make sure any .gn files we're changing have been formatted.""" results = [] @@ -234,8 +252,10 @@ def CheckChangeOnUpload(input_api, output_api): results = [] results.extend(_CommonChecks(input_api, output_api)) # Run on upload, not commit, since the presubmit bot apparently doesn't have - # coverage installed. + # coverage or Go installed. results.extend(_RecipeSimulationTest(input_api, output_api)) + results.extend(_GenTasksTest(input_api, output_api)) + results.extend(_CheckGNFormatted(input_api, output_api)) return results -- cgit v1.2.3