From 98242a847ac06e7f88d9b61ef1197a3bbfa9d89a Mon Sep 17 00:00:00 2001 From: Brian Osman Date: Tue, 13 Mar 2018 14:35:27 +0000 Subject: Revert "Reland "Add SkColorSpaceXform_skcms"" This reverts commit 57337d90a56f458451a01944efcdc205473bc0bb. Reason for revert: More investigation needed... Original change's description: > Reland "Add SkColorSpaceXform_skcms" > > This reverts commit 8103ecae7b535f011f89b03545fe768801027b6b. > > Reason for revert: Investigated the 565 diffs, they appear to be *more* correct. > > Original change's description: > > Revert "Add SkColorSpaceXform_skcms" > > > > This reverts commit 67f62b1a61016ad07b44ae5a0bbf79d97adc9ba9. > > > > Reason for revert: I want to investigate the image/colorimage gold diffs. May be correct, but some of them are pretty large. > > > > Original change's description: > > > Add SkColorSpaceXform_skcms > > > > > > Currently only enabled in Skia dev builds. Passes all unit > > > tests. Has some GM differences, but nothing major. > > > > > > Bug: skia: > > > Change-Id: Ib87f8cff44649c731e829f063ccef448d67d1910 > > > Reviewed-on: https://skia-review.googlesource.com/112520 > > > Commit-Queue: Brian Osman > > > Reviewed-by: Mike Klein > > > > TBR=mtklein@google.com,brianosman@google.com,reed@google.com > > > > Change-Id: Ib4d7174f5c2700d6f742f488e740e5a6c87ac7a8 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia: > > Reviewed-on: https://skia-review.googlesource.com/113880 > > Reviewed-by: Brian Osman > > Commit-Queue: Brian Osman > > TBR=mtklein@google.com,brianosman@google.com,reed@google.com > > Change-Id: I6501ff55349a6aeed62bb64afc47f789e8cc3460 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/114040 > Reviewed-by: Brian Osman > Commit-Queue: Brian Osman TBR=mtklein@google.com,brianosman@google.com,reed@google.com Change-Id: Ic9ee46032762a8b5fc96314c460ce01708673472 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114100 Reviewed-by: Brian Osman Commit-Queue: Brian Osman --- BUILD.gn | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'BUILD.gn') diff --git a/BUILD.gn b/BUILD.gn index d88048c29f..0fd12512ba 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -726,12 +726,11 @@ optional("raw") { optional("skcms") { enabled = skia_use_skcms - public_defines = [ "SK_USE_SKCMS" ] deps = [ "//third_party/skcms", ] sources = [ - "src/core/SkColorSpaceXform_skcms.cpp", + # TODO ] } -- cgit v1.2.3