From a9d9ab368318cd948ca6ce2796f69ef95e7c1f1a Mon Sep 17 00:00:00 2001 From: Cary Clark Date: Thu, 11 May 2017 09:12:57 -0400 Subject: fix SkASSERT for Visual Studio Changing colons to parens permits the error to be recognized, so that clicking on it goes to the source line with the assert. R=reed@google.com Change-Id: Ifec7fc0633e8ecf0f670418fefaf8ca87ee3d498 Reviewed-on: https://skia-review.googlesource.com/16485 Reviewed-by: Mike Reed Commit-Queue: Cary Clark --- include/core/SkPostConfig.h | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/include/core/SkPostConfig.h b/include/core/SkPostConfig.h index 0bf33d478a..9628775f35 100644 --- a/include/core/SkPostConfig.h +++ b/include/core/SkPostConfig.h @@ -131,11 +131,20 @@ # define SK_DUMP_GOOGLE3_STACK() #endif +#ifdef SK_BUILD_FOR_WIN +// permits visual studio to follow error back to source +#define SK_DUMP_LINE_FORMAT(message) \ + SkDebugf("%s(%d): fatal error: \"%s\"\n", __FILE__, __LINE__, message) +#else +#define SK_DUMP_LINE_FORMAT(message) \ + SkDebugf("%s:%d: fatal error: \"%s\"\n", __FILE__, __LINE__, message) +#endif + #ifndef SK_ABORT # define SK_ABORT(message) \ do { \ SkNO_RETURN_HINT(); \ - SkDebugf("%s:%d: fatal error: \"%s\"\n", __FILE__, __LINE__, message); \ + SK_DUMP_LINE_FORMAT(message); \ SK_DUMP_GOOGLE3_STACK(); \ sk_abort_no_print(); \ } while (false) -- cgit v1.2.3