From 8e073ba2d63f4d2aab7532f1421df00bb1f88003 Mon Sep 17 00:00:00 2001 From: "scroggo@google.com" Date: Fri, 31 Aug 2012 16:25:46 +0000 Subject: Rename my DeferredPipeController to not conflict with the other. Fixes build. Review URL: https://codereview.appspot.com/6506055 git-svn-id: http://skia.googlecode.com/svn/trunk@5372 2bbb7eff-a529-9590-31e7-b0007b416f81 --- src/pipe/utils/SamplePipeControllers.cpp | 8 ++++---- src/pipe/utils/SamplePipeControllers.h | 6 +++--- tools/PictureRenderer.cpp | 8 ++++---- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/pipe/utils/SamplePipeControllers.cpp b/src/pipe/utils/SamplePipeControllers.cpp index c54bd1334a..437a372c18 100644 --- a/src/pipe/utils/SamplePipeControllers.cpp +++ b/src/pipe/utils/SamplePipeControllers.cpp @@ -79,14 +79,14 @@ void TiledPipeController::notifyWritten(size_t bytes) { //////////////////////////////////////////////////////////////////////////////// -DeferredPipeController::DeferredPipeController(int numberOfReaders) +ThreadSafePipeController::ThreadSafePipeController(int numberOfReaders) : fAllocator(kMinBlockSize) , fNumberOfReaders(numberOfReaders) { fBlock = NULL; fBytesWritten = 0; } -void* DeferredPipeController::requestBlock(size_t minRequest, size_t *actual) { +void* ThreadSafePipeController::requestBlock(size_t minRequest, size_t *actual) { if (fBlock) { // Save the previous block for later PipeBlock previousBloc(fBlock, fBytesWritten); @@ -99,11 +99,11 @@ void* DeferredPipeController::requestBlock(size_t minRequest, size_t *actual) { return fBlock; } -void DeferredPipeController::notifyWritten(size_t bytes) { +void ThreadSafePipeController::notifyWritten(size_t bytes) { fBytesWritten += bytes; } -void DeferredPipeController::playback(SkCanvas* target) { +void ThreadSafePipeController::playback(SkCanvas* target) { SkGPipeReader reader(target); for (int currentBlock = 0; currentBlock < fBlockList.count(); currentBlock++ ) { reader.playback(fBlockList[currentBlock].fBlock, fBlockList[currentBlock].fBytes); diff --git a/src/pipe/utils/SamplePipeControllers.h b/src/pipe/utils/SamplePipeControllers.h index bbd802422c..81b9120eaa 100644 --- a/src/pipe/utils/SamplePipeControllers.h +++ b/src/pipe/utils/SamplePipeControllers.h @@ -50,11 +50,11 @@ private: /** * Borrowed (and modified) from SkDeferredCanvas.cpp::DeferredPipeController. - * Allows playing back from multiple threads. + * Allows playing back from multiple threads, but does not do the threading itself. */ -class DeferredPipeController : public SkGPipeController { +class ThreadSafePipeController : public SkGPipeController { public: - DeferredPipeController(int numberOfReaders); + ThreadSafePipeController(int numberOfReaders); virtual void* requestBlock(size_t minRequest, size_t* actual) SK_OVERRIDE; virtual void notifyWritten(size_t bytes) SK_OVERRIDE; virtual int numberOfReaders() const SK_OVERRIDE { return fNumberOfReaders; } diff --git a/tools/PictureRenderer.cpp b/tools/PictureRenderer.cpp index d5b72ab7ce..3429285cfd 100644 --- a/tools/PictureRenderer.cpp +++ b/tools/PictureRenderer.cpp @@ -283,9 +283,9 @@ void TiledPictureRenderer::deleteTiles() { // Draw using Pipe struct TileData { - TileData(SkCanvas* canvas, DeferredPipeController* controller); + TileData(SkCanvas* canvas, ThreadSafePipeController* controller); SkCanvas* fCanvas; - DeferredPipeController* fController; + ThreadSafePipeController* fController; SkThread fThread; }; @@ -295,7 +295,7 @@ static void DrawTile(void* data) { tileData->fController->playback(tileData->fCanvas); } -TileData::TileData(SkCanvas* canvas, DeferredPipeController* controller) +TileData::TileData(SkCanvas* canvas, ThreadSafePipeController* controller) : fCanvas(canvas) , fController(controller) , fThread(&DrawTile, static_cast(this)) {} @@ -328,7 +328,7 @@ void TiledPictureRenderer::drawTiles() { if (fUsePipe) { // First, draw into a pipe controller SkGPipeWriter writer; - DeferredPipeController controller(fTiles.count()); + ThreadSafePipeController controller(fTiles.count()); SkCanvas* pipeCanvas = writer.startRecording(&controller, SkGPipeWriter::kSimultaneousReaders_Flag); pipeCanvas->drawPicture(*(fPicture)); -- cgit v1.2.3