aboutsummaryrefslogtreecommitdiffhomepage
path: root/whitespace.txt
Commit message (Collapse)AuthorAge
* Whitespace change to see how the Android bots behaveGravatar borenet2014-10-30
| | | | | | | | | NOTRY=true TBR=rmistry NOTREECHECKS=true BUG=skia: Review URL: https://codereview.chromium.org/693483003
* Whitespace change to trigger Android buildsGravatar borenet2014-10-29
| | | | | | | BUG=skia: NOTREECHECKS=true Review URL: https://codereview.chromium.org/688033002
* Whitespace change to trigger buildsGravatar Ravi Mistry2014-10-27
|
* Whitespace change to verify lab machines can now syncGravatar rmistry2014-10-16
| | | | | | | | | TBR= BUG=skia:3031 NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/664533002
* Whitespace change to confirm Google Storage uploads are workingGravatar rmistry2014-10-15
| | | | | | | | | BUG=skia: TBR= NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/657083004
* Whitespace change to trigger buildsGravatar borenet2014-10-13
| | | | | | | | BUG=skia:761 TBR=rmistry NOTREECHECKS=true Review URL: https://codereview.chromium.org/621353002
* Whitespace change to test the CQ's new trybotsGravatar rmistry2014-10-13
| | | | | | | | BUG=skia:2973 TBR= NOTREECHECKS=true Review URL: https://codereview.chromium.org/654463003
* Whitespace change to test CQ's trybotsGravatar rmistry2014-10-09
| | | | | | | | (SkipBuildbotRuns) TBR= BUG=skia: Review URL: https://codereview.chromium.org/646663002
* Whitespace change to test CQGravatar rmistry2014-10-07
| | | | | | | NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/630093003
* Whitespace change to test Skia's CQGravatar rmistry2014-10-01
| | | | | | | | | (SkipBuildbotRuns) TBR= BUG=skia:2973 Review URL: https://codereview.chromium.org/620783003
* Whitespace change to test the new CQ trybotGravatar rmistry2014-10-01
| | | | | | | | | (SkipBuildbotRuns) TBR= BUG=skia:2973 Review URL: https://codereview.chromium.org/615423003
* whitespace changeGravatar Mike Klein2014-09-02
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/529973002
* Force a build.Gravatar Mike Klein2014-08-31
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/530553002
* Revert of Revert of Revert of Revert of Revert of Revert of Revert of moar ↵Gravatar mtklein2014-08-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ws (patchset #1 id:1 of https://codereview.chromium.org/524133002/) Reason for revert: another build Original issue's description: > Revert of Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519413002/) > > Reason for revert: > dun dun dun dun dah dah-dah-dah DAH dah dah-dah-dah DAH dah dah-dah-dah-dah > > Original issue's description: > > Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/523413002/) > > > > Reason for revert: > > ws > > > > Original issue's description: > > > Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/) > > > > > > Reason for revert: > > > ws > > > > > > Original issue's description: > > > > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/) > > > > > > > > Reason for revert: > > > > spring break forever > > > > > > > > Original issue's description: > > > > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/) > > > > > > > > > > Reason for revert: > > > > > nah > > > > > > > > > > Original issue's description: > > > > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/) > > > > > > > > > > > > Reason for revert: > > > > > > i like the old file better > > > > > > > > > > > > Original issue's description: > > > > > > > moar ws > > > > > > > > > > > > > > BUG=skia: > > > > > > > > > > > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9 > > > > > > > > > > > > TBR=mtklein@chromium.org > > > > > > NOTREECHECKS=true > > > > > > NOTRY=true > > > > > > BUG=skia: > > > > > > > > > > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2 > > > > > > > > > > TBR=mtklein@chromium.org > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=skia: > > > > > > > > > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56 > > > > > > > > TBR=mtklein@chromium.org > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=skia: > > > > > > > > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde > > > > > > TBR=mtklein@chromium.org > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=skia: > > > > > > Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4 > > > > TBR=mtklein@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/968212f837f1fbac011f4feb1e33ff27f5acc863 > > TBR=mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7843a24ab2c2dc4fe77e82b9689cde953d6abd7c R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/525153003
* Revert of Revert of Revert of Revert of Revert of Revert of moar ws ↵Gravatar mtklein2014-08-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/519413002/) Reason for revert: dun dun dun dun dah dah-dah-dah DAH dah dah-dah-dah DAH dah dah-dah-dah-dah Original issue's description: > Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/523413002/) > > Reason for revert: > ws > > Original issue's description: > > Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/) > > > > Reason for revert: > > ws > > > > Original issue's description: > > > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/) > > > > > > Reason for revert: > > > spring break forever > > > > > > Original issue's description: > > > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/) > > > > > > > > Reason for revert: > > > > nah > > > > > > > > Original issue's description: > > > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/) > > > > > > > > > > Reason for revert: > > > > > i like the old file better > > > > > > > > > > Original issue's description: > > > > > > moar ws > > > > > > > > > > > > BUG=skia: > > > > > > > > > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9 > > > > > > > > > > TBR=mtklein@chromium.org > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=skia: > > > > > > > > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2 > > > > > > > > TBR=mtklein@chromium.org > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=skia: > > > > > > > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56 > > > > > > TBR=mtklein@chromium.org > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=skia: > > > > > > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde > > > > TBR=mtklein@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4 > > TBR=mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/968212f837f1fbac011f4feb1e33ff27f5acc863 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/524133002
* Revert of Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 ↵Gravatar mtklein2014-08-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/523413002/) Reason for revert: ws Original issue's description: > Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/519303002/) > > Reason for revert: > ws > > Original issue's description: > > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/) > > > > Reason for revert: > > spring break forever > > > > Original issue's description: > > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/) > > > > > > Reason for revert: > > > nah > > > > > > Original issue's description: > > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/) > > > > > > > > Reason for revert: > > > > i like the old file better > > > > > > > > Original issue's description: > > > > > moar ws > > > > > > > > > > BUG=skia: > > > > > > > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9 > > > > > > > > TBR=mtklein@chromium.org > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=skia: > > > > > > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2 > > > > > > TBR=mtklein@chromium.org > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=skia: > > > > > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56 > > > > TBR=mtklein@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde > > TBR=mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c7bee661a1e2b2f3b367bdd2b4176d1921aa69d4 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/519413002
* Revert of Revert of Revert of Revert of moar ws (patchset #1 id:1 of ↵Gravatar mtklein2014-08-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/519303002/) Reason for revert: ws Original issue's description: > Revert of Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/520023003/) > > Reason for revert: > spring break forever > > Original issue's description: > > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/) > > > > Reason for revert: > > nah > > > > Original issue's description: > > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/) > > > > > > Reason for revert: > > > i like the old file better > > > > > > Original issue's description: > > > > moar ws > > > > > > > > BUG=skia: > > > > > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9 > > > > > > TBR=mtklein@chromium.org > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=skia: > > > > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2 > > > > TBR=mtklein@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56 > > TBR=mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/2fe2ce41e3e5647c7aead4d76d75f5500f573fde R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/523413002
* Revert of Revert of Revert of moar ws (patchset #1 id:1 of ↵Gravatar mtklein2014-08-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/520023003/) Reason for revert: spring break forever Original issue's description: > Revert of Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518333002/) > > Reason for revert: > nah > > Original issue's description: > > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/) > > > > Reason for revert: > > i like the old file better > > > > Original issue's description: > > > moar ws > > > > > > BUG=skia: > > > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9 > > > > TBR=mtklein@chromium.org > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2 > > TBR=mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/5355536c790831f05cdd37a0ac84206ad1c3dc56 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/519303002
* Revert of Revert of moar ws (patchset #1 id:1 of ↵Gravatar mtklein2014-08-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/518333002/) Reason for revert: nah Original issue's description: > Revert of moar ws (patchset #1 id:1 of https://codereview.chromium.org/518233004/) > > Reason for revert: > i like the old file better > > Original issue's description: > > moar ws > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/7a353e9 > > TBR=mtklein@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4ee3e529e2756275a978ae5e4763955a703191f2 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/520023003
* Revert of moar ws (patchset #1 id:1 of ↵Gravatar mtklein2014-08-29
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/518233004/) Reason for revert: i like the old file better Original issue's description: > moar ws > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7a353e9 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/518333002
* moar wsGravatar Mike Klein2014-08-29
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/518233004
* another wsGravatar Mike Klein2014-08-29
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/519583008
* ws2Gravatar Mike Klein2014-08-29
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/524853004
* wsGravatar Mike Klein2014-08-29
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/523133002
* Whitespace change to test the CQ commit messageGravatar rmistry2014-08-13
| | | | | | | | | | | (SkipBuildbotRuns) TBR= BUG=chromium:308792 NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/470603002
* whitespaceGravatar borenet2014-08-12
| | | | | | | | | BUG=skia: TBR=bungeman Author: borenet@google.com Review URL: https://codereview.chromium.org/461123002
* Whitespace change to test the CQGravatar rmistry2014-08-08
| | | | | | | | | | BUG=skia: (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/454873002
* Test new CQ botGravatar rmistry2014-08-05
| | | | | | | | | | | | TBR= (SkipBuildbotRuns) BUG=skia: Author: rmistry@google.com Review URL: https://codereview.chromium.org/441833004
* Revert of whitespace change to force a build ↵Gravatar mtklein2014-08-05
| | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/432183002/) Reason for revert: force Original issue's description: > whitespace change to force a build > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/490d49c5dcc4b2242c9b25f082b23ec5e842c4e7 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/442603005
* whitespace change to force a buildGravatar mtklein2014-07-31
| | | | | | | | | BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/432183002
* Whitespace change to test the CQ.Gravatar rmistry2014-07-30
| | | | | | | | | | | (SkipBuildbotRuns) BUG=skia: R=bensong@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/428183007
* force another buildGravatar Mike Klein2014-07-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/397493008
* Force a build for nanobench.Gravatar Mike Klein2014-07-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/391983002
* Another forced run for Android bots.Gravatar Mike Klein2014-07-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/388683005
* force buildGravatar Mike Klein2014-07-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/391103002
* Whitespace change to test failures after ↵Gravatar borenet2014-07-15
| | | | | | | | | | | | https://skia.googlesource.com/buildbot/+/0e977d0753ecc81fd4e45e088ebc5bc16f0b4b75 and https://skia.googlesource.com/buildbot/+/0e6fdada778ad14e38b25f8b5827a8b156674045 BUG=skia: R=mtklein@google.com TBR=mtklein Author: borenet@google.com Review URL: https://codereview.chromium.org/397613003
* Whitespace change to verify buildbot scripts after ↵Gravatar Eric Boren2014-07-10
| | | | | | | | https://skia.googlesource.com/buildbot/+/dd42159 BUG=skia:2682 Review URL: https://codereview.chromium.org/361243003
* Whitespace change to test CQGravatar rmistry2014-06-30
| | | | | | | | | | | | | TBR= CQ_EXCLUDE_TRYBOTS=tryserver.skia:Build-Win7-VS2010-x86-Debug-Trybot,Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot,Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot,Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot,Build-Mac10.8-Clang-x86_64-Release-Trybot (SkipBuildbotRuns) BUG=skia: Author: rmistry@google.com Review URL: https://codereview.chromium.org/358393002
* Whitespace change to test CQGravatar rmistry2014-06-30
| | | | | | | | | | | | | TBR= CQ_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot,Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot (SkipBuildbotRuns) BUG=skia: Author: rmistry@google.com Review URL: https://codereview.chromium.org/357313002
* Testing trybot triggeringGravatar rmistry2014-06-13
| | | | | | | | | | | | CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-x86_64-Debug-CrOS_Link-Trybot BUG=skia:2659 NOTREECHECKS=true TBR= (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/332933005
* Whitespace change to test trybot triggeringGravatar rmistry2014-06-12
| | | | | | | | | | | BUG=skia: CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Ubuntu13.10-GCC4.8-Arm7-Release-Android-Trybot TBR= (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/333663002
* Whitespace change to test trybot triggeringGravatar rmistry2014-06-11
| | | | | | | | | | | BUG=skia: TBR= NOTREECHECKS=true (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/325213002
* whitespace to trigger buildsGravatar mtklein2014-06-07
| | | | | | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/5037fceeab7d29b99a6497bcdf1c97f03e532956 R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/314313004
* whitespace to trigger buildsGravatar mtklein2014-06-07
| | | | | | | | | BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/314313004
* Whitespace change to test new CQ trybotsGravatar rmistry2014-06-06
| | | | | | | | | | | BUG=skia:2203 TBR= (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/319123002
* Whitespace change to test bugdroidGravatar Ravi Mistry2014-06-04
| | | | | | | (SkipBuildbotRuns) BUG=skia:2139 BUG=chromium:380617
* Whitespace change to test bugdroidGravatar Ravi Mistry2014-06-04
| | | | | | (SkipBuildbotRuns) BUG=skia:2139,chromium:380617
* Whitespace change to test the new cron.chrome bugdroid.Gravatar Ravi Mistry2014-06-03
| | | | | | | (SkipBuildbotRuns) BUG=skia:2139 Review URL: https://codereview.chromium.org/309333003
* Whitespace change to test multiple master support in CQGravatar rmistry2014-06-03
| | | | | | | | | | | TBR= BUG=skia:2624 (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/315633002
* Whitespace change to test new CQ trybotGravatar rmistry2014-06-03
| | | | | | | | | | TBR= BUG=skia:2203 (SkipBuildbotRuns) Author: rmistry@google.com Review URL: https://codereview.chromium.org/311813002