aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
* Add more valgrind suppressionsGravatar robertphillips@google.com2013-12-09
| | | | | | | | https://codereview.chromium.org/102443003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12561 2bbb7eff-a529-9590-31e7-b0007b416f81
* Generalize valgrind suppressions & a 2 moreGravatar robertphillips@google.com2013-12-06
| | | | | | | | https://codereview.chromium.org/107443004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12531 2bbb7eff-a529-9590-31e7-b0007b416f81
* Big Cleanup: SkBitmapFactory, SkLazyPixelRef, SkImageCacheGravatar halcanary@google.com2013-12-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed SkBitmapFactory since no clients were using it. New cache selection mechanism can simply pass a SkDiscardableMemory::Factory into the SkDiscardablePixelRef if non-default SkDiscardableMemory should be used. Removed BitmapFactoryTest. SkDiscardableMemory::Factory interface. Android will need this functionality in the future inside their BitmapFactory. Removed SkLazyPixelRef, since it's functionality is now subsumed into SkDiscardablePixelRef. Removed LazyPixelRef test. Modified SkDiscardablePixelRef to optionally allow it to use a SkDiscardableMemory::Factory. This tiny change makes it a replacement for SkLazyPixelRef. This functioanlity is also necessary for moving Android over to SkDiscardablePixelRef from SkImageRef in a later CL. Added a test for this. SkDecodingImageGenerator::Install can optionally pass a factory in to SkDiscardablePixelRef. Removed SkImageCache, SkLruImageCache, and SkPurgeableImageCache. This functionality can be handled much more cleanly by SkDiscardableMemory. New SkDiscardableMemoryPool class to replace SkLruImageCache. In a later CL, we will replace SkImageRef_GlobalPool (used by android) as well. This is a concrete implementation of SkDiscardableMemory::Factory. Added a test for this. modified gm/factory.cpp to remove dependnce on SkBitmapFactory + SkLruImageCache. Now uses SkDecodingImageGenerator + SkDiscardablePixelRef + SkDiscardableMemoryPool. SkImageDecoder::Target replaces SkBitmapFactory::Target. The DecodeMemoryToTarget function may disappear in the future. Moved SkLazyCachingPixelRef::DecodeProc replaces SkBitmapFactory::DecodeProc. This is a short term change, since another CL changes SkLazyCachingPixelRef to use SkImageGenerator instead of DecodeProc. Modified DrawBitmapRectTest to use SkDiscardablePixelRef instead of SkLazyPixelRef. tools/LazyDecodeBitmap.cpp now uses SkDecodingImageGenerator + SkDiscardablePixelRef instead of a SkBitmapFactory. bench_pictures uses the Global SkDiscardableMemoryPool instead of a global gLruImageCache. R=reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/103033002 git-svn-id: http://skia.googlecode.com/svn/trunk@12515 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update valgrind suppressions for new driverGravatar robertphillips@google.com2013-12-05
| | | | | | | | https://codereview.chromium.org/102473003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12510 2bbb7eff-a529-9590-31e7-b0007b416f81
* Force linking for skhello.Gravatar scroggo@google.com2013-12-04
| | | | | | Otherwise encoders are stripped and the program produces nothing. git-svn-id: http://skia.googlecode.com/svn/trunk@12487 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add some debugging to buildbot_globals, sort the trybot listGravatar borenet@google.com2013-12-02
| | | | | | | | R=epoger@google.com, rmistry@google.com Review URL: https://codereview.chromium.org/99223002 git-svn-id: http://skia.googlecode.com/svn/trunk@12437 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/85343004/Gravatar commit-bot@chromium.org2013-11-25
| | | | | | | | | | | | | | Reason for revert: Reverting the temporary CL TBR= NOTREECHECKS=true NOTRY=true Author: rmistry@google.com Review URL: https://codereview.chromium.org/85823002 git-svn-id: http://skia.googlecode.com/svn/trunk@12376 2bbb7eff-a529-9590-31e7-b0007b416f81
* Temporary changes to test one-click revert.Gravatar commit-bot@chromium.org2013-11-25
| | | | | | | | | | | | | | (SkipBuildbotRuns) BUG= NOTRY=true TBR=borenet@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/85343004 git-svn-id: http://skia.googlecode.com/svn/trunk@12375 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove mutex around image decoding in skpdiff.Gravatar commit-bot@chromium.org2013-11-21
| | | | | | | | | | | | | | | | I removed the mutex to investigate BUG=skia:1803, and I get no crashes. The crashes may have been related to other multithreading issues. Removing the mutex will allow skpdiff to run faster. R=djsollen@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/61603008 git-svn-id: http://skia.googlecode.com/svn/trunk@12339 2bbb7eff-a529-9590-31e7-b0007b416f81
* rebaseline_server: clean up thread locksGravatar epoger@google.com2013-11-20
| | | | | | | | | | | followup to https://codereview.chromium.org/66803004/ ('rebaseline_server: improve thread locks to allow read access during updates') (SkipBuildbotRuns) R=jcgregorio@google.com Review URL: https://codereview.chromium.org/64273011 git-svn-id: http://skia.googlecode.com/svn/trunk@12323 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unused kMaxPOI.Gravatar commit-bot@chromium.org2013-11-18
| | | | | | | | | | | BUG= R=djsollen@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/62333026 git-svn-id: http://skia.googlecode.com/svn/trunk@12307 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove unnecessary includes.Gravatar commit-bot@chromium.org2013-11-18
| | | | | | | | | | R=djsollen@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/68893028 git-svn-id: http://skia.googlecode.com/svn/trunk@12304 2bbb7eff-a529-9590-31e7-b0007b416f81
* increase coverage of SkPath.cpp, remove unused codeGravatar commit-bot@chromium.org2013-11-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using Mike Klein's excellent coverage tool, increase the unit testing of SkPath.cpp from 70% to 95%. Along the way, determined that these functions were not maintained or used: SkPath::pathTo SkPath::contains as well as a large block of SkPath::cheapGetDirection(). Changed SkPath::validate() to permit infinities in the path data points. Fixed errors in preserving direction. Fixed error setting direction when convexity is unknown. Added missing conic to moveTo only detector. BUG= R=bsalomon@google.com, reed@google.com Author: caryclark@google.com Review URL: https://codereview.chromium.org/65493004 git-svn-id: http://skia.googlecode.com/svn/trunk@12291 2bbb7eff-a529-9590-31e7-b0007b416f81
* Address some more valgrind issuesGravatar robertphillips@google.com2013-11-14
| | | | | | | | R=borenet@google.com Review URL: https://codereview.chromium.org/59713010 git-svn-id: http://skia.googlecode.com/svn/trunk@12286 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix multithread related crashes in skpdiffGravatar djsollen@google.com2013-11-12
| | | | | | | | | BUG=skia:1798 R=mtklein@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/60833002 git-svn-id: http://skia.googlecode.com/svn/trunk@12252 2bbb7eff-a529-9590-31e7-b0007b416f81
* Changes to make SkPDiff more robost.Gravatar scroggo@google.com2013-11-12
| | | | | | | | | | | | | | | | | | | bitmap_to_cielab now returns a boolean. Instead of asserting that the config is 8888, copy to 8888 (and return false on failure). This allows skpdiff to work on Index8 bitmaps (without changing the code that does the real work). If it returns false, do not attempt to create a pmetric. In pmetric, exit early if maxLevels is <= 2, since this would crash later in the function (creation of an ImageL3D if maxLevels is 0, and then the creation of an array of a negative number of entries). maxLevels is small if the width or height of the image is small (i.e. a bitmap with width 1 has maxLevels of 0). R=djsollen@google.com Review URL: https://codereview.chromium.org/65253002 git-svn-id: http://skia.googlecode.com/svn/trunk@12239 2bbb7eff-a529-9590-31e7-b0007b416f81
* Silence another valgrind leakGravatar robertphillips@google.com2013-11-12
| | | | | | | | https://codereview.chromium.org/68523006/ git-svn-id: http://skia.googlecode.com/svn/trunk@12236 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add another FontConfig suppression to valgrind suppressionsGravatar robertphillips@google.com2013-11-11
| | | | | | | | https://codereview.chromium.org/69403002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12226 2bbb7eff-a529-9590-31e7-b0007b416f81
* Specify --patchlevel 0 to trychange.pyGravatar borenet@google.com2013-11-11
| | | | | | | | | | | | | For some reason, trychange.py creates patches with level 0, even from a git repo. We were assuming that the patch level was 1 from a git repo, so patches were failing to apply. BUG=skia:1669 R=rmistry@google.com Review URL: https://codereview.chromium.org/61733011 git-svn-id: http://skia.googlecode.com/svn/trunk@12212 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix broken build on mac due to compiler warningGravatar djsollen@google.com2013-11-07
| | | | | | | | R=epoger@google.com Review URL: https://codereview.chromium.org/64423004 git-svn-id: http://skia.googlecode.com/svn/trunk@12175 2bbb7eff-a529-9590-31e7-b0007b416f81
* update skpdiff visualization (image magnification with alpha mask)Gravatar djsollen@google.com2013-11-07
| | | | | | | | R=epoger@google.com Review URL: https://codereview.chromium.org/29103005 git-svn-id: http://skia.googlecode.com/svn/trunk@12174 2bbb7eff-a529-9590-31e7-b0007b416f81
* move SkImage::ColorType into SkColorTypeGravatar reed@google.com2013-11-01
| | | | | | | | | | | | | | | | | | objective -- move clients over to SkImage tasks - use SkImageInfo instead of SkBitmap::Config - add support for colortables to SkImage - add drawImage to SkCanvas - return SkImage from readPixels This CL works towards the first task R=robertphillips@google.com Review URL: https://codereview.chromium.org/54363008 git-svn-id: http://skia.googlecode.com/svn/trunk@12077 2bbb7eff-a529-9590-31e7-b0007b416f81
* svndiff for the windowsGravatar bsalomon@google.com2013-10-29
| | | | | | | | R=epoger@google.com Review URL: https://codereview.chromium.org/49323006 git-svn-id: http://skia.googlecode.com/svn/trunk@11995 2bbb7eff-a529-9590-31e7-b0007b416f81
* Changes bench_graph_svg.py test to check_bench_regressions.py test; deletes ↵Gravatar bensong@google.com2013-10-24
| | | | | | | | deprecated chunks in syn_bucket_subdir. Review URL: https://codereview.chromium.org/27377002 git-svn-id: http://skia.googlecode.com/svn/trunk@11952 2bbb7eff-a529-9590-31e7-b0007b416f81
* More work to integrate skimage with rebaseline tools.Gravatar scroggo@google.com2013-10-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tools/skimage_main.cpp: Add the ability to write the results to checksum based filenames, much like GM uses. This will allow using the skpdiff server to rebaseline images. Write the keys in the JSON file as <original image>_<pref config>.png, so it matches gm_json.IMAGE_FILENAME_PATTERN. Also replace '_' with '-' in the original file name, to avoid confusing the pattern matcher. The '_' to '-' replacement also happens on the output filename. Read the keys in a similar manner. In make_outname, no longer remove a suffix. This fixes a bug where subset decoding writes multiple subsets to the same file. tools/rebaseline.py: Since the filenames written to json files now match gm_json.IMAGE_FILENAME_PATTERN, enable the option to match based on configs/tests when rebaselining skimage. test json files: Update to match the new format of output. gm/gm_expectations: Add a constructor that takes a BitmapAndDigest as input. tools/tests/skimage_self_test.py: Test that reading the expectations file just created by skimage with the same file actually compares to the original file (rather than just succeeding because expectations were missing). Change the expectations files to match the new format. Will require a buildbot change to use the new flag: https://codereview.chromium.org/27389002/ BUG=1466 R=epoger@google.com Review URL: https://codereview.chromium.org/26297004 git-svn-id: http://skia.googlecode.com/svn/trunk@11902 2bbb7eff-a529-9590-31e7-b0007b416f81
* add initial support ofr multi-threaded executionGravatar djsollen@google.com2013-10-16
| | | | | | Review URL: https://codereview.chromium.org/27541003 git-svn-id: http://skia.googlecode.com/svn/trunk@11823 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add --add-ignored option to rebaseline.pyGravatar bsalomon@google.com2013-10-16
| | | | | | | | | R=senorblanco@chromium.org, epoger@google.com BUG=skia:1600 Review URL: https://codereview.chromium.org/27517002 git-svn-id: http://skia.googlecode.com/svn/trunk@11809 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update skpdiff to include a name with each file.Gravatar djsollen@google.com2013-10-16
| | | | | | | | R=caryclark@google.com Review URL: https://codereview.chromium.org/27512002 git-svn-id: http://skia.googlecode.com/svn/trunk@11808 2bbb7eff-a529-9590-31e7-b0007b416f81
* Truly ignore failures in skimage.Gravatar scroggo@google.com2013-10-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the expectation is set to ignore failures, do not return a negative 1 (indicating a failure) when a successful decode does not match the expectation. If the file could not be decoded at all, report this to the user depending on the input expectations file: No expectations: Report failure. The user wanted to know if the file could be decoded. Expectations expected a valid result: Report failure. The decode should have matched the result. Empty expectations: Print a message that the expectation was missing, but still return success from skimage, since this is a newly added file (i.e. it has no expectation yet). Ignore failure: Return success from skimage, since it is a known failure. Update the self tests to ensure these behaviors. R=epoger@google.com Review URL: https://codereview.chromium.org/22293006 git-svn-id: http://skia.googlecode.com/svn/trunk@11790 2bbb7eff-a529-9590-31e7-b0007b416f81
* Second wave of Win64 warning cleanupGravatar robertphillips@google.com2013-10-15
| | | | | | | | https://codereview.chromium.org/27343002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11778 2bbb7eff-a529-9590-31e7-b0007b416f81
* Suppresses failing test due to change of bench_graph_svg. Will fix later.Gravatar bensong@google.com2013-10-15
| | | | | | Review URL: https://codereview.chromium.org/26894004 git-svn-id: http://skia.googlecode.com/svn/trunk@11766 2bbb7eff-a529-9590-31e7-b0007b416f81
* Start cleaning up 64bit Win warningsGravatar robertphillips@google.com2013-10-14
| | | | | | | | https://codereview.chromium.org/27192003/ git-svn-id: http://skia.googlecode.com/svn/trunk@11764 2bbb7eff-a529-9590-31e7-b0007b416f81
* Runtime configuration setting for suppressing JPEG decoder errors.Gravatar halcanary@google.com2013-10-14
| | | | | | | | | | | | | | | | | | Add new runtime config variable, images.jpeg.suppressDecoderErrors which defaults to false in Debug and true otherwise. When Jpeg errors are suppressed and an error happens, SkJPEGImageDecoder::onDecode() will return silently false (Consequently, so will SkImageDecoder's DecodeFile() and DecodeMemory() functions). Also, the test_image_decoder program now respects runtime configuration settings. BUG=skia:1680 R=scroggo@google.com Review URL: https://codereview.chromium.org/27230002 git-svn-id: http://skia.googlecode.com/svn/trunk@11763 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add SkPDFDeviceFlatenner which extends SkPDFDevice to add support to flatten ↵Gravatar commit-bot@chromium.org2013-10-14
| | | | | | | | | | | | | | | the path and the text when we have perspective. prepare to deprecate SkPDFDevice constructor, and route gm and render_pdfs to use SkDocument::Create pdf interface instead. - controlled by a flag add comments where we are supposed to flatten other features (paint, shaders, ... ) R=reed@google.com, bungeman@google.com, scroggo@google.com, vandebo@chromium.org, bsalomon@google.com Author: edisonn@google.com Review URL: https://codereview.chromium.org/24811002 git-svn-id: http://skia.googlecode.com/svn/trunk@11751 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add stdio include to skdiff_image.Gravatar bungeman@google.com2013-10-11
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@11740 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add valgrind suppressions for driver bugsGravatar robertphillips@google.com2013-10-11
| | | | | | | | https://codereview.chromium.org/27019005/ git-svn-id: http://skia.googlecode.com/svn/trunk@11736 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add ability to rebaseline skimage to rebaseline.pyGravatar scroggo@google.com2013-10-10
| | | | | | | | | | | | | | | | | | | | Skip pattern matching for skimage, since the skimage results do not match the pattern. Automatically fill in expectations_root and actuals_base_url when --skimage is specified. Requires a change to move the expectations files to the right place. Depends on https://codereview.chromium.org/26734006 (SkipBuildBotRuns) BUG=skia:1466 R=epoger@google.com Review URL: https://codereview.chromium.org/26666004 git-svn-id: http://skia.googlecode.com/svn/trunk@11717 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add leak to valgrind.suppGravatar robertphillips@google.com2013-10-10
| | | | | | | | https://codereview.chromium.org/26869002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11700 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use the modified path, not the original path for the platform prefix.Gravatar bungeman@google.com2013-10-10
| | | | | | | Fixes regression introduced in r11642. git-svn-id: http://skia.googlecode.com/svn/trunk@11693 2bbb7eff-a529-9590-31e7-b0007b416f81
* Allow sampling GIF images during decode.Gravatar commit-bot@chromium.org2013-10-08
| | | | | | | | | | | | | | | | | | | | | | SkScaledBitmapSampler: Add a mode for sampling rows out of order, used by GIF decoder for interlaced images. Add a getter for the X sampling rate. SkImageDecoder_libgif: Respect the sampleSize set on SkImageDecoder. skimage_main: Provide an option to set a sample size. BUG=https://b.corp.google.com/issue?id=8999690 R=reed@google.com, djsollen@google.com, halcanary@google.com Author: scroggo@google.com Review URL: https://codereview.chromium.org/25354004 git-svn-id: http://skia.googlecode.com/svn/trunk@11659 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update valgrind suppressionsGravatar robertphillips@google.com2013-10-08
| | | | | | | | https://codereview.chromium.org/26465007/ git-svn-id: http://skia.googlecode.com/svn/trunk@11650 2bbb7eff-a529-9590-31e7-b0007b416f81
* skia/trunk changes for generic sanitizer gyp flag.Gravatar mtklein@google.com2013-10-08
| | | | | | | | | BUG= R=borenet@google.com Review URL: https://codereview.chromium.org/25564003 git-svn-id: http://skia.googlecode.com/svn/trunk@11648 2bbb7eff-a529-9590-31e7-b0007b416f81
* Document how to get a specific revision when rebaselining.Gravatar bungeman@google.com2013-10-07
| | | | | | | | | | This is helpful when using the trybots. R=epoger@google.com Review URL: https://codereview.chromium.org/25653008 git-svn-id: http://skia.googlecode.com/svn/trunk@11643 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make svndiff.py work on Windows and with svn 1.7.Gravatar bungeman@google.com2013-10-07
| | | | | | | | R=epoger@google.com Review URL: https://codereview.chromium.org/25447003 git-svn-id: http://skia.googlecode.com/svn/trunk@11642 2bbb7eff-a529-9590-31e7-b0007b416f81
* In skimage, copy to 8888 if encoding fails.Gravatar scroggo@google.com2013-10-07
| | | | | | | | | | | | When writing the bitmap for visual comparison, rather than special casing A8, depend on the fact that the encoder will fail, and try copying to 8888 and encoding that if so. R=reed@google.com Review URL: https://codereview.chromium.org/25964003 git-svn-id: http://skia.googlecode.com/svn/trunk@11633 2bbb7eff-a529-9590-31e7-b0007b416f81
* revert unintentional checkin of svndiff.pyGravatar djsollen@google.com2013-10-07
| | | | | | Review URL: https://codereview.chromium.org/26162004 git-svn-id: http://skia.googlecode.com/svn/trunk@11628 2bbb7eff-a529-9590-31e7-b0007b416f81
* Rebaseline Android Xoom and Nexus10Gravatar djsollen@google.com2013-10-07
| | | | | | Review URL: https://codereview.chromium.org/26257002 git-svn-id: http://skia.googlecode.com/svn/trunk@11627 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix iOS build of test_image_decoderGravatar halcanary@google.com2013-10-04
| | | | | | | | Use tool_main() function. Review URL: https://codereview.chromium.org/26008002 git-svn-id: http://skia.googlecode.com/svn/trunk@11600 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make image decoding more fault resistant, less verbose.Gravatar halcanary@google.com2013-10-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change address what happens when a jpeg is partially downloaded before failing. Many browsers will render it anyway: we want Skia to do the same. The JpegTest takes a perfectly cromulent jpeg file and only passes into the ImageDecoder the first half of the image. We then verify that the image decoder returns a valid bitmap of the correct dimensions. We also fixed some png library errors, including issue 1691. Also, suppressed the majority of warnings from using libpng and libjpeg. By default, most warnings are *not* suppressed in debug mode. If you have a debug binary and wish to suppress warnings, set the following environment variables to true skia_images_png_suppressDecoderWarnings skia_images_jpeg_suppressDecoderWarnings or from within a program that links to Skia: #if defined(SK_DEBUG) #include "SkRTConf.h" SK_CONF_SET("images.jpeg.suppressDecoderWarnings", true); SK_CONF_SET("images.png.suppressDecoderWarnings", true); #endif I tested this, before (control) and after these changes (test), on 364,295 skps from the cluster telemetry. - number of errors+warnings in control = 2804 - number of errors+warnings fixed = 2283 - number of PNG verbosity fixed = 2152 - number of PNG error fixed = 4 - number of PNG segfault fixed = 3 - number of PNG errors changed to warnings = 62 - number of JPG verbosity fixed = 26 - number of JPG error fixed = 91 Not all errors and warning have been fixed. These numbers were generated using the find_bad_images_in_skps.py program. This program may be useful going forward for testing image-decoding libraries on skp files from the cluster telemetry. find_bad_images_in_skps.py depends on the test_image_decoder program, which simply executes the SkImageDecoder::DecodeFile function and uses its exit status to report success or failure. BUG=skia:1649 BUG=skia:1691 BUG=skia:1680 R=scroggo@google.com Review URL: https://codereview.chromium.org/24449003 git-svn-id: http://skia.googlecode.com/svn/trunk@11597 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use SkPicture::ExtractBitmap callback in pdf too, there is no need for a ↵Gravatar commit-bot@chromium.org2013-10-03
| | | | | | | | | | | | specialized function pointer for pdf only only to pass a rectangle, when we can use subseted bitmaps. R=scroggo@google.com, reed@google.com, vandebo@chromium.org, bsalomon@google.com Author: edisonn@google.com Review URL: https://codereview.chromium.org/25054002 git-svn-id: http://skia.googlecode.com/svn/trunk@11591 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-22 17:14:31 +0000