aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
* remove tools/test_rendering.py and tools/test_pictures.pyGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | BUG=skia:2035 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/153083003 git-svn-id: http://skia.googlecode.com/svn/trunk@13289 2bbb7eff-a529-9590-31e7-b0007b416f81
* Initial QuadTree implementationGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | | | | | | | In an effort to find a faster bounding box hierarchy than the R-Tree, a QuadTree has been implemented here. For now, the QuadTree construction is generally faster than the R-Tree and the queries are a bit slower, so overall, SKP local tests showed QuadTree performance similar to the R-Tree performance. Tests and bench are included in this cl. At this point, I'd like to be able to commit this in order to more easily use the bots to test multiple configurations and a larger number of SKPs. The R-Tree BBH is still used by default so this change shouldn't affect chromium. BUG=skia: R=junov@chromium.org, junov@google.com, senorblanco@google.com, senorblanco@chromium.org, reed@google.com, sugoi@google.com, fmalita@google.com Author: sugoi@chromium.org Review URL: https://codereview.chromium.org/131343011 git-svn-id: http://skia.googlecode.com/svn/trunk@13282 2bbb7eff-a529-9590-31e7-b0007b416f81
* add_codereview_message script to append messages to a CLGravatar commit-bot@chromium.org2014-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add add_codereview_message.py script. This script takes a message and a codereview URL as arguments calls `git cl upload` to append the message to the given codereview issue. Motivation: We are automating a process of testing Chromium/Skia DEPS rolls where roll_deps.py is automatically run every night, and then at a later time, compare_codereview.py is run to generate a report of the trybot results. This script can be used to append that report to the DEPS roll Cl. This CL also refactors functioanlity common to roll_deps and add_codereview_message: * Add tools/git_utils.py module. - ChangeGitBranch class was factored out of roll_deps.GitBranchCLUpload. The other half of that class became roll_deps.git_cl_uploader function. I make use of this new class in both roll_deps and upload_deps_roll. - test_git_executable moved to this new module. * Add tools/misc_utils.py - move VerboseSubprocess, ChangeDir, and ReSearch classes from roll_deps module. * Remove generic functions from roll_deps. * Add git_cl_uploader function to roll_deps. Refactor roll_deps.roll_deps function to make use of it BUG=skia: R=borenet@google.com, robertphillips@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/141483011 git-svn-id: http://skia.googlecode.com/svn/trunk@13251 2bbb7eff-a529-9590-31e7-b0007b416f81
* Suppress new valgrind complaintGravatar robertphillips@google.com2014-01-30
| | | | | | | | https://codereview.chromium.org/144853006/ git-svn-id: http://skia.googlecode.com/svn/trunk@13244 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove nvpr bench_pictures_cfgGravatar commit-bot@chromium.org2014-01-28
| | | | | | | | | | | BUG=skia:2042 R=bsalomon@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/148393002 git-svn-id: http://skia.googlecode.com/svn/trunk@13215 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add the NOTRY command on roll_deps.pyGravatar commit-bot@chromium.org2014-01-27
| | | | | | | | | | | | | | | Motivation: The current workflow is to submit via `git cl dcommit`. As we move to automated nightly creation of the DEPS roll CLs, we want to make it easier for the submitter to speed along a clean roll. BUG=skia: R=borenet@google.com, robertphillips@google.com, rmistry@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/133933009 git-svn-id: http://skia.googlecode.com/svn/trunk@13211 2bbb7eff-a529-9590-31e7-b0007b416f81
* roll_deps.py: Make default_bots_list a module-level variableGravatar borenet@google.com2014-01-27
| | | | | | | | | | | This allows us to import the script rather than run it in a sub-shell. BUG=skia: R=halcanary@google.com Review URL: https://codereview.chromium.org/140973003 git-svn-id: http://skia.googlecode.com/svn/trunk@13200 2bbb7eff-a529-9590-31e7-b0007b416f81
* Explain empty report in compare_codereview.py.Gravatar commit-bot@chromium.org2014-01-27
| | | | | | | | | | | | | | Let user know when control and roll have no common trybots, instead of being silent. BUG=skia: R=borenet@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/135683003 git-svn-id: http://skia.googlecode.com/svn/trunk@13194 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add a suppressions file for leak sanitizer.Gravatar commit-bot@chromium.org2014-01-23
| | | | | | | | | | | | | | | | | | | LeakSanitizer is built into AddressSanitizer, and runs with no extra speed penalty. Most interestingly, it's got a lock-free allocator, so it doesn't bottleneck threaded code. This file is enough to supress all leak warnings except from the Nvidia driver on my desktop for tests and dm. Looks like lsan doesn't or can't pay attention to leaked globals (-fno-common doesn't affect this). BUG=skia: R=robertphillips@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/145033010 git-svn-id: http://skia.googlecode.com/svn/trunk@13153 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove more unnamed namespace usages.Gravatar tfarina@chromium.org2014-01-23
| | | | | | | | | | | | Skia prefers 'static' over 'unnamed' namespaces. BUG=None TEST=skgpu and tools R=robertphillips@google.com, bsalomon@google.com Review URL: https://codereview.chromium.org/139743010 git-svn-id: http://skia.googlecode.com/svn/trunk@13146 2bbb7eff-a529-9590-31e7-b0007b416f81
* Chromium Codereview Comparison Script.Gravatar commit-bot@chromium.org2014-01-22
| | | | | | | | | | | | | | | | This script takes two Codereview URLs, looks at the trybot results for the two codereviews and compares the results. Motivation: This should speed up the DEPS roll procedure. BUG=skia:2039 R=robertphillips@google.com, borenet@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/143503003 git-svn-id: http://skia.googlecode.com/svn/trunk@13144 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add reviewers to roll_deps.py, remove linux_heapcheck botGravatar commit-bot@chromium.org2014-01-21
| | | | | | | | | | | | | The --reviewers and --cc are disabled for now, while we work on the workflow. BUG=skia: R=robertphillips@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/143903005 git-svn-id: http://skia.googlecode.com/svn/trunk@13137 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make tools/submit_try saferGravatar commit-bot@chromium.org2014-01-16
| | | | | | | | | | | | | | | | | | | Using proc.wait() in combination with PIPE doesn't seem to be safe for large patches according to http://docs.python.org/2/library/subprocess.html. Moving to proc.communicate(). Signed-off-by: Kévin PETIT <kevin.petit@arm.com> BUG=skia: R=djsollen@google.com, borenet@google.com Author: kevin.petit.arm@gmail.com Review URL: https://codereview.chromium.org/141023003 git-svn-id: http://skia.googlecode.com/svn/trunk@13113 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use MACOSX_DEPLOYMENT_TARGET instead of SDKROOT.Gravatar commit-bot@chromium.org2014-01-15
| | | | | | | | | | | | | | | | MACOSX_DEPLOYMENT_TARGET is the minimum unconditionally supported OS, which should just be 10.6 for us until Chrome changes. SDKROOT is the maximum conditionally supported OS, which defaults sanely to whatever's the latest SDK the machine has, so we don't need to mention it. BUG=skia: R=bungeman@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/137793010 git-svn-id: http://skia.googlecode.com/svn/trunk@13102 2bbb7eff-a529-9590-31e7-b0007b416f81
* render_pictures: adjust unittests to show specific failuresGravatar commit-bot@chromium.org2014-01-15
| | | | | | | | | | | BUG=skia:2043,skia:2044 R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/139383004 git-svn-id: http://skia.googlecode.com/svn/trunk@13100 2bbb7eff-a529-9590-31e7-b0007b416f81
* [try 2] skpmaker: make the SKP more graphically interesting (add a border)Gravatar commit-bot@chromium.org2014-01-15
| | | | | | | | | | | | | | | relanding https://codereview.chromium.org/137993008/ BUG=skia:1942 NOTRY=True R=rmistry@google.com TBR=rmistry Author: epoger@google.com Review URL: https://codereview.chromium.org/139583002 git-svn-id: http://skia.googlecode.com/svn/trunk@13088 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of skpmaker: make the SKP slightly more interesting (add a border) ↵Gravatar commit-bot@chromium.org2014-01-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/137993008/) Reason for revert: broke http://108.170.217.252:10117/builders/Build-Mac10.6-GCC-x86-Debug/builds/2837 Original issue's description: > skpmaker: make the SKP slightly more interesting (add a border) > > This will help with render_pictures self-testing > BUG=skia:1942 > > Committed: http://code.google.com/p/skia/source/detail?r=13086 R=rmistry@google.com TBR=rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:1942 Author: epoger@google.com Review URL: https://codereview.chromium.org/139553002 git-svn-id: http://skia.googlecode.com/svn/trunk@13087 2bbb7eff-a529-9590-31e7-b0007b416f81
* skpmaker: make the SKP slightly more interesting (add a border)Gravatar commit-bot@chromium.org2014-01-15
| | | | | | | | | | | | This will help with render_pictures self-testing BUG=skia:1942 R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/137993008 git-svn-id: http://skia.googlecode.com/svn/trunk@13086 2bbb7eff-a529-9590-31e7-b0007b416f81
* When a picture lies about its size (i.e., claims to be 100x100 but only ever ↵Gravatar commit-bot@chromium.org2014-01-15
| | | | | | | | | | | | draws to 90x100) arbitrary pixel differences can appear in the undrawn portion. This is causing spurious differences to appear in the 8888 vs. gpu telemetry results. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/136553004 git-svn-id: http://skia.googlecode.com/svn/trunk@13084 2bbb7eff-a529-9590-31e7-b0007b416f81
* submit_try: Obtain the list of trybots from the checked-in slaves.cfgGravatar commit-bot@chromium.org2014-01-14
| | | | | | | | | | | | | This should drastically speed up the script. BUG= R=epoger@google.com, rmistry@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/136683006 git-svn-id: http://skia.googlecode.com/svn/trunk@13071 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add default_msaa16 and nvpr configs to bench_pictures.cfgGravatar commit-bot@chromium.org2014-01-14
| | | | | | | | | | | BUG=skia:2032 R=robertphillips@google.com, bsalomon@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/137313005 git-svn-id: http://skia.googlecode.com/svn/trunk@13070 2bbb7eff-a529-9590-31e7-b0007b416f81
* Use git_cl.Changelist.GetUpstreamBranch() for diff in submit_tryGravatar borenet@google.com2014-01-14
| | | | | | | | | BUG=skia:1862 R=epoger@google.com Review URL: https://codereview.chromium.org/136823002 git-svn-id: http://skia.googlecode.com/svn/trunk@13066 2bbb7eff-a529-9590-31e7-b0007b416f81
* deprecate tools/test_rendering.py and tools/test_pictures.pyGravatar commit-bot@chromium.org2014-01-14
| | | | | | | | | | | | | they will be removed entirely on/after Feb 1 unless there is objection BUG=skia:1943 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/135783003 git-svn-id: http://skia.googlecode.com/svn/trunk@13065 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add no-op NULL picture to bench_record.Gravatar commit-bot@chromium.org2014-01-13
| | | | | | | | | | | | | | | | | Defaults of out/Release/bench_record are still fine; NULL's not too far off from stable at 900 loops. But for focus on NULL, I'd recommend something like out/Release/bench_record --loops 100000 --skps. Also: fail on failures, print 2 significant digits instead of fixed 4.2. BUG=skia:1850 R=tomhudson@chromium.org Author: mtklein@google.com Review URL: https://codereview.chromium.org/136873002 git-svn-id: http://skia.googlecode.com/svn/trunk@13054 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add bench_record.Gravatar commit-bot@chromium.org2014-01-13
| | | | | | | | | | | | | | | I got fed up trying to figure out how best to measure recording cost with bench_pictures, render_pictures, etc, so I wrote a new tool. Features welcome. BUG= R=tomhudson@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/132573002 git-svn-id: http://skia.googlecode.com/svn/trunk@13037 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fixes to roll_deps for the botsGravatar borenet@google.com2014-01-10
| | | | | | | | | | | | The bots are running an older version of git which does not support the -q/--quiet flag for branch or the --short flag for symbolic-ref. BUG= R=halcanary@google.com Review URL: https://codereview.chromium.org/134723002 git-svn-id: http://skia.googlecode.com/svn/trunk@13030 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove references to Skia's SVN repositoryGravatar borenet@google.com2014-01-09
| | | | | | | | | BUG= R=epoger@google.com Review URL: https://codereview.chromium.org/132423002 git-svn-id: http://skia.googlecode.com/svn/trunk@13006 2bbb7eff-a529-9590-31e7-b0007b416f81
* Changes to roll_deps.pyGravatar halcanary@google.com2014-01-08
| | | | | | | | | | | | | | | | | | | - Code cleanup - Stop assuming that chromium's checkout would be via git-svn. - Verbose commit message for the deps revision - Shorter branch names. - New default: save_branches = yes. - New option: --git_hash=GIT_HASH BUG=skia:1973 BUG=skia:1974 BUG=skia:1993 BUG=skia:1995 R=borenet@google.com Review URL: https://codereview.chromium.org/126523002 git-svn-id: http://skia.googlecode.com/svn/trunk@12974 2bbb7eff-a529-9590-31e7-b0007b416f81
* submit_try: create the diff file using git, rather than relying on trychange.pyGravatar borenet@google.com2014-01-08
| | | | | | | | | | | | BUG=skia:1862 (SkipBuildbotRuns) R=epoger@google.com Review URL: https://codereview.chromium.org/128413004 git-svn-id: http://skia.googlecode.com/svn/trunk@12967 2bbb7eff-a529-9590-31e7-b0007b416f81
* change offset to xy for pixelref subsettingGravatar reed@google.com2014-01-08
| | | | | | | | | BUG= R=scroggo@google.com Review URL: https://codereview.chromium.org/105893012 git-svn-id: http://skia.googlecode.com/svn/trunk@12958 2bbb7eff-a529-9590-31e7-b0007b416f81
* add unittest for render_pictures binaryGravatar commit-bot@chromium.org2014-01-07
| | | | | | | | | | | | | Once committed, this will be run as part of RunToolSelfTests on http://108.170.217.252:10117/builders/Housekeeper-PerCommit . BUG=skia:1943 R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/124253002 git-svn-id: http://skia.googlecode.com/svn/trunk@12941 2bbb7eff-a529-9590-31e7-b0007b416f81
* DEPS roll scriptGravatar halcanary@google.com2014-01-06
| | | | | | | | | | | | | | | | This script: - searches through the last N commits to find out the hash that is associated with the revision number. - creates a new branch in the chromium tree, modifies the DEPS file, commits, and uploads to Rietveld. - create a whitespace-only commit and uploads that to to Rietveld. BUG= R=borenet@google.com Review URL: https://codereview.chromium.org/123523003 git-svn-id: http://skia.googlecode.com/svn/trunk@12921 2bbb7eff-a529-9590-31e7-b0007b416f81
* Patch for Windows compilation errors from r12916Gravatar robertphillips@google.com2014-01-06
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12919 2bbb7eff-a529-9590-31e7-b0007b416f81
* Support mesa config in render_pictures.Gravatar rmistry@google.com2014-01-06
| | | | | | | | R=epoger@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/125083004 git-svn-id: http://skia.googlecode.com/svn/trunk@12916 2bbb7eff-a529-9590-31e7-b0007b416f81
* These strings are unused.Gravatar commit-bot@chromium.org2014-01-06
| | | | | | | | | | | R=reed@google.com, halcanary@google.com BUG= Author: mtklein@google.com Review URL: https://codereview.chromium.org/102393005 git-svn-id: http://skia.googlecode.com/svn/trunk@12914 2bbb7eff-a529-9590-31e7-b0007b416f81
* take 2: create simple 'skpmaker' tool to generate SKP files for testingGravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | (re-landing https://codereview.chromium.org/108343006 without the build breakages) BUG=skia:1943 R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/112253004 git-svn-id: http://skia.googlecode.com/svn/trunk@12866 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/108343006/Gravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | | | | Reason for revert: broke some builds R=rmistry@google.com, mtklein@google.com TBR=mtklein@google.com, rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia:1943 Author: epoger@google.com Review URL: https://codereview.chromium.org/102243012 git-svn-id: http://skia.googlecode.com/svn/trunk@12865 2bbb7eff-a529-9590-31e7-b0007b416f81
* create simple 'skpmaker' tool to generate SKP files for testingGravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | (needed to create self-test for render_pictures) BUG=skia:1943 R=rmistry@google.com, mtklein@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/108343006 git-svn-id: http://skia.googlecode.com/svn/trunk@12864 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make tests output spin on the same line by default.Gravatar commit-bot@chromium.org2014-01-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | -v now gives a cleaned-up version of the existing output (every test timed, useless information removed) Example output, default: [ 36/193] PathOpsCubicIntersectionOneOffTest then later when finished... [193/193] BlurMaskFilter Example output, -v: (note, codereview is messing up my pretty spacing) Skia UnitTests: --resourcePath resources SK_RELEASE SK_SCALAR_IS_FLOAT skia_arch_width=32 [ 1/193] 0ms PathOpsSimplifyDontFailOneTest [ 2/193] 0ms PathOpsSimplifyFailOneTest [ 3/193] 30ms PathOpsSkpTest [ 4/193] 21ms PathOpsSimplifyFailTest .... [182/193] 1026ms BlitRow [183/193] 808ms AAClip [184/193] 4333ms Math [185/193] 5068ms PackBits [186/193] 2265ms DrawText_DrawPosText [187/193] 9163ms PathOpsRectsThreadedTest [188/193] 5540ms GLPrograms [189/193] 0ms GLInterfaceValidation [190/193] 2ms DeferredCanvas [191/193] 1ms ClipCache [192/193] 30ms BlurMaskFilter [193/193] 10396ms PathOpsOpCubicsThreadedTest Finished 193 tests, 0 failures, 0 skipped. (622610 internal tests) BUG= R=halcanary@google.com, mtklein@google.com, bungeman@google.com Author: mtklein@google.com Review URL: https://codereview.chromium.org/109513002 git-svn-id: http://skia.googlecode.com/svn/trunk@12860 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add Options to SkDecodingImageGenerator, simplify API.Gravatar halcanary@google.com2014-01-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Motivation: We want to remove redundant classes from Skia. To that end we want to remove SkImageRef and its subclasses and replace their uses with SkDiscardablePixelRef + SkDecodingImageGenerator. Since Android uses SkImageRef, we need to make sure that SkDecodingImageGenerator allows all of the settings that Android exposes in BitmapFactory.Options. To that end, we have created an Options struct for the SkDecodingImageGenerator which lets the client of the generator set sample size, dithering, and bitmap config. We have made the SkDecodingImageGenerator constructor private and replaced the SkDecodingImageGenerator::Install functions with a SkDecodingImageGenerator::Create functions (one for SkData and one for SkStream) which now take a SkDecodingImageGenerator::Options struct. Also added a ImageDecoderOptions test which loops through a list of sets of options and tries them on a set of 5 small encoded images. Also updated several users of SkDecodingImageGenerator::Install to follow new call signature - gm/factory.cpp, LazyDecodeBitmap.cpp, and PictureTest.cpp, CachedDecodingPixelRefTest.cpp. We also added a new ImprovedBitmapFactory Test which simulates the exact function that Android will need to modify to use this, installPixelRef() in BitmapFactory. R=reed@google.com, scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=12744 Review URL: https://codereview.chromium.org/93703004 git-svn-id: http://skia.googlecode.com/svn/trunk@12855 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adds non-1 scalar to config names.Gravatar commit-bot@chromium.org2013-12-20
| | | | | | | | | | | BUG= R=robertphillips@google.com, bungeman@google.com, halcanary@google.com, scroggo@google.com, borenet@google.com Author: bensong@google.com Review URL: https://codereview.chromium.org/106823005 git-svn-id: http://skia.googlecode.com/svn/trunk@12811 2bbb7eff-a529-9590-31e7-b0007b416f81
* Change bench_pictures configsGravatar borenet@google.com2013-12-20
| | | | | | | | | | Aiming at CPU vs GPU R=epoger@google.com, robertphillips@google.com Review URL: https://codereview.chromium.org/111893004 git-svn-id: http://skia.googlecode.com/svn/trunk@12799 2bbb7eff-a529-9590-31e7-b0007b416f81
* create tools/tests/run_all.py to run all our Python self-tests within toolsGravatar commit-bot@chromium.org2013-12-19
| | | | | | | | | | | | | | | | Eventually, we want all of these self-tests to be written in Python; this change makes it easier for us to add new Python self-tests, and discourages the addition of bash self-tests. BUG=skia:677,skia:1943 NOTRY=True R=rmistry@google.com, scroggo@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/112163004 git-svn-id: http://skia.googlecode.com/svn/trunk@12775 2bbb7eff-a529-9590-31e7-b0007b416f81
* Yet another round of valgrind suppressionsGravatar robertphillips@google.com2013-12-19
| | | | | | | | https://codereview.chromium.org/116053004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12766 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of https://codereview.chromium.org/93703004/Gravatar commit-bot@chromium.org2013-12-18
| | | | | | | | | | | | | | | Reason for revert: Test failures R=scroggo@google.com, djsollen@google.com, reed@google.com, halcanary@google.com TBR=djsollen@google.com, halcanary@google.com, reed@google.com, scroggo@google.com NOTREECHECKS=true NOTRY=true Author: robertphillips@google.com Review URL: https://codereview.chromium.org/103753007 git-svn-id: http://skia.googlecode.com/svn/trunk@12747 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add Options to SkDecodingImageGenerator, simplify API.Gravatar halcanary@google.com2013-12-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Motivation: We want to remove redundant classes from Skia. To that end we want to remove SkImageRef and its subclasses and replace their uses with SkDiscardablePixelRef + SkDecodingImageGenerator. Since Android uses SkImageRef, we need to make sure that SkDecodingImageGenerator allows all of the settings that Android exposes in BitmapFactory.Options. To that end, we have created an Options struct for the SkDecodingImageGenerator which lets the client of the generator set sample size, dithering, and bitmap config. We have made the SkDecodingImageGenerator constructor private and replaced the SkDecodingImageGenerator::Install functions with a SkDecodingImageGenerator::Create functions (one for SkData and one for SkStream) which now take a SkDecodingImageGenerator::Options struct. Also added a ImageDecoderOptions test which loops through a list of sets of options and tries them on a set of 5 small encoded images. Also updated several users of SkDecodingImageGenerator::Install to follow new call signature - gm/factory.cpp, LazyDecodeBitmap.cpp, and PictureTest.cpp, CachedDecodingPixelRefTest.cpp. We also added a new ImprovedBitmapFactory Test which simulates the exact function that Android will need to modify to use this, installPixelRef() in BitmapFactory. R=reed@google.com, scroggo@google.com Review URL: https://codereview.chromium.org/93703004 git-svn-id: http://skia.googlecode.com/svn/trunk@12744 2bbb7eff-a529-9590-31e7-b0007b416f81
* Suppress questionable gpu errorsGravatar robertphillips@google.com2013-12-18
| | | | | | | | https://codereview.chromium.org/118283002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12743 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update bench pictures to time image decode & upload costsGravatar robertphillips@google.com2013-12-18
| | | | | | | | https://codereview.chromium.org/117583002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12742 2bbb7eff-a529-9590-31e7-b0007b416f81
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2013-12-18
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@12734 2bbb7eff-a529-9590-31e7-b0007b416f81
* move SkScalarLog2 into its only client, in a move to reduce our public API ↵Gravatar reed@google.com2013-12-18
| | | | | | | | | | surface area BUG= Review URL: https://codereview.chromium.org/93643004 git-svn-id: http://skia.googlecode.com/svn/trunk@12731 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-22 23:33:48 +0000