aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
* Add msaa runs to nanobenchGravatar bsalomon2015-02-28
| | | | | | TBR=mtklein@google.com Review URL: https://codereview.chromium.org/964053002
* Test msaa on bots using dm. 4 samples for Android, 16 elsewhereGravatar bsalomon2015-02-27
| | | | Review URL: https://codereview.chromium.org/958033004
* adding preabandon flag to DMGravatar joshualitt2015-02-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/929243004
* Revert of Default SK_ANGLE to true on Windows, run angle whenever possible ↵Gravatar mtklein2015-02-25
| | | | | | | | | | | | | | | | | | | | | | | | | on bots. (patchset #3 id:40001 of https://codereview.chromium.org/946933006/) Reason for revert: Needs bot upgrades. Original issue's description: > Default SK_ANGLE to true on Windows, run angle whenever possible on bots. > > nanobench doesn't need an update. It uses the default for --config, > which includes angle. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/88ec329b580a081d9d56cbcaad0ee46cb941c849 TBR=bsalomon@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/954243002
* Default SK_ANGLE to true on Windows, run angle whenever possible on bots.Gravatar mtklein2015-02-25
| | | | | | | | | nanobench doesn't need an update. It uses the default for --config, which includes angle. BUG=skia: Review URL: https://codereview.chromium.org/946933006
* Add tools/nanobench_flags.py.Gravatar mtklein2015-02-24
| | | | | | | | | | | | | | This should look suspiciously similar to tools/dm_flags.py. In fact, I tweaked tools/dm_flags.py a bit to make it even more suspiciously similar. I'll leave actually deduping this to future me. I noticed we have an opportunity to make our Valgrind run of nanobench faster, by not only making it not auto-calibrate (--loops 1) but also take only one measurement (--samples 1). Should be 5-10x faster than the default. BUG=skia: Review URL: https://codereview.chromium.org/957503002
* fix nvprGravatar Mike Klein2015-02-24
| | | | | | | | The config is called nvprmsaa4 (see DM.cpp:218) BUG=skia: Review URL: https://codereview.chromium.org/953743007
* add tools/dm_flags.pyGravatar mtklein2015-02-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/950903003
* Add HWUI Sink to DM on Android Framework buildsGravatar tomhudson2015-02-23
| | | | | | | | | | Allows "hwui" as a --config argument to dm, drawing through the Android Framework's HWUI backend. R=djsollen@google.com,mtklein@google.com BUG=skia: Review URL: https://codereview.chromium.org/943393002
* Remove unused parameters to SkDocument::CreatePDFGravatar halcanary2015-02-19
| | | | | | | | | | All image compression currently uses (losseless) Deflate, not Jpeg. All clients simply use SkDocument::CreatePDF(stream). SampleApp and SkLua still use SkDocument::CreatePDF(path). Review URL: https://codereview.chromium.org/935843007
* Avoid wrong memory access due to double substitution and %%Gravatar kkinnunen2015-02-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the form SkDebugf("%s", arbitraryString) instead of SkDebugf(arbitraryString). Fixes the case where SkString::appendf-ing a string with "%%" and then printing the string with SkDebugf would cause uninitialized read and corrupted debug print. ninja -C out/Debug tools && valgrind --leak-check=full ./out/Debug/render_pictures --config gpu -w q -r ... ... ==7307== Conditional jump or move depends on uninitialised value(s) ==7307== at 0x6908475: __printf_fp (printf_fp.c:1180) ==7307== by 0x6904267: vfprintf (vfprintf.c:1629) ==7307== by 0x6906E53: buffered_vfprintf (vfprintf.c:2313) ==7307== by 0x690188D: vfprintf (vfprintf.c:1316) ==7307== by 0x67E8F5: SkDebugf(char const*, ...) (SkDebug_stdio.cpp:18) ==7307== by 0x7983F1: GrContext::printCacheStats() const (GrTest.cpp:54) ==7307== by 0x408ECF: tool_main(int, char**) (render_pictures_main.cpp:480) ==7307== by 0x40913E: main (render_pictures_main.cpp:511) ==7307== Budget: 2048 items 100663296 bytes Entry Count: current 652 (651 budgeted, 0 wrapped, 297 locked, 638 scratch 32 0.000000ull), high 652 Entry Bytes: current 51087658 (budgeted 49826658, 49 0.000000ull, 1261000 unbudgeted) high 51087658 (observe "ull" instead of "% full") (from mtklein) This CL is not editing public API. TBR=reed@google.com Review URL: https://codereview.chromium.org/943453002
* Negative numbers are not flags.Gravatar mtklein2015-02-14
| | | | | | | | tested: d dm --matrix 1 -0.3 0 0.7 1 0 0 0 1 --src gm --config matrix-8888 -w bad BUG=skia: Review URL: https://codereview.chromium.org/924343002
* Remove SkPictureFlat.h include from SkDrawCommands.hGravatar robertphillips2015-02-13
| | | | | | | | | | This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 Committed: https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22 Review URL: https://codereview.chromium.org/912403004
* Adding new benchmark to test image decoding performance.Gravatar msarett2015-02-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/918673002
* Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #3 ↵Gravatar robertphillips2015-02-12
| | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/912403004/) Reason for revert: Erm - Chrome. Original issue's description: > Remove SkPictureFlat.h include from SkDrawCommands.h > > This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium > > Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 > > Committed: https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22 TBR=reed@google.com,fmalita@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/923753002
* Remove SkPictureFlat.h include from SkDrawCommands.hGravatar robertphillips2015-02-12
| | | | | | | | This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 Review URL: https://codereview.chromium.org/912403004
* Revert of Fix Chromium build (patchset #2 id:20001 of ↵Gravatar robertphillips2015-02-11
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/916763003/) Reason for revert: Chrome Original issue's description: > Fix Chromium build > > TBR=jvanverth@google.com > > Committed: https://skia.googlesource.com/skia/+/f5e89c8f685ac8a5c4d117e087b4111d613106db TBR=jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/916963002
* Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #2 ↵Gravatar robertphillips2015-02-11
| | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/912403004/) Reason for revert: Chrome Original issue's description: > Remove SkPictureFlat.h include from SkDrawCommands.h > > Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 TBR=reed@google.com,fmalita@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/917933002
* Fix Chromium buildGravatar robertphillips2015-02-11
| | | | | | TBR=jvanverth@google.com Review URL: https://codereview.chromium.org/916763003
* Remove SkPictureFlat.h include from SkDrawCommands.hGravatar robertphillips2015-02-11
| | | | Review URL: https://codereview.chromium.org/912403004
* rewrite ambiguous commentGravatar mtklein2015-02-10
| | | | | | | | It took me a few reads, but it eventually swapped from bunny to duck. BUG=skia: Review URL: https://codereview.chromium.org/913733002
* One createTexture function, attempt to recycle scratch in createTexture.Gravatar bsalomon2015-02-06
| | | | Review URL: https://codereview.chromium.org/864383003
* Suppress another FontConfig 'leak'.Gravatar bungeman2015-02-05
| | | | | | | | | | | | FontConfig uses offsets for elements instead of pointers, so any value held by an element goes missing from memory checkers. Previous suppressions took care of rule copies and adds to elements, but value lists may be copied as well. When they are, values are copied, including the content of strings and matricies. Since value lists are effectively like Fc*Add functions (even calling the same underlying helpers), treat them as such and suppress any 'leaks' they may cause. Review URL: https://codereview.chromium.org/894863003
* Land Ben's 32-bit symlink script.Gravatar Mike Klein2015-02-03
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/890613005
* patch from issue 886233004 at patchset 40001 ↵Gravatar mtklein2015-02-02
| | | | | | | | | | (http://crrev.com/886233004#ps40001) ... with changes proposed in the review. BUG=skia: Review URL: https://codereview.chromium.org/894013002
* First cut at cleaning up Sergio's example code and moving some common code ↵Gravatar caryclark2015-01-30
| | | | | | | | | | to SkWindow. Eventually, this will be moved to be a peer of SampleApp so it is compiled by the bots to avoid future bit rot. Also ignore XCode auto-generated flag in CommandLineFlags, and remove the unused multiple-example part. Review URL: https://codereview.chromium.org/890873003
* fix bit rotted code to create test fontGravatar caryclark2015-01-29
| | | | | | | BUG=skia:3080 R=reed@google.com Review URL: https://codereview.chromium.org/884873007
* More win64 warning fixes.Gravatar fmalita2015-01-29
| | | | | | | TBR=bsalomon@google.com NOTREECHECKS=true Review URL: https://codereview.chromium.org/887713002
* Fix win64 warnings.Gravatar bsalomon2015-01-29
| | | | | | | | TBR=joshualitt@google.com NOTREECHECKS=true Review URL: https://codereview.chromium.org/884253004
* sk_tool_utils::draw_checkerboard uses SkXfermode::kSrc_Mode to fix valgrind ↵Gravatar halcanary2015-01-27
| | | | | | error. Review URL: https://codereview.chromium.org/877103002
* s/sk_tools::DrawCheckerboard/sk_tool_utils::draw_checkerboard/Gravatar halcanary2015-01-26
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/873333004
* Factor out checkerboard function in gm and sampleapp into tools.Gravatar halcanary2015-01-26
| | | | Review URL: https://codereview.chromium.org/834303005
* Cleanup: Delete buildbot_globals.py script.Gravatar tfarina2015-01-23
| | | | | | | | | | | | rebaseline_server was the only user of this code but it was removed in https://chromium.googlesource.com/skia/+/3886046f008f0542de36cbeb35e220404e7c88a9 So there aren't more users of this script and we can remove it now. BUG=skia:3200 R=borenet@google.com Review URL: https://codereview.chromium.org/873593005
* remove (unused) GatherPixelRefsGravatar reed2015-01-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/869463002
* More natural way to serialize GPU tasks and tests.Gravatar mtklein2015-01-21
| | | | | | | | | | | | | This basically takes out the Windows-only hacks and promotes them to cross-platform behavior driven by --gpu_threading. - When --gpu_threading is false (the default), this puts GPU tasks and tests together in the same GPU enclave. They all run serially. - When --gpu_threading is true, both the tests and the tasks run totally independently, just like the thread-safe CPU-bound work. BUG=skia:3255 Review URL: https://codereview.chromium.org/847273005
* Make SkStream *not* ref counted.Gravatar scroggo2015-01-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SkStream is a stateful object, so it does not make sense for it to have multiple owners. Make SkStream inherit directly from SkNoncopyable. Update methods which previously called SkStream::ref() (e.g. SkImageDecoder::buildTileIndex() and SkFrontBufferedStream::Create(), which required the existing owners to call SkStream::unref()) to take ownership of their SkStream parameters and delete when done (including on failure). Switch all SkAutoTUnref<SkStream>s to SkAutoTDelete<SkStream>s. In some cases this means heap allocating streams that were previously stack allocated. Respect ownership rules of SkTypeface::CreateFromStream() and SkImageDecoder::buildTileIndex(). Update the comments for exceptional methods which do not affect the ownership of their SkStream parameters (e.g. SkPicture::CreateFromStream() and SkTypeface::Deserialize()) to be explicit about ownership. Remove test_stream_life, which tested that buildTileIndex() behaved correctly when SkStream was a ref counted object. The test does not make sense now that it is not. In SkPDFStream, remove the SkMemoryStream member. Instead of using it, create a new SkMemoryStream to pass to fDataStream (which is now an SkAutoTDelete). Make other pdf rasterizers behave like SkPDFDocumentToBitmap. SkPDFDocumentToBitmap delete the SkStream, so do the same in the following pdf rasterizers: SkPopplerRasterizePDF SkNativeRasterizePDF SkNoRasterizePDF Requires a change to Android, which currently treats SkStreams as ref counted objects. Review URL: https://codereview.chromium.org/849103004
* Remove tools/tests.Gravatar Mike Klein2015-01-21
| | | | | | | BUG=skia: R=bsalomon@google.com Review URL: https://codereview.chromium.org/796813004
* Revert "Revert "delete old things!""Gravatar bsalomon2015-01-20
| | | | | | | | | This reverts commit 8b4489b6e696ce4b1abbffa9b2cbd0d3bfdeb387. Delete gm and other unused files TBR=mtklien@google.com Review URL: https://codereview.chromium.org/856103002
* Remove roll_deps and trybots_to_run.Gravatar rmistry2015-01-20
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/859963003
* tool --help alphabetizes command line flagsGravatar halcanary2015-01-18
| | | | Review URL: https://codereview.chromium.org/854193003
* Revert "delete old things!"Gravatar Brian Salomon2015-01-16
| | | | | | | | | | | | This reverts commit 15b125d40122e966bd723d23e82c3224b1da4898. NOTREECHECKS=true original change breaks android tree BUG=skia: Review URL: https://codereview.chromium.org/848073005
* delete old things!Gravatar bsalomon2015-01-16
| | | | | | NOTREECHECKS=true Review URL: https://codereview.chromium.org/855003006
* * Add nytimes_desktop pageset.Gravatar rmistry2015-01-16
| | | | | | | | | | | * Delete cuteoverload, frantzen, transformice and nytimes_tabl. * Increase wait time for forecastio. BUG=skia:3320 NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/808843004
* Require budget decision when creating a RenderTarget SkSurface.Gravatar bsalomon2015-01-16
| | | | | | | | | Restructure SkGpuDevice creation: *SkSurfaceProps are optional. *Use SkSurfaceProps to communicate DF text rather than a flag. *Tell SkGpuDevice::Create whether RT comes from cache or not. Review URL: https://codereview.chromium.org/848903004
* Remove obsolete mac_gpuGravatar sergiyb2015-01-15
| | | | | | | | | BUG=chromium:426897 R=kbr@google.com,phajdan@google.com,reed@google.com NOTREECHECKS=true Review URL: https://codereview.chromium.org/812963003
* Sketch DM refactor.Gravatar mtklein2015-01-15
| | | | | | | | | | | | | | | | | | | BUG=skia:3255 I think this supports everything DM used to, but has completely refactored how it works to fit the design in the bug. Configs like "tiles-gpu" are automatically wired up. I wouldn't suggest looking at this as a diff. There's just a bunch of deleted files, a few new files, and one new file that shares a name with a deleted file (DM.cpp). NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88 Review URL: https://codereview.chromium.org/788243008
* Revert of Sketch DM refactor. (patchset #45 id:850001 of ↵Gravatar mtklein2015-01-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/788243008/) Reason for revert: plenty of data Original issue's description: > Sketch DM refactor. > > BUG=skia:3255 > > > I think this supports everything DM used to, but has completely refactored how > it works to fit the design in the bug. > > Configs like "tiles-gpu" are automatically wired up. > > I wouldn't suggest looking at this as a diff. There's just a bunch of deleted > files, a few new files, and one new file that shares a name with a deleted file > (DM.cpp). > > NOTREECHECKS=true > > Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88 TBR=bsalomon@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3255 Review URL: https://codereview.chromium.org/853883004
* Sketch DM refactor.Gravatar mtklein2015-01-15
| | | | | | | | | | | | | | | | | BUG=skia:3255 I think this supports everything DM used to, but has completely refactored how it works to fit the design in the bug. Configs like "tiles-gpu" are automatically wired up. I wouldn't suggest looking at this as a diff. There's just a bunch of deleted files, a few new files, and one new file that shares a name with a deleted file (DM.cpp). NOTREECHECKS=true Review URL: https://codereview.chromium.org/788243008
* upstream hooking into google3 crash handler for better stacktracesGravatar mtklein2015-01-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/821643006
* Add pageset for ugamsolutions.comGravatar rmistry2015-01-13
| | | | | | | BUG=skia:3306 NOTRY=true Review URL: https://codereview.chromium.org/851743004
generated by cgit v1.2.3 (git 2.39.1) at 2024-10-03 08:18:52 +0000