aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
* Fix up -Winconsistent-missing-overrideGravatar mtklein2015-07-13
| | | | | | | | | | | | | | (and a couple presubmit fixes) This allows us to turn back on -Werror for LLVM coverage builds, and more generally supports building with Clang 3.7. No public API changes. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/1232463006
* add runtime option to provide data->imagegenerator factoryGravatar reed2015-07-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1229933003
* Temporarily suppress valgrind errors in tip of tree libjpeg-turboGravatar msarett2015-07-09
| | | | | | BUG=skia:4030 Review URL: https://codereview.chromium.org/1231613004
* Add tools/flatten to flatten nested pictures in .skps.Gravatar mtklein2015-07-08
| | | | | | | | | Tested by running on skps/sp_desk_nytimes.skp. The output .skp had no nested draw picture calls, and the files were both 9.3M. BUG=skia: Review URL: https://codereview.chromium.org/1221303020
* fix pathops battle testGravatar caryclark2015-07-07
| | | | | | | | | | The intermediate subtraction threw away bits causing the subsequent cross product to fail. Defer the bit truncation until after the vector is computed. TBR=reed@google.com Review URL: https://codereview.chromium.org/1226933003
* Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.Gravatar mtklein2015-07-07
| | | | | | | | | | | | | | SkThread.h doesn't do anything anymore execept include those two, and thankfully, it doesn't seem to be mentioned outside Skia. No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc Review URL: https://codereview.chromium.org/1215393002
* When three or more edges are coincident, the logic needsGravatar caryclark2015-07-06
| | | | | | | | | | | | | | | | to compute the overlapping ranges and combine the winding into a single destination. This computes coincidence more rigorously, fixing the edge cases exposed by this bug. Also, add the ability to debug and dump pathop structures from the coincident context. TBR=reed@google.com BUG=skia:3651 Review URL: https://codereview.chromium.org/1182493015
* Add nanobench-style JSON output to llvm_coverage_runGravatar borenet2015-07-06
| | | | | | | | | Runs the build and run scripts for coverage, then dumps the results into a file in nanobench-compatible format. BUG=skia:2430 Review URL: https://codereview.chromium.org/1227523004
* Add scripts for running LLVM coverageGravatar borenet2015-07-06
| | | | | | BUG=skia:2430 Review URL: https://codereview.chromium.org/1213063009
* Revert of Remove SkThread.h, include SkMutex.h or SkAtomics.h as ↵Gravatar jvanverth2015-07-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | appropriate. (patchset #4 id:60001 of https://codereview.chromium.org/1215393002/) Reason for revert: Breaking the roll. E.g. on android_chromium_gn_compile_dbg: FAILED: /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/skia/ext/libskia.SkMemory_new_handler.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DDONT_EMBED_BUILD_METADATA -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_SUPERVISED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -DUSE_PROPRIETARY_CODECS -DV8_USE_EXTERNAL_STARTUP_DATA -DVIDEO_HOLE=1 -DMOBILE_SAFE_BROWSING -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -DCOMPONENT_BUILD -D__GNU_SOURCE=1 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DSKIA_IMPLEMENTATION=1 -DSK_ARM_HAS_OPTIONAL_NEON -DSK_GAMMA_APPLY_TO_A8 -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSK_DEFAULT_FONT_CACHE_LIMIT=1048576 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DXML_STATIC -I../.. -Igen -I../../third_party/skia/include/private -I../../third_party/skia/src/core -I../../third_party/skia/src/image -I../../third_party/skia/src/opts -I../../third_party/skia/src/pdf -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/zlib -I../../third_party/expat/files/lib -I../../third_party/freetype-android/include -I../../third_party/freetype-android/src/include -I../../third_party/android_tools/ndk/sources/android/cpufeatures -fno-strict-aliasing -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork -fno-tree-sra -fno-caller-saves -funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64 -mfpu=vfpv3-d16 -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fvisibility=hidden --sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm -Os -fdata-sections -ffunction-sections -fomit-frame-pointer -g1 -Wno-format -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -Wno-deprecated -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor -Wno-sign-promo -c ../../skia/ext/SkMemory_new_handler.cpp -o obj/skia/ext/libskia.SkMemory_new_handler.o ../../skia/ext/SkMemory_new_handler.cpp:12:52: fatal error: third_party/skia/include/core/SkThread.h: No such file or directory #include "third_party/skia/include/core/SkThread.h" Original issue's description: > Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. > > SkThread.h doesn't do anything anymore execept include those two, > and thankfully, it doesn't seem to be mentioned outside Skia. > > No public API changes. > TBR=reed@google.com > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1214603003
* Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.Gravatar mtklein2015-07-01
| | | | | | | | | | | | SkThread.h doesn't do anything anymore execept include those two, and thankfully, it doesn't seem to be mentioned outside Skia. No public API changes. TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/1215393002
* Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while ↵Gravatar herb2015-06-30
| | | | | | | | | | | | | | | | | | | | | | | | investigating. (patchset #1 id:1 of https://codereview.chromium.org/1213033003/) Reason for revert: Add tsan annotations to repair tests. Original issue's description: > Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. > > The ~ means "don't run this". This keeps all the other bots running the code, skipping it only on the whiny TSAN bot. > > BUG=skia:3997 > > Committed: https://skia.googlesource.com/skia/+/37cc0b2e31e4a078b12790253d7032d36271440c TBR=mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3997 Review URL: https://codereview.chromium.org/1218153004
* Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating.Gravatar mtklein2015-06-30
| | | | | | | | The ~ means "don't run this". This keeps all the other bots running the code, skipping it only on the whiny TSAN bot. BUG=skia:3997 Review URL: https://codereview.chromium.org/1213033003
* Add wrapper script for computing n-grams from SKPs on Cluster TelemetryGravatar borenet2015-06-30
| | | | | | | | Add --n argument BUG=skia:3840 Review URL: https://codereview.chromium.org/1216073007
* Remove default for --images in common flagsGravatar bsalomon2015-06-30
| | | | Review URL: https://codereview.chromium.org/1214363002
* Use AddStory instead of deprecated AddUserStoryGravatar rmistry2015-06-30
| | | | | | | | BUG=skia:3967 TBR=nednguyen NOTRY=true Review URL: https://codereview.chromium.org/1212843008
* Revert of Use page_set_module.PageSet instead of story.StorySet (patchset #1 ↵Gravatar rmistry2015-06-30
| | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1221553003/) Reason for revert: This should no longer be required due to Ned's fix in https://codereview.chromium.org/1217823005/ Original issue's description: > Use page_set_module.PageSet instead of story.StorySet > > BUG=skia:3967 > NOTRY=true > TBR=nednguyen > > Committed: https://skia.googlesource.com/skia/+/7b971f0152299ae9a924252a9bfd220318497bdd TBR=nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3967 Review URL: https://codereview.chromium.org/1214903008
* Add benchmarkstream to visualbenchGravatar joshualitt2015-06-30
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1215033002
* Move visualbench to its own folderGravatar joshualitt2015-06-30
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1216973002
* Use page_set_module.PageSet instead of story.StorySetGravatar rmistry2015-06-30
| | | | | | | | BUG=skia:3967 NOTRY=true TBR=nednguyen Review URL: https://codereview.chromium.org/1221553003
* Migrate PageSets to StorySets in buildbot page setsGravatar rmistry2015-06-30
| | | | | | | | BUG=skia:3967 NOTRY=true TBR= Review URL: https://codereview.chromium.org/1203433002
* Add script for triggering Cluster Telemetry jobs using local scriptsGravatar borenet2015-06-29
| | | | | | BUG=skia:3979 Review URL: https://codereview.chromium.org/1214843002
* remove SkInstCntGravatar mtklein2015-06-26
| | | | | | | | | | | | | | It's been outclassed by Valgrind and leak sanitizer, and it seems to be causing problems for external folks building Skia. I'm not sure why our own builds seem unaffected. Latest thread: https://groups.google.com/forum/#!topic/skia-discuss/oj9FsQwwSF0 BUG=skia: Review URL: https://codereview.chromium.org/1217573002
* Add samplingTime mode to nanobenchGravatar cdalton2015-06-25
| | | | | | | | | Adds a nanobench mode that takes samples for a fixed amount of time, rather than taking a fixed amount of samples. BUG=skia: Review URL: https://codereview.chromium.org/1204153002
* Add lua scripts for generating n-grams from SKPsGravatar borenet2015-06-25
| | | | | | BUG=skia:3840 Review URL: https://codereview.chromium.org/1204283002
* Make SkGpuDevice know its alpha typeGravatar bsalomon2015-06-23
| | | | | | | | Make SkImage_Gpu snapshots opaque if surface is opaque. BUG=skia:3965 Review URL: https://codereview.chromium.org/1205643002
* add autotuning to visualbenchGravatar joshualitt2015-06-23
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1201003002
* Propagate SkSurfaceProps to more call sitesGravatar robertphillips2015-06-23
| | | | | | | | | | Start moving to a world where everyone provides surface properties. Most notably this exposes a portion of SkSurfaceProps to the C API. BUG=skia:3934 Review URL: https://codereview.chromium.org/1195003003
* change old picture serialization to really handle imagesGravatar reed2015-06-22
| | | | | | BUG=skia:3965 Review URL: https://codereview.chromium.org/1199473002
* Revert of Disable failing GPU tests on Nexus 6. (patchset #1 id:1 of ↵Gravatar joshualitt2015-06-19
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1185753002/) Reason for revert: this should hopefully be fixed now. Original issue's description: > Disable failing GPU tests on Nexus 6. > > BUG=skia:3942 > > Committed: https://skia.googlesource.com/skia/+/8ed08e54f4868d3ef88225bf873ce678e7716bd9 TBR=bsalomon@google.com,djsollen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3942 Review URL: https://codereview.chromium.org/1196653002
* Allows windowed apps to be built on the Mac just by writing a SkOSWindow ↵Gravatar bsalomon2015-06-18
| | | | | | | | subclass without needing nib/plist files. Makes visualbench work on the Mac. Review URL: https://codereview.chromium.org/1184143011
* Remove separate SP enabled SKP run since it is now on by defaultGravatar rmistry2015-06-18
| | | | | | | | | | | | | Yesterday's RecreateSKPs_Canary run looks good: http://build.chromium.org/p/client.skia.fyi/builders/Housekeeper-Nightly-RecreateSKPs_Canary/builds/143 The generated SKPs look very reasonably sized: gs://chromium-skia-gm/playback_386/skps BUG=skia: NOTRY=true Review URL: https://codereview.chromium.org/1191113002
* Add sk_parallel_for()Gravatar mtklein2015-06-17
| | | | | | | | | | | | | | | | | | | | | | | | This should be a drop-in replacement for most for-loops to make them run in parallel: for (int i = 0; i < N; i++) { code... } ~~~> sk_parallel_for(N, [&](int i) { code... }); This is just syntax sugar over SkTaskGroup to make this use case really easy to write. There's no more overhead that we weren't already forced to add using an interface like batch(), and no extra heap allocations. I've replaced 3 uses of SkTaskGroup with sk_parallel_for: 1) My unit tests for SkOnce. 2) Cary's path fuzzer. 3) SkMultiPictureDraw. Performance should be the same. Please compare left and right for readability. :) BUG=skia: No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1184373003
* Load visualbench pictures one at a time.Gravatar bsalomon2015-06-16
| | | | | | | | Add flag to run in windowed mode. NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1183193003
* Move closeWindow()/setFullscreen()/setVSynv() from SkWindow to SkOSWindowGravatar bsalomon2015-06-16
| | | | | | Rename setFullscreen to makeFullscreen, drop the param, return a bool. Review URL: https://codereview.chromium.org/1181723006
* nanobench: split CPU and GPU .SKP tile sizes.Gravatar mtklein2015-06-16
| | | | | | | | | Let's make CPU-bound .SKP benching mimic Chrome's tiles. Unfortunately, the CPU code also performs a lot better with those big wide tiles... BUG=skia: Review URL: https://codereview.chromium.org/1189863002
* There are still things to sort out but this seems to run correctly.Gravatar bsalomon2015-06-16
| | | | Review URL: https://codereview.chromium.org/1187643002
* Convert PictureRenderer to SkPaintFilterCanvasGravatar fmalita2015-06-15
| | | | | | | | | This removes the last client of SkDrawFilter. BUG=skia:3587 R=mtklein@google.com,robertphillips@google.com Review URL: https://codereview.chromium.org/1181633005
* Revert of Revert of make gm background colors 565 compatible (patchset #1 ↵Gravatar caryclark2015-06-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1184123002/) Reason for revert: underlying problem with portable refs deleted more than once fixed Original issue's description: > Revert of make gm background colors 565 compatible (patchset #2 id:20001 of https://codereview.chromium.org/1176243006/) > > Reason for revert: > breaks many bots with refcnt error > > Original issue's description: > > make gm background colors 565 compatible > > > > Change a batch of GM tests to convert their background color > > so that it is representable in 8888 and 565. > > > > Enable portable text in those same tests to minimize platform > > differences. > > > > In a couple of bitmap tests, use portable typefaces instead of > > choosing 'Times' which may or may not be available on the platform. > > > > R=borenet@google.com > > > > Committed: https://skia.googlesource.com/skia/+/be7f768a357aefb39c42d24b81b24d647bb6ab70 > > TBR=borenet@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/0bdb08b1ba8fbd18c4838f86a23f1ef4b3a3bfdf TBR=borenet@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1182403003
* call portable font cleanup only once at app endGravatar caryclark2015-06-15
| | | | | | R=mtklein@google.com Review URL: https://codereview.chromium.org/1180593005
* Revert of make gm background colors 565 compatible (patchset #2 id:20001 of ↵Gravatar caryclark2015-06-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1176243006/) Reason for revert: breaks many bots with refcnt error Original issue's description: > make gm background colors 565 compatible > > Change a batch of GM tests to convert their background color > so that it is representable in 8888 and 565. > > Enable portable text in those same tests to minimize platform > differences. > > In a couple of bitmap tests, use portable typefaces instead of > choosing 'Times' which may or may not be available on the platform. > > R=borenet@google.com > > Committed: https://skia.googlesource.com/skia/+/be7f768a357aefb39c42d24b81b24d647bb6ab70 TBR=borenet@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1184123002
* make gm background colors 565 compatibleGravatar caryclark2015-06-15
| | | | | | | | | | | | | | | Change a batch of GM tests to convert their background color so that it is representable in 8888 and 565. Enable portable text in those same tests to minimize platform differences. In a couple of bitmap tests, use portable typefaces instead of choosing 'Times' which may or may not be available on the platform. R=borenet@google.com Review URL: https://codereview.chromium.org/1176243006
* Visual bench on native androidGravatar joshualitt2015-06-12
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1164403002
* make emptypath portable; add 565 color utilityGravatar caryclark2015-06-12
| | | | | | R=djsollen@google.com Review URL: https://codereview.chromium.org/1182833004
* Stop running SKPs in DM on the bots.Gravatar mtklein2015-06-12
| | | | | | | | | We're not triaging them, and we get the same coverage (both Release and Debug) from nanobench. BUG=skia: Review URL: https://codereview.chromium.org/1178943006
* Disable failing GPU tests on Nexus 6.Gravatar djsollen2015-06-12
| | | | | | BUG=skia:3942 Review URL: https://codereview.chromium.org/1185753002
* PDF expects fonts to map glyph ID 0 to the missing character.Gravatar caryclark2015-06-11
| | | | | | | | Add a mapping of glyph ID 0 to the toy font to allow for this. TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1175243004
* Label some unused static vars as SK_UNUSEDGravatar fmalita2015-06-10
| | | | | | | | | | | | Makes my gcc 5.1.1 much happier. R=mtklein@google.com,scroggo@google.com [ mtklein mischief below here ] No public API changes. TBR=reed@google.com Review URL: https://codereview.chromium.org/1170863006
* Today's gm include many differences caused by platform font implementations.Gravatar caryclark2015-06-10
| | | | | | | | | | | | | | | This experiment replaces the label used in the aaxfermodes gm with aliased text generated from paths common to all platforms. Since there is no way today to generate all dm output from trybots, this will be checked in to confirm that this strategy provides simpler output across devices. This does not introduce a new public interface; instead, dm uses a extern backdoor to install the SkTypeface::CreateFromName handler. Review URL: https://codereview.chromium.org/1163283002
* Update flags passed to Android GPU bots to exclude running skps and image ↵Gravatar djsollen2015-06-10
| | | | | | sources. Review URL: https://codereview.chromium.org/1176923003
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-08 09:46:58 +0000