aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/skqp
Commit message (Collapse)AuthorAge
* Replace nearly all kRespect with kIgnoreGravatar Brian Osman2018-07-12
| | | | | | | | | | | | | | | | | | | | | | | | | | - Encoders and decoders always assume kIgnore. - They are less opinionated about F16 and color space, we just trust the color space that's passed in, and put that directly in the image (no sRGB encoding). - SkBitmap and SkPixmap read/write pixels functions were defaulting to kResepct, those are now always kIgnore. - Many other bits of plumbing are simplified, and I added a default of kIgnore to SkImage::makeColorSpace, so we can phase out that argument entirely. - Still need to add defaults to other public APIs that take SkTransferFunctionBehavior. - This makes gold think that we've dramatically changed the contents of all F16 images, but that's because it doesn't understand the (now linear) color space that's embedded. Once we triage them all once, they will work fine (and they'll look perfect in the browser). Bug: skia: Change-Id: I62fa090f96cae1b67d181ce14bd91f34ff2ed747 Reviewed-on: https://skia-review.googlesource.com/140570 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Revert "Revert "SkTypes: extract SkTo""Gravatar Hal Canary2018-06-14
| | | | | | | | | | | | | | | | This reverts commit fdcfb8b7c23fbf18f872d2c31d27978235033876. > Original change's description: > > SkTypes: extract SkTo > > > > Change-Id: I8de790d5013db2105ad885fa2683303d7c250b09 > > Reviewed-on: https://skia-review.googlesource.com/133620 > > Reviewed-by: Mike Klein <mtklein@google.com> Change-Id: Ida74fbc5c21248a724a5edbf9fae18a33bcb23aa Reviewed-on: https://skia-review.googlesource.com/134506 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Revert "SkTypes: extract SkTo"Gravatar Hal Canary2018-06-13
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2a2f67592602b18527bc3fd449132d420cd5b62e. Reason for revert: this appears to be what is holding up the Chrome roll. Original change's description: > SkTypes: extract SkTo > > Change-Id: I8de790d5013db2105ad885fa2683303d7c250b09 > Reviewed-on: https://skia-review.googlesource.com/133620 > Reviewed-by: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,halcanary@google.com No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Iafd738aedfb679a23c061a51afe4b98a8d4cdfae Reviewed-on: https://skia-review.googlesource.com/134504 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkTypes: extract SkToGravatar Hal Canary2018-06-12
| | | | | | Change-Id: I8de790d5013db2105ad885fa2683303d7c250b09 Reviewed-on: https://skia-review.googlesource.com/133620 Reviewed-by: Mike Klein <mtklein@google.com>
* skqp: update apk list scriptGravatar Hal Canary2018-05-31
| | | | | | Change-Id: I3e8cfdc246d6f264675b307c1f5004438f3ed8b6 Reviewed-on: https://skia-review.googlesource.com/131142 Reviewed-by: Hal Canary <halcanary@google.com>
* Enable skcms on skqpGravatar Brian Osman2018-05-29
| | | | | | | | | | | Prelude to skcms becoming non-optional Change-Id: Ic60ab1b26f3383b08611f62ac2304e32508f9b8a Reviewed-on: https://skia-review.googlesource.com/130640 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Remove "/" from the generated jUnit method names.Gravatar Derek Sollenberger2018-05-23
| | | | | | | | | | | | The "/" character is not a valid character for method names in the CTS testing environment and is causing problems with some of the tooling so we are replacing the "/" with "_". Bug: b/80096930 Change-Id: Icdf790b0975f7c4205153887ffabaaaa85f07592 Reviewed-on: https://skia-review.googlesource.com/129581 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* [skottie] Disable on Android Framework buildsGravatar Florin Malita2018-05-04
| | | | | | | | | | Make Skottie truly optional (own flag), and disable in framework builds (to unblock landing the RapidJson refactoring). Change-Id: I4611f915e43fe11c1f6754ab4a9f63e45af2f8d3 Reviewed-on: https://skia-review.googlesource.com/125872 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Klein <mtklein@google.com>
* sk_tools/Resources: optional SK_TOOLS_REQUIRE_RESOURCES flagGravatar Hal Canary2018-04-24
| | | | | | | | | BUG=skia:7842 Change-Id: I1ce7d12308cd8ee101163d73dfc79f2d2155c632 Reviewed-on: https://skia-review.googlesource.com/123425 Auto-Submit: Hal Canary <halcanary@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* SkQP: speed up tools/skqp/make_apk_list\Gravatar Hal Canary2018-04-18
| | | | | | | | NoTry: true Change-Id: I94852a9375329a6c9df269004b89efb48d2e4691 Reviewed-on: https://skia-review.googlesource.com/122083 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add multilib support as the default build option for libskqpGravatar Derek Sollenberger2018-04-02
| | | | | | Change-Id: I98e7315f402bf9ff8fd11e990497e17fa0c0dc7a Reviewed-on: https://skia-review.googlesource.com/117636 Reviewed-by: Hal Canary <halcanary@google.com>
* Update Android build file for SkQP to point to ndk compliant libjsoncppGravatar Derek Sollenberger2018-03-21
| | | | | | | | Bug: b/74442448 Change-Id: If5e0e349cdb13352d580e55b0af26c908cc80003 Reviewed-on: https://skia-review.googlesource.com/115605 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* SkQP/Docs: fix missing step in READMEGravatar Hal Canary2018-03-20
| | | | | | | | NoTry: true Change-Id: Id97b0677ea203fdf542e42957a38feb84db08b4c Reviewed-on: https://skia-review.googlesource.com/115365 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Test SKQP on Firebase Testlab and UploadGravatar Stephan Altmueller2018-03-07
| | | | | | | | | | | | | | - adds building the testlab driver (run_testlab) as a separate step - adds gcloud isolate necessary to run testlab - adds Testlab support and uploading a verified AKP to GCS (with meta data attached). Bug: skia: Change-Id: I1bf265f46c99360eb3a9eb684886f93de48085fe Reviewed-on: https://skia-review.googlesource.com/111603 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* SkQP: Host APK list on cloud; no more commitsGravatar Hal Canary2018-03-02
| | | | | | | | No-Try: true Change-Id: I7f77c828cba2aa3763d495bec86d016eb65cb485 Reviewed-on: https://skia-review.googlesource.com/111741 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: optionally build make_universal_apk with debug on.Gravatar Hal Canary2018-02-27
| | | | | | | | | | | | | | * Respects SKQP_DEBUG=true. * Also, be more selective about cleaning. (So I can test on master.) * Also, stop using `gradlew --daemon`, which was getting confused when switching back and forth build types. No-Try:true Change-Id: Id93f77ab7831a82cad9a3a64dbb8a93af4757d57 Reviewed-on: https://skia-review.googlesource.com/108222 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* SkQP: do test filtering correctlyGravatar Hal Canary2018-02-23
| | | | | | | | | | PLEASE NOTE: Instructions for running a single test have changed! No-Try: true Change-Id: I1923240e879daa7ff0556737ddd5aa3f58e0097c Reviewed-on: https://skia-review.googlesource.com/109566 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
* SkQP: run a single testGravatar Hal Canary2018-02-21
| | | | | | | | | | | | | | PLEASE NOTE: Instructions on running `am instrument` for the SkQP APK have changed. To run a single test, see the section "Running a single test" in `tools/skqp/README.md`. No-Try: true Change-Id: I0a2cbc47755929d6c6a927a3591ff98046779c77 Reviewed-on: https://skia-review.googlesource.com/108780 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add nativeFonts flag to Viewer.Gravatar Ben Wagner2018-02-21
| | | | | | | | | | | This moves DMFontMgr and several related files which are tightly related to fonts into tools/fonts, moves some flags around to prevent duplication, and adds the nativeFonts handling to Viewer. Change-Id: Id1bdad708a6b74319ac5ac9adfe21025db4ca0b2 Reviewed-on: https://skia-review.googlesource.com/108904 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* SkQP: update README.mdGravatar Hal Canary2018-02-20
| | | | | | | | No-Try: true Change-Id: I7b12f683901ece91e3a7e2d9fa432aa05fbcf12a Reviewed-on: https://skia-review.googlesource.com/108568 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: debug option, and fix a bugGravatar Hal Canary2018-02-13
| | | | | | | Change-Id: I642c65815fdab5adcd7735956e1955ede8ff229a Reviewed-on: https://skia-review.googlesource.com/106805 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: Slimmer APKSGravatar Hal Canary2018-02-12
| | | | | | | | | | Currently produces 30% smaller APKs. No-Try: true Change-Id: Ic04b4bebef78e9a3f8b8dde4bace78ce74e43d66 Reviewed-on: https://skia-review.googlesource.com/106165 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com>
* Android Tools: build x86_64 correctly.Gravatar Hal Canary2018-02-09
| | | | | | | | | | | | | | - Fix some naming confusion between `x64` and `x86-64`. - SkQP Universal (multi-arch apk) Build Script [tools/skqp/make_universal_apk] - skqp/build.gradle: add `universal` product flavor - skqp manifest: make debug build optional. No-Try: true Change-Id: Ic8cd88719a34786ab2d53771749b2beb9db98be5 Reviewed-on: https://skia-review.googlesource.com/105023 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* move a bunch of helpers from SkImageInfo.h into privGravatar Mike Reed2018-02-09
| | | | | | | | | Bug: skia: Change-Id: I8c91cfdb89e4f22448d1201d391556fe43d86dca Reviewed-on: https://skia-review.googlesource.com/105289 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Cary Clark <caryclark@google.com>
* SkQP: download_model complains when files.checksum is missingGravatar Hal Canary2018-02-06
| | | | | | | Change-Id: I4fad015181f15e4ffb9c9607723a1313a041621b Reviewed-on: https://skia-review.googlesource.com/103763 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add a global error tolerance of 4 to the SkQP Android.bp build fileGravatar Derek Sollenberger2018-02-05
| | | | | | | Change-Id: Iceebd0e153351cad1c2784daf6cabcc8f3bb8ebf Reviewed-on: https://skia-review.googlesource.com/103720 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Derek Sollenberger <djsollen@google.com>
* SkQP: use multiprocessing over threadingGravatar Hal Canary2018-02-05
| | | | | | | | | BUG=skia:7579 NOTRY=true Change-Id: I4c7d2331e88171943f724592eb1481a5ea41b0ba Reviewed-on: https://skia-review.googlesource.com/103700 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* [skqp] More args for skqp related scriptsGravatar Stephan Altmueller2018-02-02
| | | | | | | | | | | | - allows to choose api versions in run_testlab.go - adds api_version and work_arounds to generate_gn_args Bug: skia: Change-Id: I87516b493f4d8eef3689d1722a5dd864131a44f8 Reviewed-on: https://skia-review.googlesource.com/102900 Reviewed-by: Derek Sollenberger <djsollen@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* SkQP: stop using global across jni callsGravatar Hal Canary2018-02-02
| | | | | | | | BIG=skia:7572 Change-Id: I9231e5264305eb871e31ec7b9d23c042135bbefc Reviewed-on: https://skia-review.googlesource.com/103022 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Add gn_to_bp script for SkQP.Gravatar Derek Sollenberger2018-02-02
| | | | | | | | | | | | This refactors the current gn_to_bp script and moves the common components into a utils class. Both gn_to_bp scripts now also accept an optional param (--gn <gn_path>) to make it easier to run within the Android tree where we don't have the DEPS synced. Change-Id: Idc4de7b3993e63e21a5b7137b1873d82a8e1843e Reviewed-on: https://skia-review.googlesource.com/102184 Commit-Queue: Derek Sollenberger <djsollen@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* SkQP: flatten report imagesGravatar Hal Canary2018-02-02
| | | | | | | Change-Id: If590ceb362b4d2e23da72543f40f6255502c63f4 Reviewed-on: https://skia-review.googlesource.com/102486 Reviewed-by: Stephan Altmueller <stephana@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: skia_skqp_global_error_toleranceGravatar Hal Canary2018-02-01
| | | | | | | Change-Id: I991f6a5a6fde3815cd5487227f22014570cfb5d5 Reviewed-on: https://skia-review.googlesource.com/102681 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: README: note need java8 not other versionGravatar Hal Canary2018-02-01
| | | | | | Change-Id: I4743df622bfbcf75d3335226cc5ea4c63de92762 Reviewed-on: https://skia-review.googlesource.com/102323 Reviewed-by: Hal Canary <halcanary@google.com>
* SkQP: remove model slack, READMEGravatar Hal Canary2018-02-01
| | | | | | | Change-Id: Ifd258ccd633fba11a13ac3ffc92fb684789d3e57 Reviewed-on: https://skia-review.googlesource.com/102205 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: report, use `image-rendering:pixelated`Gravatar Hal Canary2018-01-31
| | | | | | | Change-Id: If0542634b96dd98e0b86407bbfe0a346a0e42cbd Reviewed-on: https://skia-review.googlesource.com/102343 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: report formatting, junit classnameGravatar Hal Canary2018-01-31
| | | | | | | | Change-Id: Ibc5b55c98242c50b62b16134e0a504c04a458f6c Reviewed-on: https://skia-review.googlesource.com/102320 Reviewed-by: Hal Canary <halcanary@google.com> Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: skia_skqp_enable_driver_correctness_workaroundsGravatar Hal Canary2018-01-31
| | | | | | | Change-Id: If61341423ff03efa48814a393f16eaaee02cecbd Reviewed-on: https://skia-review.googlesource.com/102183 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: fix upload/download scriptsGravatar Hal Canary2018-01-30
| | | | | | | Change-Id: If2b2ec786630e1ecea159e0804547a79478138f5 Reviewed-on: https://skia-review.googlesource.com/101844 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: Allow checking against nearby pixel's expectations.Gravatar Hal Canary2018-01-30
| | | | | | | | | Also more verbose logging. Change-Id: Ib2d9e3074d155140f14ab8818a332ce926488b79 Reviewed-on: https://skia-review.googlesource.com/101543 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: remove skia_embed_resources optionGravatar Hal Canary2018-01-30
| | | | | | | | | | Motivation: delete unnecessary code. ResourceFactory.h provides a much more flexible way of fixing the same problem. Change-Id: Ib8a3ce25ce98e4f752dc1e7ce88eb9ceb95a4372 Reviewed-on: https://skia-review.googlesource.com/101920 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: slim deps. Also skia_enable_fontmgr_emptyGravatar Hal Canary2018-01-30
| | | | | | | Change-Id: I24ee2fb3a4a4ca03a60ee2f1a90e022825eee409 Reviewed-on: https://skia-review.googlesource.com/101820 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: error image now opaqueGravatar Hal Canary2018-01-29
| | | | | | | | | Also more explanation in the report. Change-Id: I1d91efb5b5af064d90da5383e4182c8cef197e0c Reviewed-on: https://skia-review.googlesource.com/101541 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: ResourceFactoryGravatar Hal Canary2018-01-29
| | | | | | | Change-Id: Ic57a86ec115e3ace52615c0b8e9a22a915988850 Reviewed-on: https://skia-review.googlesource.com/101320 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: more slackGravatar Hal Canary2018-01-26
| | | | | | | | NOTRY=true Change-Id: Ibc4efe070cb6e1e69f57f34808b277bf0257ce06 Reviewed-on: https://skia-review.googlesource.com/100421 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* SkQP: re-enable workarounds for unit tests. Also, more loggingGravatar Hal Canary2018-01-26
| | | | | | | Change-Id: I74de5477c3cc9a034553363ac525d8f264478153 Reviewed-on: https://skia-review.googlesource.com/99862 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: run_skqp_exe scriptGravatar Hal Canary2018-01-25
| | | | | | Change-Id: I9e3e4994e15856edd86a1f0f0ab91297c325dcca Reviewed-on: https://skia-review.googlesource.com/99662 Reviewed-by: Hal Canary <halcanary@google.com>
* SkQP: Fix errors in README.mdGravatar Hal Canary2018-01-25
| | | | | | | NOTRY=true Change-Id: I5d9e1834adbff72122c825c63345432a324d5856 Reviewed-on: https://skia-review.googlesource.com/99760 Reviewed-by: Hal Canary <halcanary@google.com>
* SkQP: Stop requiring users to use posix shellGravatar Hal Canary2018-01-24
| | | | | | | | | Also update README.md Change-Id: I62f5ac38ff4a8c3aa19d895441a76664cb8e8176 Reviewed-on: https://skia-review.googlesource.com/99302 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: add slack to modelGravatar Hal Canary2018-01-24
| | | | | | | Change-Id: Id14e5d4d6c5d517c29cd09b815ede1b52604d96a Reviewed-on: https://skia-review.googlesource.com/99322 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* SkQP: make report.html smallerGravatar Hal Canary2018-01-24
| | | | | | | Change-Id: Ie43bf83fbd94fdf7edc79cfe403b01474894199d Reviewed-on: https://skia-review.googlesource.com/99280 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>