aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/skdiff_main.cpp
Commit message (Collapse)AuthorAge
* skdiff: clean up isPathAbsolute check for WindowsGravatar epoger@google.com2012-08-08
| | | | | | | This is a followup to https://codereview.appspot.com/6458046/ ('Fix skdiff when using windows path that begins with a drive letter') Review URL: https://codereview.appspot.com/6450106 git-svn-id: http://skia.googlecode.com/svn/trunk@5004 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix skdiff when using windows path that begins with a drive letterGravatar bsalomon@google.com2012-07-30
| | | | | | | Review URL: https://mail.google.com/mail/u/0/?shva=1#inbox/138d92244ca33549 git-svn-id: http://skia.googlecode.com/svn/trunk@4838 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff output: indicate which result types would cause failureGravatar epoger@google.com2012-07-19
| | | | | | Review URL: https://codereview.appspot.com/6419053 git-svn-id: http://skia.googlecode.com/svn/trunk@4676 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff: cap return value at 255 to avoid automatic 'wrapping' (%256) of ↵Gravatar epoger@google.com2012-07-16
| | | | | | | | return value Review URL: https://codereview.appspot.com/6409045 git-svn-id: http://skia.googlecode.com/svn/trunk@4629 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff: replace --failonmismatches with repeatable --failonresult optionGravatar epoger@google.com2012-07-13
| | | | | | Review URL: https://codereview.appspot.com/6392064 git-svn-id: http://skia.googlecode.com/svn/trunk@4611 2bbb7eff-a529-9590-31e7-b0007b416f81
* rename NO_ERROR to kNoError, because Windows defines a NO_ERROR macro elsewhereGravatar epoger@google.com2012-07-12
| | | | | | | TBR=rmistry Review URL: https://codereview.appspot.com/6355100 git-svn-id: http://skia.googlecode.com/svn/trunk@4581 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff: add --failonmismatches and --listfilename options, plus cleanupGravatar epoger@google.com2012-07-12
| | | | | | | These changes are needed in order to switch the buildbots from using "gm -r" to "skdiff" to compare gm results, and should be generally good for humans too. Review URL: https://codereview.appspot.com/6392054 git-svn-id: http://skia.googlecode.com/svn/trunk@4579 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff now has the option to not print out the directories it is using.Gravatar keyar@chromium.org2012-07-09
| | | | | | | | Further, test_pictures.py will call skdiff with this option. Review URL: https://codereview.appspot.com/6347066 git-svn-id: http://skia.googlecode.com/svn/trunk@4497 2bbb7eff-a529-9590-31e7-b0007b416f81
* Improve sorting of skdiff output, and make it consistent across platformsGravatar epoger@google.com2012-06-28
| | | | | | | BUG=https://code.google.com/p/skia/issues/detail?id=677 Review URL: https://codereview.appspot.com/6351045 git-svn-id: http://skia.googlecode.com/svn/trunk@4388 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff: no longer skip .pdf files by defaultGravatar epoger@google.com2012-06-25
| | | | | | Review URL: https://codereview.appspot.com/6257080 git-svn-id: http://skia.googlecode.com/svn/trunk@4330 2bbb7eff-a529-9590-31e7-b0007b416f81
* fix warnings on Mac in miscellaneous filesGravatar caryclark@google.com2012-06-06
| | | | | | | | | | | | | | | | | | Fix these class of warnings: - unused functions - unused locals - sign mismatch - missing function prototypes - missing newline at end of file - 64 to 32 bit truncation The changes prefer to link in dead code in the debug build with 'if (false)' than to comment it out, but trivial cases are commented out or sometimes deleted if it appears to be a copy/paste error. Review URL: https://codereview.appspot.com/6305047 git-svn-id: http://skia.googlecode.com/svn/trunk@4186 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff: return nonzero exit value if there are any mismatchesGravatar epoger@google.com2012-05-31
| | | | | | | This will allow us to replace "gm -r" in our buildbots with "skdiff". This will speed things up, and work around http://code.google.com/p/skia/issues/detail?id=473 ('PDF gradtext gm image results are nondeterministic') Review URL: https://codereview.appspot.com/6242071 git-svn-id: http://skia.googlecode.com/svn/trunk@4097 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff: internally track lists of ALL result types, not just baseMissing and ↵Gravatar epoger@google.com2012-05-31
| | | | | | | | | comparisonMissing This does not change skdiff output at all; verified using tools/tests/run.sh Review URL: https://codereview.appspot.com/6260057 git-svn-id: http://skia.googlecode.com/svn/trunk@4096 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add to skdiff: test images for bitwise equality before testing for ↵Gravatar epoger@google.com2012-05-22
| | | | | | | | | | | | | | | | | | | pixel-wise equality - we now check for bitwise equality of files before bothering with pixel comparisons (this will help with formats for which we don't have good decoders, like PDF) - unparsable files are now reported as differing, unless they are bitwise equal (before, they were always reported as matching!) - "largest area mismatch" is now based on same-size image pairs only; previously, if any image pairs had mismatching size, it was 100% - removed repetitive "image size mismatch, so no diff to display" messages - changed format of leftmost table cells to be more readable BUG=http://code.google.com/p/skia/issues/detail?id=473 Review URL: https://codereview.appspot.com/6208089 git-svn-id: http://skia.googlecode.com/svn/trunk@4027 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove chromium mode from skdiff, because it is no longer actively used.Gravatar epoger@google.com2012-05-18
| | | | | | | | | Ran tools/tests/run.sh to validate this change. TBR=caryclark1 Review URL: https://codereview.appspot.com/6222045 git-svn-id: http://skia.googlecode.com/svn/trunk@4005 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff: only write out diff images that are included in index.htmlGravatar epoger@google.com2012-05-16
| | | | | | | Not only are those files unnecessary, in some different-image-size cases, their contents are nondeterministic! Review URL: https://codereview.appspot.com/6208073 git-svn-id: http://skia.googlecode.com/svn/trunk@3975 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make skdiff use enumeration of result types instead of separate booleans for ↵Gravatar epoger@google.com2012-05-16
| | | | | | | | | | | each result type. This is one step on the way to a more robust version of skdiff that we can use to address http://code.google.com/p/skia/issues/detail?id=473 ('PDF gradtext gm image results are nondeterministic') I have confirmed that skdiff results will not change, using tools/tests/run.sh. Review URL: https://codereview.appspot.com/6208063 git-svn-id: http://skia.googlecode.com/svn/trunk@3972 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add self-test for skdiff, and remove date/time from skdiff output so it passes.Gravatar epoger@google.com2012-05-15
| | | | | | | BUG=http://code.google.com/p/skia/issues/detail?id=612 Review URL: https://codereview.appspot.com/6198074 git-svn-id: http://skia.googlecode.com/svn/trunk@3938 2bbb7eff-a529-9590-31e7-b0007b416f81
* Just use std qsortGravatar reed@google.com2012-05-07
| | | | | | Review URL: https://codereview.appspot.com/6195052 git-svn-id: http://skia.googlecode.com/svn/trunk@3846 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add new flags to skdiffGravatar epoger@google.com2012-05-01
| | | | | | | | | | | | | | New flags are: --nodiffs: don't write out image diffs or index.html, just generate report on stdout --match: compare files whose filenames contain this substring; if unspecified, compare ALL files this flag may be repeated to add more matching substrings --nomatch: regardless of --match, DO NOT compare files whose filenames contain this substring this flag may be repeated to add more forbidden substrings Also implemented the --threshold flag, which was already documented but not implemented. Review URL: https://codereview.appspot.com/6135045 git-svn-id: http://skia.googlecode.com/svn/trunk@3806 2bbb7eff-a529-9590-31e7-b0007b416f81
* If skdiff encounters image size mismatch, do not display diff imagesGravatar epoger@google.com2012-04-12
| | | | | | | Currently, if skdiff encounters images whose expected and actual dimensions do not match, it will attempt (incorrectly) to display diffs. Better to not display the diffs at all than to display misleading diffs... Review URL: https://codereview.appspot.com/6015049 git-svn-id: http://skia.googlecode.com/svn/trunk@3662 2bbb7eff-a529-9590-31e7-b0007b416f81
* landing patch from http://codereview.appspot.com/5874051/Gravatar epoger@google.com2012-03-22
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@3468 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make skdiff always generate white diffs alongside actual pixel diffsGravatar epoger@google.com2012-02-02
| | | | | | | (and some associated improvement to the output) Review URL: https://codereview.appspot.com/5616059 git-svn-id: http://skia.googlecode.com/svn/trunk@3138 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make skdiff robust to image size differences: if the two image sizes differ,Gravatar tomhudson@google.com2011-11-30
| | | | | | | | | report that fact explicitly, record 100% pixel difference, and don't try to generate a valid delta image. git-svn-id: http://skia.googlecode.com/svn/trunk@2767 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix more VS2010 warnings.Gravatar bsalomon@google.com2011-10-07
| | | | | | | | Review URL: http://codereview.appspot.com/5169053/ git-svn-id: http://skia.googlecode.com/svn/trunk@2432 2bbb7eff-a529-9590-31e7-b0007b416f81
* Make skdiff paths work on windowsGravatar bsalomon@google.com2011-09-23
| | | | | | | | http://codereview.appspot.com/5111041/ git-svn-id: http://skia.googlecode.com/svn/trunk@2321 2bbb7eff-a529-9590-31e7-b0007b416f81
* Move SkBitmap members of the skdiff DiffRecord to pointers so that theyGravatar tomhudson@google.com2011-08-02
| | | | | | | | | can be deleted as soon as they're written. When we're running in --chromium mode we now have much larger datasets. git-svn-id: http://skia.googlecode.com/svn/trunk@2025 2bbb7eff-a529-9590-31e7-b0007b416f81
* Automatic update of all copyright notices to reflect new license terms.Gravatar epoger@google.com2011-07-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have manually examined all of these diffs and restored a few files that seem to require manual adjustment. The following files still need to be modified manually, in a separate CL: android_sample/SampleApp/AndroidManifest.xml android_sample/SampleApp/res/layout/layout.xml android_sample/SampleApp/res/menu/sample.xml android_sample/SampleApp/res/values/strings.xml android_sample/SampleApp/src/com/skia/sampleapp/SampleApp.java android_sample/SampleApp/src/com/skia/sampleapp/SampleView.java experimental/CiCarbonSampleMain.c experimental/CocoaDebugger/main.m experimental/FileReaderApp/main.m experimental/SimpleCocoaApp/main.m experimental/iOSSampleApp/Shared/SkAlertPrompt.h experimental/iOSSampleApp/Shared/SkAlertPrompt.m experimental/iOSSampleApp/SkiOSSampleApp-Base.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Debug.xcconfig experimental/iOSSampleApp/SkiOSSampleApp-Release.xcconfig gpu/src/android/GrGLDefaultInterface_android.cpp gyp/common.gypi gyp_skia include/ports/SkHarfBuzzFont.h include/views/SkOSWindow_wxwidgets.h make.bat make.py src/opts/memset.arm.S src/opts/memset16_neon.S src/opts/memset32_neon.S src/opts/opts_check_arm.cpp src/ports/SkDebug_brew.cpp src/ports/SkMemory_brew.cpp src/ports/SkOSFile_brew.cpp src/ports/SkXMLParser_empty.cpp src/utils/ios/SkImageDecoder_iOS.mm src/utils/ios/SkOSFile_iOS.mm src/utils/ios/SkStream_NSData.mm tests/FillPathTest.cpp Review URL: http://codereview.appspot.com/4816058 git-svn-id: http://skia.googlecode.com/svn/trunk@1982 2bbb7eff-a529-9590-31e7-b0007b416f81
* Extends skdiff to handle commands of the formGravatar tomhudson@google.com2011-07-14
| | | | | | | | | | | | | | | | | | | | skdiff --chromium-release baseDir outputDir skdiff --chromium-debug baseDir outputDir where baseDir is typically ../chromium/src. Handles Chromium/WebKit layout tests: recursively traverses the layout-test-results directory and compares -expected and -actual PNGs, building a webpage showing the two images, their difference image, and statistics, sorted by % of pixels difference. Respects all the standard skdiff flags. Also changes command line options named with words from starting with a single hyphen to starting with two, falling in line with standards: --threshold, --sortbymismatch, etc. git-svn-id: http://skia.googlecode.com/svn/trunk@1856 2bbb7eff-a529-9590-31e7-b0007b416f81
* In skdiff, merge paths into the struct that holds the filename, to enableGravatar tomhudson@google.com2011-07-13
| | | | | | | | | 1. better support reading from multiple input directories, and 2. allow filenames to differ between reference and novel images. git-svn-id: http://skia.googlecode.com/svn/trunk@1848 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix signed/unsigned mismatch in rev 1553.Gravatar tomhudson@google.com2011-06-09
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@1558 2bbb7eff-a529-9590-31e7-b0007b416f81
* skdiff usability improvements: summary to stdout, -diff in output filenames,Gravatar tomhudson@google.com2011-06-09
| | | | | | | | | | better statistics on HTML page when using -white, output directory name is optional. codereview.appspot.com/4590048/ git-svn-id: http://skia.googlecode.com/svn/trunk@1553 2bbb7eff-a529-9590-31e7-b0007b416f81
* Stores index.html in the output (diff) directory rather than in the currentGravatar tomhudson@google.com2011-05-24
| | | | | | | | | | | | | working directory. Skips PDFs since we have no way to compare them. Includes prototype of --weighted option to scale percent different metric by intensity of difference at each pixel. (qv http://codereview.appspot.com/4557042/) git-svn-id: http://skia.googlecode.com/svn/trunk@1411 2bbb7eff-a529-9590-31e7-b0007b416f81
* New 'skdiff' tool to compare two directories full of files, write diff imagesGravatar tomhudson@google.com2011-04-27
into a third directory, and create a summary web page with metrics for easy inspection of the results. git-svn-id: http://skia.googlecode.com/svn/trunk@1200 2bbb7eff-a529-9590-31e7-b0007b416f81