aboutsummaryrefslogtreecommitdiffhomepage
path: root/third_party
Commit message (Collapse)AuthorAge
* GN: refactor third_party/gniGravatar mtklein2016-07-19
| | | | | | | | | | | | | | | | | | This fixes the build on Linux (dep on third_party:zlib -> third_party/zlib). I've moved declare_args() {} back to each .gn file... seems like args want to be as local as possible in GN land. Additionally, refactor all the common third_party config and warning flag changes into a template, third_party. This lets it all live together in a .gni: at head unwanted_configs can be in a .gni (it's just a variable) but config("no_warnings") (and thus third_party_configs) cannot, as configs cannot be part of .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163653002 Review-Url: https://codereview.chromium.org/2163653002
* Add support for FuchsiaGravatar abarth2016-07-15
| | | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152273002 [mtklein edit from here down] No public API changes. TBR=reed@google.com Review-Url: https://codereview.chromium.org/2152273002
* GNGravatar mtklein2016-06-23
| | | | | | | | | | | | | | | | | | | | | | | | | | What we've got here is a little GN MVP. It's lacking any knobs and doesn't yet build anything but libskia, zlib, libpng, and libjpeg-turbo. I've been hopping back and forth between Linux at work and Mac at home. These seem to be at least partially working, enough to build and run cmake/example.cpp. The xcode backend seems to work. From here, we can start exploring how to handle other backends (cmake,Android make, Google3). There are a couple things I want to try: - add another backend like vs or xcode to GN directly - intercept via a custom toolchain - reverse from ninja -t commands That last option seems kind of fun. This tries to piggyback on Chrome's GN setup as much as possible. Chrome's got quite a lot figured out, and we're basically required to do this if we want to have a single GN build system shareable by Chrome, our bots, and other clients. This pulls in some new DEPS: - build: Chrome's GN configuration, and much more - buildtools: hashes for gn binary, pulled via hooks - tools/clang: hashes for Chrome's clang, pulled via hooks into third_party/llvm-build It additionally symlinks tools/gyp to third_party/externals/gyp. GN pulls some stuff from tools/gyp on Mac. Have not yet tried building for Windows, Android, or iOS. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087593002 Committed: https://skia.googlesource.com/skia/+/1d8de594f126b9a80bd8f8fa2005e90faf3b5b17 Review-Url: https://codereview.chromium.org/2087593002
* Revert of GN (patchset #12 id:220001 of ↵Gravatar mtklein2016-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2087593002/ ) Reason for revert: gclient not happy on some bots Original issue's description: > GN > > What we've got here is a little GN MVP. It's lacking any knobs and doesn't yet build anything but libskia, zlib, libpng, and libjpeg-turbo. I've been hopping back and forth between Linux at work and Mac at home. These seem to be at least partially working, enough to build and run cmake/example.cpp. > > The xcode backend seems to work. From here, we can start exploring how to handle other backends (cmake,Android make, Google3). There are a couple things I want to try: > - add another backend like vs or xcode to GN directly > - intercept via a custom toolchain > - reverse from ninja -t commands > That last option seems kind of fun. > > This tries to piggyback on Chrome's GN setup as much as possible. Chrome's got quite a lot figured out, and we're basically required to do this if we want to have a single GN build system shareable by Chrome, our bots, and other clients. > > This pulls in some new DEPS: > - build: Chrome's GN configuration, and much more > - buildtools: hashes for gn binary, pulled via hooks > - tools/clang: hashes for Chrome's clang, pulled via hooks into third_party/llvm-build > It additionally symlinks tools/gyp to third_party/externals/gyp. GN pulls some stuff from tools/gyp on Mac. > > Have not yet tried building for Windows, Android, or iOS. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087593002 > > Committed: https://skia.googlesource.com/skia/+/1d8de594f126b9a80bd8f8fa2005e90faf3b5b17 TBR=bsalomon@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2088253002
* GNGravatar mtklein2016-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | What we've got here is a little GN MVP. It's lacking any knobs and doesn't yet build anything but libskia, zlib, libpng, and libjpeg-turbo. I've been hopping back and forth between Linux at work and Mac at home. These seem to be at least partially working, enough to build and run cmake/example.cpp. The xcode backend seems to work. From here, we can start exploring how to handle other backends (cmake,Android make, Google3). There are a couple things I want to try: - add another backend like vs or xcode to GN directly - intercept via a custom toolchain - reverse from ninja -t commands That last option seems kind of fun. This tries to piggyback on Chrome's GN setup as much as possible. Chrome's got quite a lot figured out, and we're basically required to do this if we want to have a single GN build system shareable by Chrome, our bots, and other clients. This pulls in some new DEPS: - build: Chrome's GN configuration, and much more - buildtools: hashes for gn binary, pulled via hooks - tools/clang: hashes for Chrome's clang, pulled via hooks into third_party/llvm-build It additionally symlinks tools/gyp to third_party/externals/gyp. GN pulls some stuff from tools/gyp on Mac. Have not yet tried building for Windows, Android, or iOS. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087593002 Review-Url: https://codereview.chromium.org/2087593002
* Prefix png functionsGravatar scroggo2016-06-06
| | | | | | | | | This way multiple copies of libpng can coexist. Update libpng's README.google GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2046603002 Review-Url: https://codereview.chromium.org/2046603002
* Update pnglibconf.hGravatar scroggo2016-06-06
| | | | | | | | | | It should have been updated when we updated the version. Update README.google to better reflect the difference from the original file. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2042833002 Review-Url: https://codereview.chromium.org/2042833002
* Fix undefined behavior in libpngGravatar scroggo2016-06-03
| | | | | | | | | Check for a null source before calling memcpy. BUG=skia:5390 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2040433002 Review-Url: https://codereview.chromium.org/2040433002
* Check libpng directly into third_party/Gravatar scroggo2016-06-02
| | | | | | | | | | | | | | | | | | | With this change, the CMake build, which does not use DEPS to sync external projects, is able to build and use the same version of libpng that is used in other builds. This will allow all platforms (including Google3 CMake build) to test on the same version of libpng, so we do not need to make SkPngCodec support all versions of libpng. - Update CMakeLists.txt to use the checked in libpng. - Check in libpng version 1.6.22rc01 - Update README.google - Replace our old LICENSE file with the latest one from libpng GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2033063003 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review-Url: https://codereview.chromium.org/2033063003
* Add exact version of qcms used by Chrome for testing and comparisonGravatar msarett2016-05-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2014023003 Review-Url: https://codereview.chromium.org/2014023003
* Update libpng to 1.6.22rc01Gravatar msarett2016-05-17
| | | | | | | | | | | | If there are no issues, this version will be released May 26. Let's start testing with it, so we are ready to update Chrome when it is available. BUG=skia:4710 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1983853002 Review-Url: https://codereview.chromium.org/1983853002
* Start building HarfBuzz+Skia exampleGravatar halcanary2016-05-03
| | | | | | | | | | | | | | (prevent bitrot in example code) tools/using_skia_and_harfbuzz.cpp was written by aam@: https://github.com/aam/skiaex update HarfBuzz to latest release: 1.2.7 BUG=skia:4742 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1940393002 Review-Url: https://codereview.chromium.org/1940393002
* Make is_ktx saferGravatar scroggo2016-04-12
| | | | | | | | | | | | Rather than assuming the data passed to ktx at least KTX_FILE_IDENTIFIER_SIZE, pass the length of the data to is_ktx and compare it. Splitting off from crrev.com/1862133002, which no longer depends on is_ktx. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1882593002 Review URL: https://codereview.chromium.org/1882593002
* Style bikeshed - remove extraneous whitespaceGravatar halcanary2016-03-29
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1842753002 Review URL: https://codereview.chromium.org/1842753002
* Create explicit microhttpd.gypGravatar joshualitt2016-03-09
| | | | | | | Committed: https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1779903002 Review URL: https://codereview.chromium.org/1779903002
* Revert of Create explicit microhttpd.gyp (patchset #6 id:100001 of ↵Gravatar joshualitt2016-03-09
| | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1779903002/ ) Reason for revert: breaking per commit housekeeper Original issue's description: > Create explicit microhttpd.gyp > > Committed: https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8 TBR=bungeman@google.com,jcgregorio@google.com,ethannicholas@google.com,joshualitt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1781853002
* Create explicit microhttpd.gypGravatar joshualitt2016-03-09
| | | | Review URL: https://codereview.chromium.org/1779903002
* Add SkDrawPosTextHCommand JSON, fix skiaserve build.Gravatar bungeman2016-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds SkDrawPosTextHCommand ::fromJSON and ::toJSON. Both SkDrawPosTextCommand and SkDrawPosTextHCommand's ::toJSON write the correct number of positions, preventing reading uninitialized memory. The microhttpd build is now done in the build tree as opposed to in a temporary directory. The microhttpd build script uses os.path.join so that absolute paths do not confuse the build. This allows compatibility with the cmake gyp generator as CMake likes to pass absolute paths. The microhttpd gyp target is now marked as 'none' since it is not a 'static_library' target (which directs gyp to compile sources into a static library). The dependencies to the action are updated to the minimum required for sane re-building. The everything gyp target now depends on the skiaserve gyp target. This means that when using skia_build_server=1, building 'most' will build skiaserve, but when skia_build_server is not defined the skiaserve target will still be available if specified manually. The old json.gyp is removed as it currently does not build anything. All of the files currently referenced by it as sources no longer exist. Review URL: https://codereview.chromium.org/1775203002
* Use installed vulkan SDK and remove checked in SDKGravatar bsalomon2016-03-03
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1761643002 Review URL: https://codereview.chromium.org/1761643002
* Pull and build shaderc rather than use checked in lib/headerGravatar bsalomon2016-03-03
| | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760493003 Committed: https://skia.googlesource.com/skia/+/7d4490ecfa4d974003f675ef004e77f85ecfadd2 Review URL: https://codereview.chromium.org/1760493003
* Revert "Pull and build shaderc rather than use checked in lib/header"Gravatar Eric Boren2016-03-03
| | | | | | | | | This reverts commit 7d4490ecfa4d974003f675ef004e77f85ecfadd2. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757253002 Review URL: https://codereview.chromium.org/1757253002 .
* Pull and build shaderc rather than use checked in lib/headerGravatar bsalomon2016-03-02
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1760493003 Review URL: https://codereview.chromium.org/1760493003
* Update shaderc lib and use single combined libGravatar Greg Daniel2016-02-25
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1737653002 R=jvanverth@google.com Review URL: https://codereview.chromium.org/1737653002
* Add vulkan files into skia repo. This is an incomplete backend with only ↵Gravatar Greg Daniel2016-02-22
| | | | | | | | | | | | | | partial functionality at this time. R=robertphillips@google.com TBR=bsalomon@google.com BUG=skia:4955 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002 Committed: https://skia.googlesource.com/skia/+/48cf268defad66f58f1aa03b4835e5583be96b2f Review URL: https://codereview.chromium.org/1718693002
* Revert of Add vulkan files into skia repo. (patchset #2 id:20001 of ↵Gravatar egdaniel2016-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1718693002/ ) Reason for revert: breaking builds Original issue's description: > Add vulkan files into skia repo. This is an incomplete backend with only partial functionality at this time. > > R=robertphillips@google.com > TBR=bsalomon@google.com > > BUG=skia:4955 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002 > > Committed: https://skia.googlesource.com/skia/+/48cf268defad66f58f1aa03b4835e5583be96b2f TBR=robertphillips@google.com,bsalomon@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4955 Review URL: https://codereview.chromium.org/1723503002
* Add vulkan files into skia repo. This is an incomplete backend with only ↵Gravatar Greg Daniel2016-02-22
| | | | | | | | | | | | partial functionality at this time. R=robertphillips@google.com TBR=bsalomon@google.com BUG=skia:4955 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1718693002 Review URL: https://codereview.chromium.org/1718693002
* Update libpng to 1.6.22betaGravatar msarett2016-02-19
| | | | | | | | | | Intel SSE filter optimizations have been upstreamed. Let's test on the upstream version (which we can use in Android). BUG=skia:4573 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1710083007 Review URL: https://codereview.chromium.org/1710083007
* Update the version of libpng used by Skia testsGravatar scroggo2016-02-19
| | | | | | | | | | | | | | | | | | | | The version of libpng we were using has some security vulnerabilities. Update to a newer version - 1.6.20 (http://sourceforge.net/p/libpng/code/ci/047737496a77eeb97f9991919dac08ca3c149711/). Update pnglibconf.h. The new version is a copy of the newer version of the file, with our /* custom settings */ tacked onto the end. (The custom settings are unchanged from the last version.) Update the LICENSE. The new version is a copy of the LICENSE that libpng now includes as a separate file. Update the README file to reflect the change in source of the LICENSE file. BUG=skia:4573 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1453373003 Review URL: https://codereview.chromium.org/1453373003
* sketch hooking into PNG_FILTER_OPTIMIZATIONSGravatar mtklein2016-01-27
| | | | | | | | | | | | | | | | | | | | | | | | | | Local timing says this 4-byte Paeth function takes about 0.3x the time the serial libpng code does, dropping from ~10 cycles per byte to ~2.9. bpp=4 is mainly an easy demo. This approach can work for any bpp up to 16, 1 pixel at a time, at roughly the same cost per pixel. Doing more than 1 pixel at a time is a tricky math problem I have yet to attempt to solve. Everything here can be trivially downgraded to MMX, supporting bpp up to 8. It seems to be a little slower (~3.5 cycles per byte), but it would make the code compatible with every x86 that can still power on. I've tried four approaches: - this way; - doing things naively in 16-bit; - a 16-bit version that requires division by 3 (i.e. mulhi_epu16(..., 0x5580) ); - a mostly 8-bit version of the same. They're all fine, but this one is consistently the fastest I've measured. I'd be happy to settle on the naive 16-bit version too, which would have a very clear implementation that's only minorly slower than this version. The other two are way more complicated, and would require us to draw some serious ASCII diagrams to explain. I have learned that the .skp serialization tests (serialize-8888) have a nice side effect of testing the correctness of these filters! (Since writing the description above, I've bumped things up to {Paeth,Sub,Avg} x { 3 bpp, 4 bpp }.) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1573943002 Review URL: https://codereview.chromium.org/1573943002
* Build and link microhttpd from gypGravatar joshualitt2016-01-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1628363002 Review URL: https://codereview.chromium.org/1628363002
* Disable ES2 on Linux SDLGravatar joshualitt2015-12-28
| | | | | | | | TBR=borenet@google.com BUG=skia:4737 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1550123002 Review URL: https://codereview.chromium.org/1550123002
* Remove EGL_config from vb botGravatar joshualitt2015-12-18
| | | | | | | | | TBR=borenet@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1540583003 Review URL: https://codereview.chromium.org/1540583003
* Generate a table of config->glformat info. Precursor to lifting this to caps.Gravatar bsalomon2015-12-16
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1527383003 Review URL: https://codereview.chromium.org/1527383003
* bring up SDL on windowsGravatar joshualitt2015-11-11
| | | | | | | | BUG=skia: patch from issue 1432353002 at patchset 1 (http://crrev.com/1432353002#ps1) Review URL: https://codereview.chromium.org/1438003004
* Wire up SDL on macGravatar joshualitt2015-11-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1428633003
* Comments Style: s/skbug.com/bug.skia.org/Gravatar halcanary2015-11-07
| | | | | | DOCS_PREVIEW= https://skia.org/?cl=1432503003 Review URL: https://codereview.chromium.org/1432503003
* Fix the build on Android devicesGravatar Matt Sarett2015-11-06
|
* Wire up SDL on AndroidGravatar joshualitt2015-11-05
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/a4d3797c3b0f0cac8493c46cb334ca88a5d6ccf6 Review URL: https://codereview.chromium.org/1415453009
* Revert of Wire up SDL on Android (patchset #4 id:60001 of ↵Gravatar joshualitt2015-11-05
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1415453009/ ) Reason for revert: breaks appurify Original issue's description: > Wire up SDL on Android > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/a4d3797c3b0f0cac8493c46cb334ca88a5d6ccf6 TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1410703009
* Wire up SDL on AndroidGravatar joshualitt2015-11-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1415453009
* Create SDL backed SkOSWindowGravatar joshualitt2015-11-04
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1413593007
* Initial gyp files for SDLGravatar joshualitt2015-10-29
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1411033003
* Update Android FreeType version.Gravatar bungeman2015-10-27
| | | | | | | | | | | | | | | | Update FreeType to a newer version. Because this caused issues in finding the correct ftoptions.h and ftmodule.h [1], be sure to state the ones we want explicitly. This also add gzip.c which is needed for WOFF support [2]. [1] FreeType "Simplify header file hierarchy." fae382076409db198dfbff36ac4cbb97b05b30a1 [2] FreeType "[gzip] New function `FT_Gzip_Uncompress'." dc240524ff31891a442225430b28e9620c1fa89f Review URL: https://codereview.chromium.org/833103004
* Revert of Depend on ETC1 via DEPS instead of a direct third_party checkin. ↵Gravatar mtklein2015-08-17
| | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1296253003/ ) Reason for revert: This will make the google3 roll awkward. Reverting. Original issue's description: > Depend on ETC1 via DEPS instead of a direct third_party checkin. > > Yes, this does mean we'll check out ~40M of code for 2 files... > > I think these trybots are moot... they gclient sync before patching. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ca01d179347b5e848ded97c8228b79ffc6b5e7bf TBR=robertphillips@google.com,djsollen@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1290913008
* Depend on ETC1 via DEPS instead of a direct third_party checkin.Gravatar mtklein2015-08-17
| | | | | | | | | | Yes, this does mean we'll check out ~40M of code for 2 files... I think these trybots are moot... they gclient sync before patching. BUG=skia: Review URL: https://codereview.chromium.org/1296253003
* Fix webp compile warnings on windowsGravatar msarett2015-08-17
| | | | | | | | | | | | | | This fix was landed with: https://codereview.chromium.org/1280073002/ The above CL was reverted due to an unrelated bug in libwebp. The above CL contains multiple components, and I think that reverting this part of the change was unintentional. BUG=skia: Review URL: https://codereview.chromium.org/1286903003
* Revert of Update libwebp and resume testing scaled webp (patchset #2 ↵Gravatar scroggo2015-08-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/1280073002/ ) Reason for revert: Compile failures, e.g. http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android_NoNeon/builds/1427/steps/build%20most/logs/stdio Original issue's description: > Update libwebp and resume testing scaled webp > > libwebp has a fix for [1]. Update to the commit that contains the fix. > > Update libwebp.gypi, corresponding to libwebp's latest makefile. > > Turn back on DM testing for scaled webp, now that it should no longer > use uninitialized memory. > > Fix a warning in config.h > > [1] https://code.google.com/p/webp/issues/detail?id=254 > > BUG=skia:4038 > > Committed: https://skia.googlesource.com/skia/+/0575d3e6c272744a66ab3281f9871366717df339 TBR=djsollen@google.com,msarett@google.com,scroggo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4038 Review URL: https://codereview.chromium.org/1278173004
* Update libwebp and resume testing scaled webpGravatar scroggo2015-08-07
| | | | | | | | | | | | | | | | | libwebp has a fix for [1]. Update to the commit that contains the fix. Update libwebp.gypi, corresponding to libwebp's latest makefile. Turn back on DM testing for scaled webp, now that it should no longer use uninitialized memory. Fix a warning in config.h [1] https://code.google.com/p/webp/issues/detail?id=254 BUG=skia:4038 Review URL: https://codereview.chromium.org/1280073002
* Reenable yasm for Android x86 and x86-64 on Linux hostGravatar msarett2015-07-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It turns out that gyp (kind of) has support for cross compiling with a different host and target. We simply need to specify CC_host and CC_target instead of CC. Making this change allows us to compile yasm on a Linux host for Android. We run into problems on Mac because the linker on a Mac host requires different command line arguments than the linker on the Android target. In looking through the code for gyp itself and speaking to Ben, it doesn't appear to me that gyp supports passing different arguments to host and target linkers. I would imagine that we would have similar problems on Windows. Below is a link to a CL that would fix this issue in gyp. It looks like it has been dropped for a long time. Thanks to Ben for this link! https://chromiumcodereview.appspot.com/10795044/ Also I'm adding a link to the build instructions for Chrome (thanks again Ben). It looks like they only support building for Android from Linux. https://code.google.com/p/chromium/wiki/AndroidBuildInstructions My next steps are: 1) Getting in touch with Torne or someone else with gyp to see if people are aware of this issue or interested in fixing it. 2) Deciding if skia should care about this issue. 3) Deciding if skia should work around this issue. It'd be really great to hear your thoughts on (2) and (3). My first thought is that we shouldn't care because, as long as we always compile the production copy of skia for Android on Linux, we will get the fast code. Is this a valid conclusion? Is there a way to write Android apps on Mac that accidentally use the slower code? If we do care, there are workarounds: For Mac, we can check in a yasm binary - it's a little smaller than the one I am deleting in this CL :-/ For Windows, we *might* be able to use the yasm.exe binary already in externals (we get this from DEPS because this is how chromium uses yasm on Windows). Are there other platforms that we care about? Let me know what you think! BUG=skia:4028 DOCS_PREVIEW= https://skia.org/?cl=1239333002 Review URL: https://codereview.chromium.org/1239333002
* Use the upstream version of libwebp, v0.4.3.Gravatar scroggo2015-07-10
| | | | | | | | | | | | | | | | | | | DEPS: Update to pull v0.4.3 of libwebp from upstream gyp/libwebp.gyp: Add new files, as referenced by the gyp file used by Chromium. resource/tests: Add regression tests for particular images. BUG=skia:3442 BUG=skia:3315 BUG=skia:3429 Committed: https://skia.googlesource.com/skia/+/3aa0fb4d80c76b559ff4b82d5e569993aea06da1 Review URL: https://codereview.chromium.org/1178013008
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-18 13:22:49 +0000