aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* move some public headers into privateGravatar reed2015-08-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1289483002
* Make initBatchTracker private, move towards pipeline on batchGravatar bsalomon2015-08-10
| | | | Review URL: https://codereview.chromium.org/1282893002
* Sk4px blit mask.Gravatar mtklein2015-08-10
| | | | | | | | | | | | | | | | Local SKP nanobenching ranges SSE between 1.05x and 0.87x, much more heavily weighted toward <1.0x ratios (speedups). I profiled the top five regressions (1.05x-1.01x) and they look like noise. Will follow up after broad bot results. NEON looks similar but less extreme than SSE changes, ranging between 1.02x and 0.95x, again mostly speedups in 0.99x-0.97x range. The old code trifurcated into black, opaque-but-not-black, and general versions as a function of the constant src color. I did not see a significant difference between general and opaque-but-not-black, and I don't think a black version would be faster using SIMD. So we have here just one version of the code, the general version. Somewhat fantastically, I see no pixel diffs on GMs or SKPs. I will be following up with more CLs for the other procs called by SkBlitMask. BUG=skia: Review URL: https://codereview.chromium.org/1278253003
* Remove GrPipelineOptimizations member from GrPipelineGravatar bsalomon2015-08-10
| | | | Review URL: https://codereview.chromium.org/1275003004
* trivial CL to add drawBatch to GrDrawContextGravatar joshualitt2015-08-10
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1282883002
* Expand functionality of GrRectBatchFactory with AARectsGravatar joshualitt2015-08-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1279303002
* Fix to call SkDelete_array instead of SkDelete to fix ASAN error.Gravatar egdaniel2015-08-10
| | | | | | | | TBR=mtklein@google.com BUG=skia: Review URL: https://codereview.chromium.org/1282333002
* Revert of [TextBlob] Fall back to TightRunBounds when the font bounds are ↵Gravatar egdaniel2015-08-10
| | | | | | | | | | | | | | | | | | | | | | | | | | empty (patchset #1 id:1 of https://codereview.chromium.org/1284693002/ ) Reason for revert: Breaking DEPS roll on Assert in SkTextBlobBuilder::TightRunBounds. Original issue's description: > [TextBlob] Fall back to TightRunBounds when the font bounds are empty > > Empty font bounds are likely an indication of a font bug. As a best > effort, we can use TightRunBounds in this easily detectable case. > > BUG=507022 > R=reed@google.com,bungeman@google.com > > Committed: https://skia.googlesource.com/skia/+/d6b99cc6b84b3ec864221cbe9945d203bd9eb072 TBR=bungeman@google.com,reed@google.com,fmalita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507022 Review URL: https://codereview.chromium.org/1283853002
* Rename GrPipelineInfo to GrPipelineOptimizationsGravatar bsalomon2015-08-10
| | | | | | TBR=joshualitt@google.com Review URL: https://codereview.chromium.org/1274513005
* Move GrStrokeRectBatch creation to behind factoryGravatar joshualitt2015-08-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1282283002
* Create GrRectBatchFactoryGravatar joshualitt2015-08-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1287433003
* This is a speculative fix for the crash on IOSGravatar egdaniel2015-08-10
| | | | | | TBR=mtklein Review URL: https://codereview.chromium.org/1277433005
* [TextBlob] Fall back to TightRunBounds when the font bounds are emptyGravatar fmalita2015-08-10
| | | | | | | | | | Empty font bounds are likely an indication of a font bug. As a best effort, we can use TightRunBounds in this easily detectable case. BUG=507022 R=reed@google.com,bungeman@google.com Review URL: https://codereview.chromium.org/1284693002
* move Stroke Rect and AAFill Rect to their own fileGravatar joshualitt2015-08-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1282723004
* SkPDF: add assert for that SkWStream behaves.Gravatar halcanary2015-08-10
| | | | | | | | Motivation: this might catch future issues like this. BUG=skia:4181 Review URL: https://codereview.chromium.org/1287443002
* Use a factory function to create GrPipeline and remove unused memberGravatar bsalomon2015-08-10
| | | | Review URL: https://codereview.chromium.org/1273803004
* Wire up testcreate function for GrDrawAtlasBatchGravatar joshualitt2015-08-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1285593002
* Remove an unused function.Gravatar thakis2015-08-10
| | | | | | BUG=chromium:505316 Review URL: https://codereview.chromium.org/1282143002
* remove unneeded _DRAWIMAGERECT flagsGravatar reed2015-08-07
| | | | | | | BUG=skia: TBR= Review URL: https://codereview.chromium.org/1281123002
* fixup precision with configurable atlasGravatar joshualitt2015-08-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1276383003
* GrDrawVertices to batchesGravatar joshualitt2015-08-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1276333004
* Move GrDrawAtlasBatch to separate fileGravatar jvanverth2015-08-07
| | | | | | Committed: https://skia.googlesource.com/skia/+/b091c44c33edbad3466601b29d60bc2eaa4453fa Review URL: https://codereview.chromium.org/1274013003
* Revert of Move GrDrawAtlasBatch to separate file (patchset #1 id:1 of ↵Gravatar jvanverth2015-08-07
| | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1274013003/ ) Reason for revert: Build failures Original issue's description: > Move GrDrawAtlasBatch to separate file > > Committed: https://skia.googlesource.com/skia/+/b091c44c33edbad3466601b29d60bc2eaa4453fa TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1276173003
* Move GrDrawAtlasBatch to separate fileGravatar jvanverth2015-08-07
| | | | Review URL: https://codereview.chromium.org/1274013003
* Make folder for batchesGravatar joshualitt2015-08-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1277233002
* First pass at drawAtlas batching.Gravatar jvanverth2015-08-07
| | | | | | | | | | Moves drawAtlas setup into its own method in GrDrawContext, and adds DrawAtlasBatch. Uses pre-built index buffer for quads. TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1277933003
* Break LCD and Bitmap text dependency on hardcoded atlas valuesGravatar joshualitt2015-08-07
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/846b022f6b469cfde285372f26e0d5c593d122ac Review URL: https://codereview.chromium.org/1271873002
* The compiler can generate smulbb perfectly well nowadays.Gravatar mtklein2015-08-07
| | | | | | BUG=skia:4117 Review URL: https://codereview.chromium.org/1273203002
* Add Batch loggingGravatar joshualitt2015-08-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1276913002
* This iOS crash makes little sense to me. Add some debugging.Gravatar mtklein2015-08-07
| | | | | | | | | | | | We called new float[...]. The pointer returned should be aligned for float writes. See https://uberchromegw.corp.google.com/i/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release BUG=skia: Committed: https://skia.googlesource.com/skia/+/30e4d75c3aebf49b179c265a91adbb6012970d2b Review URL: https://codereview.chromium.org/1270403006
* This iOS crash makes little sense to me. Add some debugging.Gravatar mtklein2015-08-07
| | | | | | | | | | We called new float[...]. The pointer returned should be aligned for float writes. See https://uberchromegw.corp.google.com/i/client.skia/builders/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release BUG=skia: Review URL: https://codereview.chromium.org/1270403006
* Fix warnings on VS2015 x86_64 buildGravatar bsalomon2015-08-06
| | | | | | TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1276133002
* Split SkBmpCodec into three separate classesGravatar msarett2015-08-06
| | | | | | | | | | | | | | Will regress behavior on gold on test32bfv4.bmp, where we will no longer fix transparent decodes. TODO: Start fixing transparent decodes again, or decide that we don't want to fix them and remove isTransparent from SkSwizzler. I think this may become more clear when I start implementing the scanline decoder. BUG=skia: Review URL: https://codereview.chromium.org/1258863008
* Let SkWebpCodec decode to 565Gravatar scroggo2015-08-06
| | | | | | BUG=skia:3257 Review URL: https://codereview.chromium.org/1277893002
* Plug a leak in GrTestUtils.Gravatar senorblanco2015-08-06
| | | | | | TBR=mtklein,bsalomon Review URL: https://codereview.chromium.org/1274963003
* Purge non-NEON ARM code.Gravatar mtklein2015-08-06
| | | | | | | | As I begin to wade in here, it's nice to remove as much code as possible. BUG=skia:4117 Review URL: https://codereview.chromium.org/1277953002
* Move some work from backend onClear to base class clearGravatar egdaniel2015-08-06
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1275543005
* Implement caching of stroked paths in the tessellating path renderer.Gravatar senorblanco2015-08-06
| | | | | | | | | | | This requires adding the stroke info to the cache key, and doing the stroking and dashing before rendering as triangles. BUG=skia:3755 Committed: https://skia.googlesource.com/skia/+/29e0d3f267a03546f236023347cdb4595ece2fd1 Review URL: https://codereview.chromium.org/1275553002
* flag to use const& instead of const* for src-rectGravatar reed2015-08-06
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1272713005
* Don't pass pipeline to GrBatch::generateGeometry()Gravatar bsalomon2015-08-06
| | | | | | R=joshualitt@google.com Review URL: https://codereview.chromium.org/1275083002
* Another small fix for reorderingGravatar joshualitt2015-08-06
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1274763008
* Port SkTextureCompression opts to SkOptsGravatar mtklein2015-08-06
| | | | | | | | | | | | | | | | Pretty vanilla translation. I cleaned up who calls whom a little. Used to be utils -> opts -> utils, now it's just utils -> opts. I may follow up with a pass over the NEON code for readability and to clean up dead code. This turns on NEON A8->R11EAC conversion for ARMv8. Unit tests which now hit the NEON code still pass. I can't find any related bench. BUG=skia:4117 Review URL: https://codereview.chromium.org/1273103002
* SkSurface copy-on-write can yield stale GPU render targets.Gravatar fmalita2015-08-06
| | | | | | | | | | | | | | Prepare_rt_for_external_access() grabs the render target and then fires access notifications. But the notification handlers may trigger copy-on-write, causing the returned render target to be stale (pointing at the detached snapshot). We should grab the render target after firing notifications. R=reed@google.com,bsalomon@google.com Review URL: https://codereview.chromium.org/1276713002
* Minor cleanup: remove GR_TESSELLATING_PATH_RENDERING #ifdef.Gravatar senorblanco2015-08-06
| | | | | | Also, new -> SkNEW. Review URL: https://codereview.chromium.org/1280433002
* Support decoding PNG to 565.Gravatar scroggo2015-08-06
| | | | | | | | | | | | | | | | | | | | | | | | | Although we initially discussed not supporting 565, SkCodec needs to support Android's BitmapFactory and BitmapRegionDecoder, which need to support 565. We could instead implement 565 on top of SkCodec, but this would require more memory and run more slowly. An open question is whether to support dithering, and how. In order to support dithering, we need to pass y to RowProc, which I believe means we will need to pass y to SkSwizzler::swizzle(). I dislike having an option which is typically ignored - SkImageDecoder allows you to turn on dithering when decoding to any color type, but it is only meaningful only if the output color type is 565. We could also make the client implement dithering, which I believe would mean forcing them to do the conversion to 565 (since we have already thrown away data when we convered to 565 without dithering). BUG=skia:3257 Review URL: https://codereview.chromium.org/1277593002
* Fix reording across rendertarget switchingGravatar joshualitt2015-08-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1276633003
* Detect MIPS DSP and DSPR2 programattically.Gravatar mtklein2015-08-05
| | | | | | | | | | | | | | | | | | | | | | | | | Procedure: $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -dM -E - < /dev/null | sort > vanilla.mips $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdsp -dM -E - < /dev/null | sort > dsp.mips $ platform_tools/android/toolchains/ndk-r10c-mips-darwin_v14/bin/mipsel-linux-android-gcc -mdspr2 -dM -E - < /dev/null | sort > dspr2.mips $ diff vanilla.mips dsp.mips 239a240,241 > #define __mips_dsp 1 > #define __mips_dsp_rev 1 $ diff vanilla.mips dspr2.mips 239a240,242 > #define __mips_dsp 1 > #define __mips_dsp_rev 2 > #define __mips_dspr2 1 So, defined(__mips_dsp) -> SK_MIPS_HAS_DSP, defined(__mips_dspr2) -> SK_MIPS_HAS_DSPR2. BUG=skia: Review URL: https://codereview.chromium.org/1274873002
* Fix variable shadowing and unreachable code that it causedGravatar brucedawson2015-08-05
| | | | | | | | | | | Change https://codereview.chromium.org/1261643004 renamed a function parameter so that some code became unreachable. This renames that parameter back. R=bsalomon@google.com BUG=skia:4169 Review URL: https://codereview.chromium.org/1271353003
* Fix ASAN error for wbmp swizzlesGravatar msarett2015-08-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1269413006
* IWYU: 'core' target, files starting A-C.Gravatar bungeman2015-08-05
| | | | | | | | | TBR=reed@google.com Verbal lgtm, does not change API. Committed: https://skia.googlesource.com/skia/+/7403d87db8e43d4c2b5b25ac22a0ebc22bd09d69 Review URL: https://codereview.chromium.org/1265033002
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-28 01:22:37 +0000