| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
Moves blend enums from GrXferProcessor.h to GrBlend.h, makes GrBlend.h
public.
BUG=skia:
Review URL: https://codereview.chromium.org/1180713008
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1174293005
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1177173003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1185453003
|
|
|
|
|
|
|
|
|
|
|
| |
The varyings used to compute rect coverage need to be high precision,
since they're offset by the frag coord.
R=egdaniel
BUG=skia:3935
Review URL: https://codereview.chromium.org/1178123004
|
|
|
|
|
|
| |
BUG=skia:1282
Review URL: https://codereview.chromium.org/1103313002
|
|
|
|
|
|
|
|
| |
Hal found a brain-dead bug on my part. Thanks Hal!
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/1176423003
|
|
|
|
|
|
| |
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/1175253004
|
|
|
|
|
|
|
|
|
| |
Fixes circular dependencies by allowing the initialization to be done
intertwined.
BUG=skia:
Review URL: https://codereview.chromium.org/1177053002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- input param to addFoo (e.g. addRect), where only CW or CCW are valid)
- output param from computing functions, that sometimes return kUnknown
This CL's intent is to split these into distinct enums/features:
- Direction (public) loses kUnknown, and is only used for input
- FirstDirection (private) is used for computing the first direction we see when analyzing a contour
BUG=skia:
Review URL: https://codereview.chromium.org/1176953002
|
|
|
|
|
|
|
|
|
| |
This is an alternate version of GrAAConvexPathRenderer which handles
curves by first flattening them to straight lines.
BUG=skia:
Review URL: https://codereview.chromium.org/1158803002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This experiment replaces the label used in the aaxfermodes gm with
aliased text generated from paths common to all platforms.
Since there is no way today to generate all dm output from trybots,
this will be checked in to confirm that this strategy provides simpler
output across devices.
This does not introduce a new public interface; instead, dm uses
a extern backdoor to install the SkTypeface::CreateFromName
handler.
Review URL: https://codereview.chromium.org/1163283002
|
|
|
|
|
|
|
|
|
|
|
|
| |
I haven't figured out a pithy way to have these apply to only classes
originating from SkNx, so let's just remove them. There aren't too
many use cases, and it's not really any less readable without them.
Semantically, this is a no-op.
BUG=skia:
Review URL: https://codereview.chromium.org/1167153002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1166993002
|
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/1170343002
|
|
|
|
|
|
|
|
| |
This reverts commit b3f0ec9f9967da2f80f0d842cb7fd53617b48de3.
BUG=skia:
Review URL: https://codereview.chromium.org/1168303006
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing this before http://crrev.com/1169813006 so the test changes needed
there are clearer. This just lets things build with floats, and is a no-op for
doubles.
No public API changes we didn't intend to already have...
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/1173673003
|
|
|
|
|
|
|
|
| |
UCLIBC does not have locale support by default.
BUG=skia:
Review URL: https://codereview.chromium.org/1162953003
|
|
|
|
|
|
| |
BUG=skia:3924
Review URL: https://codereview.chromium.org/1164423006
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1172693002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1169923002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #6 id:100001 of https://codereview.chromium.org/1148793007/)
Reason for revert:
speculative revert to try to unblock DEPS roll
Original issue's description:
> change SkDraw and all Blitters to use pixmap instead of bitmap
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c31af44336f5eb4a50e83e76e51962d46c3ed458
TBR=scroggo@google.com,jvanverth@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1164373003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1164973002
|
|
|
|
|
|
|
|
| |
An attempt was made to hold onto the 'sbix' table when it existed
when drawing to mitigate an issue with vanishing font data. This
code has not affected the crash rate, so remove it.
Review URL: https://codereview.chromium.org/1168793003
|
|
|
|
|
|
|
|
| |
Fix segfault introduced in https://codereview.chromium.org/1170553002/
BUG=skia:
Review URL: https://codereview.chromium.org/1167243002
|
|
|
|
|
|
|
| |
This provides a means of keeping an object alive for the entire
lifetime of an SkTypeface.
Review URL: https://codereview.chromium.org/1163573007
|
|
|
|
|
|
| |
BUG=494913
Review URL: https://codereview.chromium.org/1152283014
|
|
|
|
|
|
|
|
|
|
| |
Moves the coverage logic into GrGLXferProcessor for XPs that perform
dst reads. XPs that don't use a dst read are still responsible to
handle coverage on their own.
BUG=skia:
Review URL: https://codereview.chromium.org/1170553002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1148793007
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1161033005/)"
This reverts commit cca9b3ac908cf3e9a0c5774a5ffd118d8429e08a.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1153473012
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1161033005/)
Reason for revert:
broken builds
Original issue's description:
> move erase into SkPixmap
>
> harvested from https://codereview.chromium.org/1148793007
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/0963f5dab079627c5523ce6a443af27a33e361f7
TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1157303008
|
|
|
|
|
|
|
|
|
| |
harvested from https://codereview.chromium.org/1148793007
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1161033005
|
|
|
|
|
|
|
|
|
|
| |
In the provided example the color table has 10 entries but some of the pixels in the bitmap overflow. This CL goes through the pixel values and caps them to the max index.
An alternate approach would be to just have the color table always have 256 entries but zero out the unused ones.
BUG=492265
Review URL: https://codereview.chromium.org/1165493003
|
|
|
|
|
|
|
|
| |
This is all the ancillary code from https://codereview.chromium.org/1152553006/ (Fix dst bound reported by SkTileImageFilter).
TBR=reed@google.com, senorblanco@google.com
Review URL: https://codereview.chromium.org/1169713003
|
|
|
|
|
|
|
|
|
| |
extracted from larger CL in progress: https://codereview.chromium.org/1148793007
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1162013008
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1162203005
|
|
|
|
|
|
|
|
|
|
|
|
| |
FreeType automatically selects the 'most Unicode' cmap available,
otherwise the default cmap is NULL. When this happens the fallback
should include the 3,0 symbol cmap, as is outlined in the Apple
TrueType documentation. This cmap should effectively be a Unicode
mapping, but exclusively in the private use area.
BUG=skia:1873,chromium:489452
Review URL: https://codereview.chromium.org/1163833003
|
|
|
|
|
|
|
|
|
| |
Modifies GrCustomXfermode to decide at creation time whether it will
use advanced blend, instead of deciding during getOptimizations.
BUG=skia:
Review URL: https://codereview.chromium.org/1161913003
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/1153193014
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/1143173011
|
|
|
|
|
|
|
|
| |
Works around an ASAN complaint.
BUG=skia:3891
Review URL: https://codereview.chromium.org/1154773007
|
|
|
|
|
|
|
|
| |
Also a bit of general cleanup.
BUG=chromium:486944
Review URL: https://codereview.chromium.org/1152163004
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=True
Review URL: https://codereview.chromium.org/1158273007
|
|
|
|
|
|
| |
BUG=chromium:496540
Review URL: https://codereview.chromium.org/1157943007
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1152553006/)
Reason for revert:
Blink
Original issue's description:
> Fix dst bound reported by SkTileImageFilter
>
> In the example from the bug we had the filter DAG:
>
> color filter (table)
> 0: xfermode filter (arith)
> 0: tile filter [0,80,34,114] -> [0,80,800,480]
> 0: color filter (table)
> 0: bitmap src 34x34 -> [0,80,34,114]
> 1: color filter (table)
> 0: picture filter [0, 80, 800, 480]
>
> computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn.
>
> This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit.
>
> BUG=493783
>
> Committed: https://skia.googlesource.com/skia/+/05be93bbdf09576f7903130e3b106b0a8c7c4b4e
>
> Committed: https://skia.googlesource.com/skia/+/0be685755f942baea26c66a87226b569fc17e960
TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493783
Review URL: https://codereview.chromium.org/1156583004
|
|
|
|
|
|
|
| |
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/1146073004
|
|
|
|
|
|
| |
BUG=skia:3891
Review URL: https://codereview.chromium.org/1160923007
|
|
|
|
|
|
|
|
|
|
|
| |
When onCreateDevice() fails, internalSaveLayer() attempts to create a
fallback bitmap device instead - but it ignores the computed pixel geometry
in this case.
BUG=496054
R=reed@google.com
Review URL: https://codereview.chromium.org/1144153007
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the example from the bug we had the filter DAG:
color filter (table)
0: xfermode filter (arith)
0: tile filter [0,80,34,114] -> [0,80,800,480]
0: color filter (table)
0: bitmap src 34x34 -> [0,80,34,114]
1: color filter (table)
0: picture filter [0, 80, 800, 480]
computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn.
This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit.
BUG=493783
Committed: https://skia.googlesource.com/skia/+/05be93bbdf09576f7903130e3b106b0a8c7c4b4e
Review URL: https://codereview.chromium.org/1152553006
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some GMs show edge-line artifacts on Mali at the bottom/right of the canvas.
Change the 'rtAdjustment' uniform precision from 'midiump' to 'highp' if the GPU vendor is ARM.
NOTE: Vertex Shader should have default 'highp' precision, but now we explicit declared some uniform/attribute precision as 'midiump'.
This patch should fix these issues:
Issue 3693: Some GMs produce random artifacts on Mali in MSAA4
https://code.google.com/p/skia/issues/detail?id=3693
Issue 3685: srcmode GM has top/right line artifacts on Mali T604 in MSAA4
https://code.google.com/p/skia/issues/detail?id=3685
BUG=skia:
Review URL: https://codereview.chromium.org/1154163012
|