aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Revert "Respect canvas size and frame offset in webp decoder"Gravatar Robert Phillips2017-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0f33970c8d950a68b7d83cc626ac0500953d6b15. Reason for revert: msan complaint Original change's description: > Respect canvas size and frame offset in webp decoder > > BUG=skia:6185 > > Change-Id: Id543cb689a5e33b800ebbc18f4a234e78a4c4298 > Reviewed-on: https://skia-review.googlesource.com/7800 > Commit-Queue: Matt Sarett <msarett@google.com> > Reviewed-by: Leon Scroggins <scroggo@google.com> > TBR=borenet@google.com,msarett@google.com,scroggo@google.com,reviews@skia.org # Not skipping CQ checks because original CL landed > 1 day ago. BUG=skia:6185 Change-Id: Ie01dc7d7ebfebe36a235335d0d8cb28bccb2ecff Reviewed-on: https://skia-review.googlesource.com/8046 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Remove unused assignment in SkScan::AntiFillXRect.Gravatar Jeremy Roman2017-02-05
| | | | | | | | | Found by static analysis. Change-Id: I566da96938a735d29acc854cd700fcb944bc09fc Reviewed-on: https://skia-review.googlesource.com/8026 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Respect canvas size and frame offset in webp decoderGravatar Matt Sarett2017-02-03
| | | | | | | | | BUG=skia:6185 Change-Id: Id543cb689a5e33b800ebbc18f4a234e78a4c4298 Reviewed-on: https://skia-review.googlesource.com/7800 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Improved SkShadowUtils cachingGravatar Brian Salomon2017-02-03
| | | | | | | | | | | | | Multiple ambient and spot shadows can be cached for each geometry. Spot shadows can be reused when x,y light offset is different. We categorize spot shadows for rrects as either transparent, opaque with partial umbra occlusion, or opaque with full umbra occlusion and use that to improve cache performance. Change-Id: Id530bdaa5092edb46c8f584979090fbb766307fc Reviewed-on: https://skia-review.googlesource.com/7987 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Revert "Don't instantiate shaders with non-invertible local matrix""Gravatar Florin Malita2017-02-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0e86725ba4f667056ff1ef65275165853a47303b. Reason for revert: landed Blink fix, should pass layout tests now Original change's description: > Revert "Don't instantiate shaders with non-invertible local matrix" > > This reverts commit ebfbba9bbdacd754c8ad7429ee066f53f17bc66b. > > Reason for revert: breaks chrome blink tests for linux_trusty_blink_rel > > Original change's description: > > Don't instantiate shaders with non-invertible local matrix > > > > Change-Id: If11f7d57cbf45929632d858f91c02d8f5fa9f442 > > Reviewed-on: https://skia-review.googlesource.com/7885 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Florin Malita <fmalita@chromium.org> > > > > TBR=fmalita@chromium.org,reed@google.com,reviews@skia.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Change-Id: I41c5513523c27dc4bad68008f08369185897b7a2 > Reviewed-on: https://skia-review.googlesource.com/7948 > Commit-Queue: Hal Canary <halcanary@google.com> > Reviewed-by: Hal Canary <halcanary@google.com> > TBR=halcanary@google.com,reviews@skia.org,fmalita@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I373ea6c61a256fd8cfbfb34f8b2d39a3ff8109db Reviewed-on: https://skia-review.googlesource.com/8003 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* expose new tight-bounds method on SkPathGravatar Mike Reed2017-02-03
| | | | | | | | | BUG=skia: Change-Id: Ie50df49c1758af203042a84dc2cd505046373d2c Reviewed-on: https://skia-review.googlesource.com/7996 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Make shadow tessellators fail gracefully and add unit test for this.Gravatar Brian Salomon2017-02-03
| | | | | | | Change-Id: I42a9d06a18928588347a6dea2f6150518ba29aa8 Reviewed-on: https://skia-review.googlesource.com/7886 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* GrTessellator (AA): Fix for missing fill artifacts.Gravatar Stephen White2017-02-03
| | | | | | | | | | | | | | | | | | | | Some regions were being incorrectly filled due to setting connector edges winding to zero *after* merging collinear edges. This would cause the merge to add the wrong winding value. Putting the adjust before the call to merge_collinear_edges() fixes the problem. Also, some pixels were not getting coverage due the inner edge being +1 winding. Using -2 winding for inner edges ensure the interior regions are -1 winding, which gives coverage in more cases of self-intersection. This required flipping the comparisons on the intruding-vertices workaround. BUG=skia: Change-Id: I216fa3d30c196a6b7773637e48802f6572c993c7 Reviewed-on: https://skia-review.googlesource.com/7962 Commit-Queue: Stephan White <senorblanco@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Initialize some more variables in SpotShadowTessellatorGravatar Jim Van Verth2017-02-03
| | | | | | | | | | BUG=skia:6119 Change-Id: Id3a3042df6254e3367713b82f3b08257e0be71b1 Reviewed-on: https://skia-review.googlesource.com/7992 Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* experimental tight-boundsGravatar Mike Reed2017-02-03
| | | | | | | | | | | | | not sure about api -- perhaps it could just return the bounds, and make them 0,0,0,0 if the path is empty -- the caller can trivially know if the path is empty themselves. BUG=skia: Change-Id: I2dbb861e8d981b27c5a6833643977f5bd6802217 Reviewed-on: https://skia-review.googlesource.com/7989 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Added dead variable / code elimination to skslc.Gravatar Ethan Nicholas2017-02-03
| | | | | | | | | BUG=skia: Change-Id: Ib037730803a8f222f099de0e001fe06ad452a22c Reviewed-on: https://skia-review.googlesource.com/7584 Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Batch across matrix changes in drawVertices and add GM to test.Gravatar Brian Salomon2017-02-03
| | | | | | | Change-Id: I6b08d37781e3c715a1d9d8c9729667ec78625836 Reviewed-on: https://skia-review.googlesource.com/7949 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Revert "Revert "Spot shadow cleanup and optimization""Gravatar Brian Salomon2017-02-02
| | | | | | | | | This reverts commit aa2bd8f726d98edafd28c8553e99cbae33c431dd. Change-Id: Iaa5d9e649d842889ff031eeb11d0547270968420 Reviewed-on: https://skia-review.googlesource.com/7981 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* SkXPSDevice inherits from SkBaseDeviceGravatar Hal Canary2017-02-02
| | | | | | | Change-Id: I81ed36da33821df36d11806a6349a2ede61c6f73 Reviewed-on: https://skia-review.googlesource.com/7942 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Revert "Don't instantiate shaders with non-invertible local matrix"Gravatar Hal Canary2017-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ebfbba9bbdacd754c8ad7429ee066f53f17bc66b. Reason for revert: breaks chrome blink tests for linux_trusty_blink_rel Original change's description: > Don't instantiate shaders with non-invertible local matrix > > Change-Id: If11f7d57cbf45929632d858f91c02d8f5fa9f442 > Reviewed-on: https://skia-review.googlesource.com/7885 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> > TBR=fmalita@chromium.org,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I41c5513523c27dc4bad68008f08369185897b7a2 Reviewed-on: https://skia-review.googlesource.com/7948 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Revert "Spot shadow cleanup and optimization"Gravatar Hal Canary2017-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 47784c18adc20d1bfefebd00c3ee98c669d79b4d. Reason for revert: MSAN, ASAN Original change's description: > Spot shadow cleanup and optimization > > Fixes clip polygon and centroid calculation. > Clips interior umbra region against original path. > > BUG=skia:6119 > > Change-Id: I37a740ae004c38b75405e05158d92cf9fd954eda > Reviewed-on: https://skia-review.googlesource.com/7823 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Reviewed-by: Brian Salomon <bsalomon@google.com> > TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:6119 Change-Id: I7a4d9fa3af0d30feac999229f2e94aae2bdafc9c Reviewed-on: https://skia-review.googlesource.com/7947 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Spot shadow cleanup and optimizationGravatar Jim Van Verth2017-02-02
| | | | | | | | | | | | Fixes clip polygon and centroid calculation. Clips interior umbra region against original path. BUG=skia:6119 Change-Id: I37a740ae004c38b75405e05158d92cf9fd954eda Reviewed-on: https://skia-review.googlesource.com/7823 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Revert "Replaced all calls to fragmentPosition() with sk_FragCoord"Gravatar Ethan Nicholas2017-02-02
| | | | | | | | | | | | | This reverts commit de4d301881e7fd084f1f0b359ec6f9b2bf8bd4c5. Reason for revert: several Chrome rendering bugs on Mac BUG=skia: Change-Id: I492082b0b7e7c902ede4b598c5809f604d210ce1 Reviewed-on: https://skia-review.googlesource.com/7887 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Don't instantiate shaders with non-invertible local matrixGravatar Florin Malita2017-02-02
| | | | | | | Change-Id: If11f7d57cbf45929632d858f91c02d8f5fa9f442 Reviewed-on: https://skia-review.googlesource.com/7885 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Force instantiation in GaussianBlur to hopefully prevent (and diagnose) ↵Gravatar Robert Phillips2017-02-02
| | | | | | | | | | | Chrome crash BUG=687174 Change-Id: Ieb9930feca9abad9220a1a099e7dd247e6eff70e Reviewed-on: https://skia-review.googlesource.com/7920 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Revert "Revert "SkScalar: delete code that doesn't compile.""Gravatar Hal Canary2017-02-02
| | | | | | | | | This reverts commit 8233fc82b00763d37a7b0db7890b15c7d58939d4. Change-Id: Ia32ccdb3b385ed28e1b41e553c7d80cf803522cc Reviewed-on: https://skia-review.googlesource.com/7899 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Revert "SkScalar: delete code thqat doesn't compile."Gravatar Leon Scroggins2017-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 565da18f6e4a0f04dc836ce9d35f31bee31644f7. Reason for revert: breaking android roll: https://googleplex-android-review.git.corp.google.com/#/c/1853481/-1..1 Some code in Android references SK_SCALAR_IS_FLOAT: https://cs.corp.google.com/android/frameworks/base/core/jni/android/graphics/Interpolator.cpp?q=frameworks/base/core/jni/android/graphics/Interpolator.cpp&sq=package:android&l=30 Original change's description: > SkScalar: delete code thqat doesn't compile. > > Change-Id: I8a5c404d6151fca79af5c5a98d4b44924c0ade52 > Reviewed-on: https://skia-review.googlesource.com/7882 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Hal Canary <halcanary@google.com> > TBR=halcanary@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I4df06c4593abaa3ac3877b270a41aec7a9c3fc8f Reviewed-on: https://skia-review.googlesource.com/7888 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* make GR_TEST_UTILS=0 workGravatar Hal Canary2017-02-02
| | | | | | | Change-Id: Icce35140ca08b65217b32e6b1ffc6ad2f38ab37f Reviewed-on: https://skia-review.googlesource.com/7840 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Have Vulkan advertise that compressed textures are currently unsupportedGravatar Robert Phillips2017-02-02
| | | | | | | | | | This allows the ProxyTest to run on the Vulkan backend. Change-Id: I89a3212bdc2d4a1ceb0c27d0ff60f558d7b12647 Reviewed-on: https://skia-review.googlesource.com/7880 Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* SkScalar: delete code thqat doesn't compile.Gravatar Hal Canary2017-02-02
| | | | | | | Change-Id: I8a5c404d6151fca79af5c5a98d4b44924c0ade52 Reviewed-on: https://skia-review.googlesource.com/7882 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Prepare to test all image decode modes to F16Gravatar Matt Sarett2017-02-02
| | | | | | | | | | | | | | | I've only been running F16 tests in "colorImage" mode. We really should be running our "image" tests to F16 as well - so they can be tested with scaling, subsets, etc. This CL fixes bugs so that we can enable those tests. BUG=skia: Change-Id: I8137eb4fce7ea12f2c9d233a029d946d4a63e6b0 Reviewed-on: https://skia-review.googlesource.com/7801 Commit-Queue: Matt Sarett <msarett@google.com> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Add a GM for SkShadowUtils and fix a few issues.Gravatar Brian Salomon2017-02-01
| | | | | | | | | | | | | | | 1) Transform the path center to device space before computing the shadow offset. 2) Modulate the shadow color by the color filter's output color. 3) Make the scale of path points in the spot tessellator be relative to the path centroid. 4) Clamp the shadow alphas at 1. Change-Id: I480476df79b959f11c1eca0ba2a49a134d355cbb Reviewed-on: https://skia-review.googlesource.com/7860 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Add caching of ambient and spot shadow meshes.Gravatar Brian Salomon2017-02-01
| | | | | | | Change-Id: If882186225621af4af4b4ddae0c786ec33ff40f3 Reviewed-on: https://skia-review.googlesource.com/7643 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
* Expand SkImage::getTextureHandle callGravatar Robert Phillips2017-02-01
| | | | | | | | | | | | | | | | AFAICT cc/output/gl_renderer.cc only calls SkImage:getTexture to determine the origin of the backing GrTexture. What do y'all think of this CL as a means of removing that call to getTexture? One alternative would be to add a new entry point like: bool SkImage::getBackendTextureDesc(GrBackendTextureDesc* desc) const; which fills in the entire desc and returns whether the image is texture backed. Change-Id: Idd302c0a11d69ad08e0100bcf546b3bbaa7cf27e Reviewed-on: https://skia-review.googlesource.com/7788 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Broaden checking of GrSurfaceProxy::MakeDeferred's return valueGravatar Robert Phillips2017-02-01
| | | | | | | | | | | | | We now expect MakeDeferred to baulk if the ultimate texture/rendertarget will not be instantiable. Added checks for MakeWrapped too since, technically, it too can baulk. BUG=676753 Change-Id: I3e052ebf98303fc46124272082c10f303d89da27 Reviewed-on: https://skia-review.googlesource.com/7830 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add test for proactive proxy-creation failureGravatar Robert Phillips2017-02-01
| | | | | | | | | | | This is a follow up to https://skia-review.googlesource.com/c/7828/ (Add more pre-checks to surfaceProxy creation) BUG=687174 Change-Id: I97385afbdaf1881b806ee37737020564e3f4d444 Reviewed-on: https://skia-review.googlesource.com/7864 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* GR_PROXY_MOVE: Work around Win/Clang eval order bugGravatar Hans Wennborg2017-02-01
| | | | | | | | | | BUG=chromium:687259 Change-Id: I145dac240a3c4f89cf1b6bf6ff54ba73cd110ebf Reviewed-on: https://skia-review.googlesource.com/7831 Reviewed-by: Hans Wennborg <hwennborg@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add more pre-checks to surfaceProxy creationGravatar Robert Phillips2017-02-01
| | | | | | | | | | | | | Chrome is seeing crashes in GrProcessor::TextureSampler::reset when the textures are being instantiated. This CL moves more potential failures cases up-stack. BUG=687174 Change-Id: I014acff9730ffd1e8ac178611372ed4dedbd82f3 Reviewed-on: https://skia-review.googlesource.com/7828 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Update SkSurface's cached image ownership handling to sk_spGravatar Robert Phillips2017-02-01
| | | | | | | Change-Id: I9dca3d355bfe39211cb5054a5834d9c1750d8152 Reviewed-on: https://skia-review.googlesource.com/7780 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Reduce use of SkImage_Base::peekTextureGravatar Robert Phillips2017-01-31
| | | | | | | Change-Id: I079093c9706df4911d47fba04b786e59240e8cb4 Reviewed-on: https://skia-review.googlesource.com/7792 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Fix assert in SkShadowVertices constructorGravatar Brian Salomon2017-01-31
| | | | | | | Change-Id: Icedbe70079d41234c98330af64d71a4e60b67f1c Reviewed-on: https://skia-review.googlesource.com/7796 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Work around GCC 4.6 issue with constructing unique_ptr<const T[]> from a T*.Gravatar Brian Salomon2017-01-31
| | | | | | | | Change-Id: I74f309f56e5042ad58c7e959d5bc434de1446efa Reviewed-on: https://skia-review.googlesource.com/7793 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Make SkShadowUtils tessellations ref counted in preparation for caching them.Gravatar Brian Salomon2017-01-31
| | | | | | | Change-Id: I60133fcc4101a27bcc3e7ad38e7348ad9147b8a9 Reviewed-on: https://skia-review.googlesource.com/7784 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* SkRasterPipeline shader adapterGravatar Florin Malita2017-01-31
| | | | | | | | | | | | | Reland of https://skia-review.googlesource.com/c/7615. (lifted from https://skia-review.googlesource.com/c/7088/) CQ_INCLUDE_TRYBOTS=skia.primary:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD Change-Id: I797a2f0ae80209c8637875418e08d2fa03249672 Reviewed-on: https://skia-review.googlesource.com/7731 Commit-Queue: Florin Malita <fmalita@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Make sure to preserve stencil on vulkan copy as drawsGravatar Greg Daniel2017-01-31
| | | | | | | | | BUG=skia: Change-Id: I65a7eebe2024585e0696f8185b8ae9af5069f459 Reviewed-on: https://skia-review.googlesource.com/7782 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* GrTessellator (AA): improve AA quality for near-overlapping paths.Gravatar Stephen White2017-01-30
| | | | | | | | | | | | | | | When path features are very close together, the outer contours can overlap. This causes the connector edges (the ones joining the inner and outer vertices) to intersect other edges. Lerping the alpha along the connector edge gives us a good approximation of the coverage at that point. BUG=skia: Change-Id: I56bcc570fc185344c5f84d11ef995d3940a08793 Reviewed-on: https://skia-review.googlesource.com/7701 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Stephan White <senorblanco@chromium.org>
* delete SkLayer.cppGravatar Hal Canary2017-01-30
| | | | | | | | Change-Id: I7c0325daef62948ea9f5ef58a06236be502f3ef7 Reviewed-on: https://skia-review.googlesource.com/7783 Commit-Queue: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* GIF: Only report a frame after knowing dependencyGravatar Leon Scroggins III2017-01-30
| | | | | | | | | | | | | | | | | | | | Previously, getFrameInfo might report a frame that was truncated prior to setting its requiredFrame. As a result, fRequiredFrame may be different depending on how much data has already been received. If there is a local color table, do not report the frame until the color table has been received, since that is used to determine fRequiredFrame. If there is no local color table, set fRequiredFrame and report the frame after reading the header. Add a test. Replace make_from_resource with GetResourceAsData Change-Id: I1b697f766c1d0e1e12ab2ae1d27167af5193395d Reviewed-on: https://skia-review.googlesource.com/7756 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* Fix SkShadowTessellator.cpp for Chrome iOS buildGravatar Jim Van Verth2017-01-30
| | | | | | | | | | BUG=skia:6119 Change-Id: I6ddd51c2ebc04e5f8ae29459dc818f0d96ace073 Reviewed-on: https://skia-review.googlesource.com/7758 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Reviewed-by: Hal Canary <halcanary@google.com>
* Rationalize GrContext's Gr*Proxy getter namingGravatar Robert Phillips2017-01-30
| | | | | | | | | | | | | | | | | | | | | | | | This CL replaces the entry points: asDeferredSurface asDeferredTexture asDeferredRenderTarget with: GrSurfaceProxy* asSurfaceProxy sk_sp<GrSurfaceProxy> asSurfaceProxyRef GrTextureProxy* asTextureProxy sk_sp<GrTextureProxy> asTextureProxyRef GrRenderTargetProxy* asRenderTargetProxy sk_sp<GrRenderTargetProxy> asRenderTargetProxyRef Change-Id: I7c2b1ea3d702023ff23019815ca13c9ff6f3b32d Reviewed-on: https://skia-review.googlesource.com/7741 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Change shadow tessellators to use SkColor and move to util.Gravatar Jim Van Verth2017-01-30
| | | | | | | | | BUG=skia:6119 Change-Id: I4c4a8933c663ccc057596318a06c538175b9f16b Reviewed-on: https://skia-review.googlesource.com/7726 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Make blur utils take GrTextureProxies - take 2Gravatar Robert Phillips2017-01-30
| | | | | | | | | This is a re-land of https://skia-review.googlesource.com/c/7738/ (Make blur utils take GrTextureProxies) with a fix for the Nexus7 Change-Id: I5821a26b1e986daa11d960ae826a1207512cd2a0 Reviewed-on: https://skia-review.googlesource.com/7746 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Implement onAppendStages for SkPictureShaderGravatar Yuqian Li2017-01-30
| | | | | | | | | BUG=skia: Change-Id: Ibc525a666f17fed1d987c0316b1963ebed7de343 Reviewed-on: https://skia-review.googlesource.com/7739 Commit-Queue: Yuqian Li <liyuqian@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Make SkGpuDevice::drawVertices perform color byte order swap and premul step ↵Gravatar Brian Salomon2017-01-30
| | | | | | | | | using vertex shader. Change-Id: I8153ba8c6bb48d8b15d524fbfafbe3c6d83f39c5 Reviewed-on: https://skia-review.googlesource.com/7727 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Make blur utils take GrTextureProxies"Gravatar Robert Phillips2017-01-30
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d0dc05b98b71af43b44f13beba1292db52b75539. Reason for revert: assertion failure on N7 Original change's description: > Make blur utils take GrTextureProxies > > Change-Id: I1c5054de6d9827eece2f73c4c78818b4db0bc611 > Reviewed-on: https://skia-review.googlesource.com/7738 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > TBR=bsalomon@google.com,robertphillips@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I82d9385e23279db4c7a6757f1224e603e231354c Reviewed-on: https://skia-review.googlesource.com/7744 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-20 11:12:49 +0000