aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Revert "Add kAAHairline to GpuPathRenderers"Gravatar Ben Wagner2018-07-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 880b9d302fadd6449a511b8664682f16cde7dd9c. Reason for revert: Appears to be breaking serialization. See https://ci.chromium.org/raw/build/logs.chromium.org/skia/20180718T201711.486335899Z_000000000077bbff/+/annotations Original change's description: > Add kAAHairline to GpuPathRenderers > > With the upcoming ccpr stroking, this will no longer be the only path > renderer that can handle hairlines. > > Bug: skia: > Change-Id: Idf2543f053c8603c80fcd647ca18ffd9860a85f3 > Reviewed-on: https://skia-review.googlesource.com/142246 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Chris Dalton <csmartdalton@google.com> TBR=brianosman@google.com,csmartdalton@google.com Change-Id: I1967c2cf6b1f1307270bf62bb04130cdf84317b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/142280 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Redo drawTextRSXForm for glyph runsGravatar Herb Derby2018-07-18
| | | | | | | Change-Id: Iec9ad6a2c91b16c4e25150902b433fc7aae68a33 Reviewed-on: https://skia-review.googlesource.com/142171 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Herb Derby <herb@google.com>
* Add kAAHairline to GpuPathRenderersGravatar Chris Dalton2018-07-18
| | | | | | | | | | | With the upcoming ccpr stroking, this will no longer be the only path renderer that can handle hairlines. Bug: skia: Change-Id: Idf2543f053c8603c80fcd647ca18ffd9860a85f3 Reviewed-on: https://skia-review.googlesource.com/142246 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* ccpr: Remove constant scale when solving the cubic midtangentGravatar Chris Dalton2018-07-18
| | | | | | | | | | | We only care about the direction of the tangent vector, not the the magnitude, so a 3x scale is irrelevant. Bug: skia: Change-Id: Icd2d82faf2c700fc794f8d4a59f21b32398b64f0 Reviewed-on: https://skia-review.googlesource.com/142245 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* add new patheffectsGravatar Mike Reed2018-07-18
| | | | | | | | Bug: skia: Change-Id: Icc94eafbb26a097d5032cdb4f6e2e0f52a4e1025 Reviewed-on: https://skia-review.googlesource.com/141961 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* SkUTF16_CountUnichars to error instead of assert.Gravatar Ben Wagner2018-07-18
| | | | | | | | | | | | | Update SkUTF16_CountUnichars to return -1 on invalid input instead of simply asserting in debug. This also removes the unneeded checks for zero length input. This also updates SkPaintPriv::ValidCountText and its documentation to reflect the reality that it returns -1 on invalid data. Bug: skia:8156 Change-Id: Ief227b7dec9d1e823b93e9061558f8412791fc09 Reviewed-on: https://skia-review.googlesource.com/142168 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Fix explicit allocation bugGravatar Robert Phillips2018-07-18
| | | | | | | Change-Id: I9866f563e02b2ab290cc46ede05f8eda21f6d3b2 Reviewed-on: https://skia-review.googlesource.com/142163 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Reland "Add some optimizations to PolyUtils"Gravatar Jim Van Verth2018-07-18
| | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of 8bb0db3d07450880d346d808018708416c928657 Original change's description: > Add some optimizations to PolyUtils > > * Switch inset/offset code to use a linked list rather than an array > * Use std::set to store active edge list for IsSimplePolygon rather than array > * Pre-alloc the priority queue for IsSimplePolygon > * When adding radial curves, expand the array all at once rather than pushing > one at a time. > > Bug: skia: > Change-Id: I692f8c29c500c41ec1d1be39d924d8a752676bf4 > Reviewed-on: https://skia-review.googlesource.com/140787 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> Bug: skia: Change-Id: I3f5d42cfb941deab2b28bed020b37ce199e91d3d Reviewed-on: https://skia-review.googlesource.com/142200 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Pull non-substantive changes out of "Reduce arbitrary opList splitting when ↵Gravatar Robert Phillips2018-07-18
| | | | | | | | | sorting" Change-Id: I044d7cde5ed4f1dc60bb55dfd534680b4cd055bf Reviewed-on: https://skia-review.googlesource.com/142167 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Reland "implemented metal gpu backend texture upload testing"Gravatar Timothy Liang2018-07-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a80a012456a95a6996a8901268ec34ed0cc3aecb. Reason for revert: Fix bot failure. Original change's description: > Revert "implemented metal gpu backend texture upload testing" > > This reverts commit 36848f6b30ddaca461c98e13b9976b2c449ca547. > > Reason for revert: Test-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-All-Android_CCPR failing. > > Original change's description: > > implemented metal gpu backend texture upload testing > > > > Bug: skia: > > Change-Id: Ia3af58a0710f7f9792b37682a3cc45dd14282b71 > > Reviewed-on: https://skia-review.googlesource.com/140248 > > Commit-Queue: Timothy Liang <timliang@google.com> > > Reviewed-by: Greg Daniel <egdaniel@google.com> > > TBR=egdaniel@google.com,ethannicholas@google.com,timliang@google.com > > Change-Id: Idf40fc78b82aec1efbcc64221b6d2bbf63353960 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/141182 > Reviewed-by: Timothy Liang <timliang@google.com> > Commit-Queue: Timothy Liang <timliang@google.com> Bug: skia: Change-Id: Ib8c5b2e0cf9de25c11c14741a32846bcc874d712 Reviewed-on: https://skia-review.googlesource.com/141183 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* ccpr: Account for stroke and style in path cache keysGravatar Chris Dalton2018-07-18
| | | | | | | | Bug: skia: Change-Id: Ideec39e9a749e923bb576c9149cac95ba740b35e Reviewed-on: https://skia-review.googlesource.com/142188 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Reland "SkDEBUGF: use __VA_ARGS__"Gravatar Hal Canary2018-07-18
| | | | | | | | | | | | | | | | | This is a reland of 2267a092356d17f6444502dc92491485ccf24341 Original change's description: > SkDEBUGF: use __VA_ARGS__ > > Change-Id: I42a47e821ff7a7f6cec65b38a8216cabbf0acfce > Reviewed-on: https://skia-review.googlesource.com/139860 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Hal Canary <halcanary@google.com> Change-Id: Ia06567e441a414f4dcdbe5663160082f889f9fef Reviewed-on: https://skia-review.googlesource.com/141762 Reviewed-by: Hal Canary <halcanary@google.com> Commit-Queue: Hal Canary <halcanary@google.com>
* Fix Valgrind skinning bugGravatar Robert Phillips2018-07-18
| | | | | | | | | | | | | | | This should take care of all the issues like: Conditional jump or move depends on uninitialised value(s) SkRect::join(float, float, float, float) (SkRect.cpp:119) join (SkRect.h:1370) GrDrawVerticesOp::GrDrawVerticesOp(...) (GrDrawVerticesOp.cpp:105) Change-Id: I520ea55c9e310017bd8d5e2a7c9c343e3ac8eb40 Reviewed-on: https://skia-review.googlesource.com/142101 Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Robert Phillips <robertphillips@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* GrTessellator: fix overlap outer boundary winding.Gravatar Stephen White2018-07-18
| | | | | | | | | | | | | | | | When two outer boundary edges are collinear, they are part of an overlap region. As of 77169c8fd6d, we (correctly) leave these edges connected, but we must also adjust the winding to magnitude 1 to keep the winding rules correct. Note: this adds a new test case to the concavepaths GM, affecting all platforms. Bug: 863389 Change-Id: I7e3a06df537cd189101e7ad39a4815a78be8fbdd Reviewed-on: https://skia-review.googlesource.com/141952 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* fixed ASAN dm errorsGravatar Ruiqi Mao2018-07-17
| | | | | | | | Bug: skia: Change-Id: Iade74ee6a4f063deb5af66d3b06affba28977011 Reviewed-on: https://skia-review.googlesource.com/141966 Reviewed-by: Ruiqi Mao <ruiqimao@google.com> Commit-Queue: Ruiqi Mao <ruiqimao@google.com>
* fixed ASAN dm errorsGravatar Ruiqi Mao2018-07-17
| | | | | | | | Bug: skia: Change-Id: Id2819c7c0c187dccf13e40fd4a96698701cccc48 Reviewed-on: https://skia-review.googlesource.com/141965 Reviewed-by: Ruiqi Mao <ruiqimao@google.com> Commit-Queue: Ruiqi Mao <ruiqimao@google.com>
* MakeAsDrawText for SkTextBlobGravatar Herb Derby2018-07-17
| | | | | | | | | Change-Id: I04ebca6b318e0654cc1e598aa323cfb9a21e5a5e Reviewed-on: https://skia-review.googlesource.com/141960 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Herb Derby <herb@google.com>
* Implement scaled color emoji using PNG format fonts.Gravatar Bruce Wang2018-07-17
| | | | | | | Change-Id: I8da6258f2a8991231411e84b66b01a5e8fd38e31 Reviewed-on: https://skia-review.googlesource.com/141427 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Bruce Wang <brucewang@google.com>
* Move SkNoncopyable to include/private.Gravatar Ben Wagner2018-07-17
| | | | | | | Change-Id: I62f60ea52faeebddecacf03d9429ac3f7c516b8e Reviewed-on: https://skia-review.googlesource.com/141823 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Fix validity check in SkSurface::MakeFromBackendTextureAsRenderTargetGravatar Justin Novosad2018-07-17
| | | | | | | | | | | | | | | | | Swaped the order of validate_backend_texture() and SkSurface_Gpu::Valid() so that the pixel config computed by validate_backend_texture() get used by SkSurface_Gpu::Valid(). This makes the behavior of this method consistent with the behavior of sister method MakeFromBackendTexture() BUG=788439 Change-Id: I132ea8da23430ea99bbeabce79b08edb6b4cae03 Reviewed-on: https://skia-review.googlesource.com/141837 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by: Justin Novosad <junov@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Auto-Submit: Justin Novosad <junov@chromium.org>
* fixed SPIR-V memory layoutGravatar Ethan Nicholas2018-07-17
| | | | | | | | Bug: skia: Change-Id: Ib503e24e4cfcb3e064a9e34a4d9ca3230c989372 Reviewed-on: https://skia-review.googlesource.com/141838 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Use std::chrono for measuring timingGravatar Allan MacKinnon2018-07-17
| | | | | | | | Bug: skia: Change-Id: Ida239fa3b47056289d698a19a624703fe6ff3f35 Reviewed-on: https://skia-review.googlesource.com/141951 Reviewed-by: Allan MacKinnon <allanmac@google.com> Commit-Queue: Allan MacKinnon <allanmac@google.com>
* fix MSAN dm failuresGravatar Ruiqi Mao2018-07-17
| | | | | | | | Bug: skia: Change-Id: I1c85f5579f48501e448009d7f7df129c790ae5ee Reviewed-on: https://skia-review.googlesource.com/141831 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ruiqi Mao <ruiqimao@google.com>
* Revert "Add some optimizations to PolyUtils"Gravatar Jim Van Verth2018-07-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 8bb0db3d07450880d346d808018708416c928657. Reason for revert: Breaking Google3. Original change's description: > Add some optimizations to PolyUtils > > * Switch inset/offset code to use a linked list rather than an array > * Use std::set to store active edge list for IsSimplePolygon rather than array > * Pre-alloc the priority queue for IsSimplePolygon > * When adding radial curves, expand the array all at once rather than pushing > one at a time. > > Bug: skia: > Change-Id: I692f8c29c500c41ec1d1be39d924d8a752676bf4 > Reviewed-on: https://skia-review.googlesource.com/140787 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Jim Van Verth <jvanverth@google.com> TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com Change-Id: Ie8afecd899fa9bd79d22fdf46ec82a0c9e94e893 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/141980 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Add some optimizations to PolyUtilsGravatar Jim Van Verth2018-07-17
| | | | | | | | | | | | | | * Switch inset/offset code to use a linked list rather than an array * Use std::set to store active edge list for IsSimplePolygon rather than array * Pre-alloc the priority queue for IsSimplePolygon * When adding radial curves, expand the array all at once rather than pushing one at a time. Bug: skia: Change-Id: I692f8c29c500c41ec1d1be39d924d8a752676bf4 Reviewed-on: https://skia-review.googlesource.com/140787 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Add SkFloat2Bits and Region stubGravatar Kevin Lubick2018-07-17
| | | | | | | | Bug: skia: Change-Id: I5ab9a4d42e9eec6563499a09e08ed8b183ac91b2 Reviewed-on: https://skia-review.googlesource.com/141426 Reviewed-by: Cary Clark <caryclark@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Restore SkLightingShader and associated classesGravatar Robert Phillips2018-07-17
| | | | | | | | | This reverts https://skia-review.googlesource.com/c/skia/+/31140 (Remove SkLightingShader and associated classes) and updates the classes to ToT Change-Id: I3b1df1704cca8907aa00f081a7e93339b65ad4fa Reviewed-on: https://skia-review.googlesource.com/141545 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Bug fixes and improvements to SKC and HotSort. Vulkan is WIP.Gravatar Allan MacKinnon2018-07-17
| | | | | | | | | Bug: skia: Change-Id: Iffc75a5b4dfcbfa4a6c23d972bb9798c2f550335 Reviewed-on: https://skia-review.googlesource.com/141582 Reviewed-by: Mike Reed <reed@google.com> Reviewed-by: Allan MacKinnon <allanmac@google.com> Commit-Queue: Allan MacKinnon <allanmac@google.com>
* remove unused untested parts of text blobGravatar Cary Clark2018-07-17
| | | | | | | | | | | | | | | | | SkTextBlob has a number of untested entry points to serialize and deserialize. Privitize ones only used by Skia, and remove ones suspected to be unused and untested. R=fmalita@chromium.org TBR=reed@google.com,bsalomon@google.com Bug: skia:6818 Change-Id: I6a9982a26a883982af3592f3302029a1bcdf5aa3 Reviewed-on: https://skia-review.googlesource.com/141820 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Cary Clark <caryclark@skia.org> Commit-Queue: Cary Clark <caryclark@skia.org>
* added byte and ubyte types to SKSLGravatar Ruiqi Mao2018-07-17
| | | | | | | | | | | created new GMs for skinning Bug: skia: Change-Id: I15fb2bd02fba8beb6dd2dd3f3716da016ea92192 Reviewed-on: https://skia-review.googlesource.com/140241 Commit-Queue: Ruiqi Mao <ruiqimao@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Remove crash when shader linking fails.Gravatar Brian Salomon2018-07-17
| | | | | | | | | Bug: 861956 Change-Id: If60c1f4112702d8f96cb27a624de167049b34370 Reviewed-on: https://skia-review.googlesource.com/141547 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com> Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
* Remove SkTransferFunctionBehaviorGravatar Brian Osman2018-07-17
| | | | | | | | Bug: skia: Change-Id: Iccbe609b2a8d4c9098ef36aa6530dbc3771e0c11 Reviewed-on: https://skia-review.googlesource.com/141055 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Reland "Remove interpolants are inaccurate workaround for Adreno 3xx."Gravatar Brian Salomon2018-07-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of a7a278205bb040061cb4ba46839efe18635c7edc Clean reland. Change to Chrome screenshot unit test has stuck. The previous revert of that was the reason this had to be reverted. Original change's description: > Remove interpolants are inaccurate workaround for Adreno 3xx. > > The chrome screenshot unit test that led to adding this workaround has > been adjusted to avoid testing AA edges of rendered rectangles. We're > accepting the inaccuracy in favor of increased performance. > > Chrome change: https://chromium-review.googlesource.com/c/chromium/src/+/1129041 > > Bug: chromium:847984 > Change-Id: I9b714ade2a67e956ebb2773ebe3b8632dc3a50c6 > Reviewed-on: https://skia-review.googlesource.com/140180 > Commit-Queue: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Osman <brianosman@google.com> > Auto-Submit: Brian Salomon <bsalomon@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> Bug: chromium:847984 Change-Id: I2dc1195f07bb27015b0a7a0fa6263d0e60a32a15 Reviewed-on: https://skia-review.googlesource.com/141761 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Reduce arbitrary opList splitting when sorting"Gravatar Robert Phillips2018-07-17
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 94fee93c9b23bd1a32604753da8bef755d6c8a95. Reason for revert: Android (and Chromecast) woes Original change's description: > Reduce arbitrary opList splitting when sorting > > Change-Id: I49a47672600f72dc46f27462a2c344e77a06a659 > Reviewed-on: https://skia-review.googlesource.com/141243 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> TBR=bsalomon@google.com,robertphillips@google.com Change-Id: Ic4fd4ab17bb15bef35dcbf852e0f8ad99ee45e8f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/141760 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Reduce arbitrary opList splitting when sortingGravatar Robert Phillips2018-07-17
| | | | | | | Change-Id: I49a47672600f72dc46f27462a2c344e77a06a659 Reviewed-on: https://skia-review.googlesource.com/141243 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Remove SkRefDict.Gravatar Ben Wagner2018-07-16
| | | | | | | | | It is unused. Remove it. Change-Id: If62a93a58d21bfccd6df112e92a709bff4d11c97 Reviewed-on: https://skia-review.googlesource.com/141566 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Remove processText last vestige of drawTextGravatar Herb Derby2018-07-16
| | | | | | | Change-Id: I03a8c094533cdda1e6e3a43d0124889ef6476b0b Reviewed-on: https://skia-review.googlesource.com/141560 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Remove drawText support from SkOverdrawCanvasGravatar Herb Derby2018-07-16
| | | | | | | | | | | This canvas is used by android, and never uses the drawText method. I think this is the last call to processText which will be deleted shortly. Change-Id: I134abff47b0b7fda02297e4b4496e2f0413a3957 Reviewed-on: https://skia-review.googlesource.com/141546 Reviewed-by: Derek Sollenberger <djsollen@google.com> Commit-Queue: Herb Derby <herb@google.com>
* GrTessellator: collinear edges during sanitize.Gravatar Stephen White2018-07-16
| | | | | | | | | | | | When three collinear edges occur during the sanitize_contours() pass, their vertices may not yet have been discovered to be coincident. So we must do the vertex comparison by point, rather than by pointer. Bug: 860655 Change-Id: I89dc7526905bb5473206661348fee431371731a0 Reviewed-on: https://skia-review.googlesource.com/141523 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Stephen White <senorblanco@chromium.org>
* Device interface uses glyph run listGravatar Herb Derby2018-07-16
| | | | | | | | | | | | | Have devices just treat all runs as drawPosText except for SkGPUDevice and SkRemoteGlyphCache. Those two just pass the blob to the old code. This way the change over from blobs to run lists can happen in smaller steps. Change-Id: I3407bffeafe7fbd1c369f6b3c3db8d64b4b6c3b1 Reviewed-on: https://skia-review.googlesource.com/141300 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Herb Derby <herb@google.com>
* In GrContext::readSurfacePixels fail gracefully if temp pixmap allocationGravatar Brian Salomon2018-07-16
| | | | | | | | | | | fails. Bug: chromium:860399 Change-Id: I6793e7fe7e97b7848d40170046dcff4c2fcc48c7 Reviewed-on: https://skia-review.googlesource.com/141101 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com>
* Whitespace cleanup againGravatar Hal Canary2018-07-16
| | | | | | | | Change-Id: I38ab9ff141eb088084a4c0e664f327ceb89fcf70 Reviewed-on: https://skia-review.googlesource.com/140784 Commit-Queue: Hal Canary <halcanary@google.com> Auto-Submit: Hal Canary <halcanary@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* plumb through arenaallocGravatar Mike Reed2018-07-16
| | | | | | | | | | | - simplifies the older pattern of storage/size - removes a dynamic allocation in defaultbitmapcontroller Bug: skia: Change-Id: Ibc937d3e0c057e78cc0c8bf7d9ad2d824eb240d9 Reviewed-on: https://skia-review.googlesource.com/141321 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Revert "implemented metal gpu backend texture upload testing"Gravatar Timothy Liang2018-07-13
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 36848f6b30ddaca461c98e13b9976b2c449ca547. Reason for revert: Test-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-All-Android_CCPR failing. Original change's description: > implemented metal gpu backend texture upload testing > > Bug: skia: > Change-Id: Ia3af58a0710f7f9792b37682a3cc45dd14282b71 > Reviewed-on: https://skia-review.googlesource.com/140248 > Commit-Queue: Timothy Liang <timliang@google.com> > Reviewed-by: Greg Daniel <egdaniel@google.com> TBR=egdaniel@google.com,ethannicholas@google.com,timliang@google.com Change-Id: Idf40fc78b82aec1efbcc64221b6d2bbf63353960 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/141182 Reviewed-by: Timothy Liang <timliang@google.com> Commit-Queue: Timothy Liang <timliang@google.com>
* Reland: Check for ANGLE's implementation of texture_rectangleGravatar Weiliang Chen2018-07-13
| | | | | | | | | | | | | | | | | | | | | ANGLE has implemented extension to support for texture_rectangle. Check for its existence as well as GL_ARB_texture_rectangle extension. Intended to follow up on Chrome side to avoid copy into texture 2d for PaintCanvasVideoRenderer. Bug: skia:7903 Origin change's info: > Change-Id: I450aa7fcd08628831251a9e142fd50719723282d > Reviewed-on: https://skia-review.googlesource.com/130962 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Weiliang Chen <weiliangc@chromium.org> Change-Id: Ifec92bdc07ec2b2dae38ffe99ec275924cbd37d8 Reviewed-on: https://skia-review.googlesource.com/139272 Commit-Queue: Weiliang Chen <weiliangc@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com>
* implemented metal gpu backend texture upload testingGravatar Timothy Liang2018-07-13
| | | | | | | | Bug: skia: Change-Id: Ia3af58a0710f7f9792b37682a3cc45dd14282b71 Reviewed-on: https://skia-review.googlesource.com/140248 Commit-Queue: Timothy Liang <timliang@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* Fixed SPIR-V geometry shadersGravatar Ethan Nicholas2018-07-13
| | | | | | | | | | | sk_in count was being computed incorrectly, and the capabilities and interfaces were incorrect. Bug: skia:8143 Change-Id: If9ac7c152a3b04be3b81ead09270af6d053e006e Reviewed-on: https://skia-review.googlesource.com/141230 Reviewed-by: Chris Dalton <csmartdalton@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* fixed SPIR-V matrix operationsGravatar Ethan Nicholas2018-07-13
| | | | | | | | Bug: skia: Change-Id: I23be824cdd7d00ffd0c54516a168c07e77bb4f49 Reviewed-on: https://skia-review.googlesource.com/140182 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
* Make GrRenderTargetOpList::purgeOpsWithUninstantiatedProxies match the ↵Gravatar Robert Phillips2018-07-13
| | | | | | | | | | | | | | | | GrTextureOpList version This should fix the TSAN bug: 5.17m /b/s/w/ir/build/dm(_ZN14GrOpMemoryPool7releaseENSt3__110unique_ptrI4GrOpNS0_14default_deleteIS2_EEEE+0x40) [0x1ba6b40] build/dm GrOpMemoryPool::release(std::__1::unique_ptr >) at src/gpu/GrMemoryPool.cpp:24 5.17m /b/s/w/ir/build/dm(_ZN20GrRenderTargetOpList33purgeOpsWithUninstantiatedProxiesEv+0x238) [0x1bd65f8] build/dm std::__1::unique_ptr >::reset(GrOp*) at include/c++/v1/memory:2595 Change-Id: I3788dd68993ae86f3c316be9bcbaa1f15abdfbf3 Reviewed-on: https://skia-review.googlesource.com/141242 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Add bullet proofing to image_subset GM for TSAN failuresGravatar Robert Phillips2018-07-13
| | | | | | | | | | | | | | | | | | | The most common TSAN failure is: glmsaa8 gm image_subset with this stack trace: 5.73m /b/s/w/ir/build/dm(_ZNK7SkImage10makeSubsetERK7SkIRect+0x96) [0x1a7c356] /b/s/w/ir/build/dm(_ZNK7SkImage10makeSubsetERK7SkIRect+0x96) [0x1a7c356] 5.73m /b/s/w/ir/build/dm() [0x12cf587] /b/s/w/ir/build/dm() [0x12cf587] 5.73m /b/s/w/ir/build/dm(_ZN6skiagm8SimpleGM6onDrawEP8SkCanvas+0x25) [0x12ba205] Change-Id: Ife1c27af935ef3f56073360e9781a89fe8206586 Reviewed-on: https://skia-review.googlesource.com/141280 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-30 19:28:09 +0000