| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
| |
requires https://codereview.chromium.org/937233002/
BUG=skia:
Review URL: https://codereview.chromium.org/916103008
|
|
|
|
|
|
| |
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/916103006
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/934283002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/939093002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:60001 of https://codereview.chromium.org/825263005/)
Reason for revert:
Crazy failures.
http://build.chromium.org/p/client.skia/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/builds/1428/steps/dm/logs/stdio
Original issue's description:
> notify resource caches when pixelref genID goes stale
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4675819b9dbb3ad71ec851776e5de26d342f29fe
TBR=bsalomon@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/936423002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/936403002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/938943002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/825263005
|
|
|
|
|
|
|
|
| |
This should have no real effect on behavior, but cleans up some names
and removes an unused parameter. This is a step toward separating the
SkTypeface cache from the request cache.
Review URL: https://codereview.chromium.org/936893002
|
|
|
|
|
|
| |
CQ_INCLUDE_TRYBOTS=client.skia:Mac Builder-Trybot,Linux Builder-Trybot,Win Builder-Trybot
Review URL: https://codereview.chromium.org/727343002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/940463006
|
|
|
|
|
|
|
|
|
|
| |
Do not clear the source device in SkGpuDevice::drawDevice based on
the status whether the destination device needs a clear.
Source device clear is flushed in SkGpuDevice::accessRenderTarget()
and target device clear is flushed in CHECK_SHOULD_DRAW(draw).
Review URL: https://codereview.chromium.org/943623002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the form SkDebugf("%s", arbitraryString) instead of
SkDebugf(arbitraryString).
Fixes the case where SkString::appendf-ing a string with "%%" and then
printing the string with SkDebugf would cause uninitialized read and
corrupted debug print.
ninja -C out/Debug tools && valgrind --leak-check=full
./out/Debug/render_pictures --config gpu -w q -r ...
...
==7307== Conditional jump or move depends on uninitialised value(s)
==7307== at 0x6908475: __printf_fp (printf_fp.c:1180)
==7307== by 0x6904267: vfprintf (vfprintf.c:1629)
==7307== by 0x6906E53: buffered_vfprintf (vfprintf.c:2313)
==7307== by 0x690188D: vfprintf (vfprintf.c:1316)
==7307== by 0x67E8F5: SkDebugf(char const*, ...) (SkDebug_stdio.cpp:18)
==7307== by 0x7983F1: GrContext::printCacheStats() const (GrTest.cpp:54)
==7307== by 0x408ECF: tool_main(int, char**) (render_pictures_main.cpp:480)
==7307== by 0x40913E: main (render_pictures_main.cpp:511)
==7307==
Budget: 2048 items 100663296 bytes
Entry Count: current 652 (651 budgeted, 0 wrapped, 297 locked, 638 scratch 32 0.000000ull), high 652
Entry Bytes: current 51087658 (budgeted 49826658, 49 0.000000ull, 1261000 unbudgeted) high 51087658
(observe "ull" instead of "% full")
(from mtklein)
This CL is not editing public API.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/943453002
|
|
|
|
|
|
|
|
| |
This was a bug found by ASAN. When width is very small, we can have something like width == 1 and rowBytes == 8. Using "2 * yWidth" (2) would be smaller than rowBytesY (8), so we could read memory out of bounds. This issue has a separate fix in blink (crbug.com/458861).
BUG=skia:
Review URL: https://codereview.chromium.org/936133003
|
|
|
|
|
|
|
| |
This method is hiding a method of the same name from the superclass.
This is confusing and error prone, and doesn't really add anything.
Review URL: https://codereview.chromium.org/924333003
|
|
|
|
|
|
|
|
| |
Adding Jim for text context stuff, and Steven for image blur stuff.
BUG=skia:
Review URL: https://codereview.chromium.org/939623005
|
|
|
|
|
|
|
|
|
| |
Allows us to push more vertices into a given vertex buffer, with
a slight performance improvement.
Committed: https://skia.googlesource.com/skia/+/059034d252007d0dd86fff5ffdbb53cbcb10d34b
Review URL: https://codereview.chromium.org/917373002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also: Add SkDeflateWStream and associated unit tests.
SkPDFBitmap is a replacement for SkPDFImage. As of now, it only
supports 8888 bitmaps (the most common case).
SkPDFBitmap takes very little extra memory (aside from refing the
bitmap's pixels), and its emitObject() does not cache any data.
The SkPDFBitmap::Create function will check the canon for duplicates.
This can reduce the size of the output PDF.
Motivation: this gives another ~40% decrease in PDF memory overhead
TODO: Support other ColorTypes and scrap SkPDFImage.
BUG=skia:3030
Review URL: https://codereview.chromium.org/918813002
|
|
|
|
|
|
|
| |
SkTypefaces now deal in terms of SkStreamAsset, but the DirectWrite port
was never fully converted.
Review URL: https://codereview.chromium.org/940563002
|
|
|
|
|
|
|
|
| |
This cannot land until https://codereview.chromium.org/917063008/ (Cleanup lingering scaffolding for Skia change) has landed.
TBR=joshualitt@chromium.org
Review URL: https://codereview.chromium.org/930973002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make SkImage::getTexture() const. At the moment the function
does not mutate the state.
One use-case is that this makes it possible in the future to add draw
function to SkBaseDevice functions. The device draw functions take
const ref objects, but SkGpuDevice likely would benefit of using the
getTexture().
BUG=skia:3388
R=reed@google.com
Review URL: https://codereview.chromium.org/925853002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#5 id:80001 of https://codereview.chromium.org/917373002/)
Reason for revert:
speculative revert for DEPS failures
https://codereview.chromium.org/932973002/
Original issue's description:
> Use uint16s for texture coordinates when rendering text.
>
> Allows us to push more vertices into a given vertex buffer, with
> a slight performance improvement.
>
> Committed: https://skia.googlesource.com/skia/+/059034d252007d0dd86fff5ffdbb53cbcb10d34b
TBR=joshualitt@google.com,robertphillips@google.com,bsalomon@google.com,reed@google.com,djsollen@google.com,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/920333003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/932863004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/933523007
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove skia_zlib_static. We're not using it. We don't even have zlib in DEPS.
No public API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/936583002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/921323002
|
|
|
|
|
|
| |
BUG=skia:3428
Review URL: https://codereview.chromium.org/931183002
|
|
|
|
|
|
|
|
| |
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/997c6358d94e188b1a7b89a4f86e24cbe0f5a164
Review URL: https://codereview.chromium.org/914003003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/925343003
|
|
|
|
|
|
|
|
|
| |
The flag is no longer used in Chromium.
BUG=458898
R=reed@google.com,robertphillips@google.com
Review URL: https://codereview.chromium.org/929173002
|
|
|
|
|
|
|
|
|
| |
The flag is no longer used in Chromium.
BUG=458898
R=reed@google.com,robertphillips@google.com
Review URL: https://codereview.chromium.org/931663004
|
|
|
|
|
|
| |
In preparation for moving all the Cmds out of GrInOrderDrawBuffer.
Review URL: https://codereview.chromium.org/931673002
|
|
|
|
|
|
|
| |
Allows us to push more vertices into a given vertex buffer, with
a slight performance improvement.
Review URL: https://codereview.chromium.org/917373002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/926693002
|
|
|
|
|
|
|
|
|
|
| |
Shouldn't call Fast Blur path(DoubleRowBoxBlur_NEON)
when kernelsize is 1. Or, uint16x8_t resultPixels will be overflow.
BUG=skia:2845
R=senorblanco@chromium.org
Review URL: https://codereview.chromium.org/587543003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/926593005
|
|
|
|
|
|
|
|
| |
See cr/86110021.
BUG=skia:
Review URL: https://codereview.chromium.org/913143007
|
|
|
|
|
|
| |
This CL just de-dups some code in GrInOrderDrawBuffer.
Review URL: https://codereview.chromium.org/930953003
|
|
|
|
|
|
|
| |
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/930123002
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=robertphilips
Review URL: https://codereview.chromium.org/927443006
|
|
|
|
|
|
|
|
| |
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/1c3c2d83364ee228e0751df0e1b9c161c0ba8c1e
Review URL: https://codereview.chromium.org/929503002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/929503002/)
Reason for revert:
windows warnings
Original issue's description:
> Multi-string shaders
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/1c3c2d83364ee228e0751df0e1b9c161c0ba8c1e
TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/924973002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/929503002
|
|
|
|
|
|
| |
BUG=458524,458522
Review URL: https://codereview.chromium.org/921163003
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/68c7b6aa98816badbbb69ef65a84a932b8dd58f3
Committed: https://skia.googlesource.com/skia/+/b0fb935bd544b0c6f68c692c7e1ee40876184a1a
Review URL: https://codereview.chromium.org/912483004
|
|
|
|
|
|
| |
of the cache.
Review URL: https://codereview.chromium.org/923143002
|
|
|
|
|
|
|
|
|
|
| |
There was a scaling mistake visible in some JPEG images because the ratio between Y, U and V planes were assumed to be the same ratios as the ratio between texture sizes, which was wrong because texture have a minimum size of 16 and are rounded up to the next POT. Since the ratios between Y and UV planes are generally 1, 2 or 4, rounding up to the next POT would generally preserve this ratio, so that this bug was not very visible, apart from very small jpeg images of 8 or less pixels in either width or height.
BUG=457954
Committed: https://skia.googlesource.com/skia/+/e6eddf7dd85add7da41f22f2643bdd573ad1f1cf
Review URL: https://codereview.chromium.org/922273002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/920423003
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needed for the DEPS roll.
TBR=jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/921293002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/927623002
|