aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* Revert of change mapRectScaleTranslate to pass args/ret by value (patchset ↵Gravatar reed2016-07-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #1 id:1 of https://codereview.chromium.org/2137853002/ ) Reason for revert: Triggered a compiler bug on Android? FAILED: /usr/bin/ccache /b/work/skia/platform_tools/android/bin/../toolchains/arm-r11c-14/bin/arm-linux-androideabi-g++ -MMD -MF obj/src/core/core.SkMatrix.o.d -DSK_INTERNAL -DSK_GAMMA_APPLY_TO_A8 -DQT_NO_KEYWORDS -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=0 -DSK_SUPPORT_GPU=1 -DSK_FORCE_DISTANCE_FIELD_TEXT=0 -DSK_HAS_GIF_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_TEST_QCMS -DSK_IS_BOT -DSK_CODEC_DECODES_RAW -DSK_ARM_HAS_NEON -DSK_BUILD_FOR_ANDROID -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSKIA_DLL -DSKIA_IMPLEMENTATION=1 -DSK_SUPPORT_LEGACY_CLIPTOLAYERFLAG -DNDEBUG -I../../../include/c -I../../../include/config -I../../../include/core -I../../../include/pathops -I../../../include/ports -I../../../include/private -I../../../include/utils -I../../../include/images -I../../../src/core -I../../../src/sfnt -I../../../src/image -I../../../src/opts -I../../../src/utils -I../../../include/gpu -I../../../src/gpu -I../../../platform_tools/android/third_party/cpufeatures -fPIC -g -fno-exceptions -fstrict-aliasing -Wall -Wextra -Winit-self -Wpointer-arith -Wsign-compare -Wvla -Wno-unused-parameter -Werror -march=armv7-a -mthumb -mfpu=neon -mfloat-abi=softfp -fuse-ld=gold -O2 -std=c++11 -fno-rtti -fno-threadsafe-statics -Wnon-virtual-dtor -c ../../../src/core/SkMatrix.cpp -o obj/src/core/core.SkMatrix.o ../../../src/core/SkMatrix.cpp: In member function 'SkRect SkMatrix::mapRectScaleTranslate(SkRect) const': ../../../src/core/SkMatrix.cpp:1120:1: error: unrecognizable insn: } ^ (insn 32 31 33 2 (set (reg:V4SF 115 [ D.83077 ]) (unspec:V4SF [ (mem/c:V4SF (reg/f:SI 104 virtual-incoming-args) [0 MEM[(const __builtin_neon_sf[4] *)&src]+0 S16 A32]) ] UNSPEC_VLD1)) /b/work/skia/platform_tools/android/toolchains/arm-r11c-14/lib/gcc/arm-linux-androideabi/4.9/include/arm_neon.h:8693 -1 (nil)) ../../../src/core/SkMatrix.cpp:1120:1: internal compiler error: in extract_insn, at recog.c:2202 Please submit a full bug report, with preprocessed source if appropriate. See <http://source.android.com/source/report-bugs.html> for instructions. Original issue's description: > change mapRectScaleTranslate to pass args/ret by value > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137853002 > > TBR=mtklein > > Committed: https://skia.googlesource.com/skia/+/14dce6ed5934d7a6e1fac79f8e76e12f5670aae2 TBR=msarett@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2139523002
* change mapRectScaleTranslate to pass args/ret by valueGravatar reed2016-07-10
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137853002 TBR=mtklein Review-Url: https://codereview.chromium.org/2137853002
* Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShaderGravatar dvonbeck2016-07-09
| | | | | | | | | | | | Will not run until after landing https://codereview.chromium.org/2106893003/ This CL's base is the CL for the addition of NormalSource to the API: https://codereview.chromium.org/2063793002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062703003 Committed: https://skia.googlesource.com/skia/+/3f58cd0eb8bf4499c4f179aa6111d7e005809df8 Review-Url: https://codereview.chromium.org/2062703003
* Add choke point for modifying non-AA rect draws (e.g., applying clipping)Gravatar robertphillips2016-07-08
| | | | | | | | | | NOTREECHECKS=true NOPRESUBMIT=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002 Committed: https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9 Review-Url: https://codereview.chromium.org/2125333002
* Revert of Add choke point for modifying non-AA rect draws (e.g., applying ↵Gravatar robertphillips2016-07-08
| | | | | | | | | | | | | | | | | | | | | | | | | clipping) (patchset #6 id:100001 of https://codereview.chromium.org/2125333002/ ) Reason for revert: problems Original issue's description: > Add choke point for modifying non-AA rect draws (e.g., applying clipping) > > NOTREECHECKS=true > NOPRESUBMIT=true > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002 > > Committed: https://skia.googlesource.com/skia/+/e5e3a7a5203f256083d015c923cc9c662877aba9 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2136643002
* Add choke point for modifying non-AA rect draws (e.g., applying clipping)Gravatar robertphillips2016-07-08
| | | | | | | | | NOTREECHECKS=true NOPRESUBMIT=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125333002 Review-Url: https://codereview.chromium.org/2125333002
* Use clipped bounds for reordering decisionsGravatar bsalomon2016-07-08
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2137543002 NOTREECHECKS=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2137543002
* Revert change of bounds computation in MSAA path renderer.Gravatar bsalomon2016-07-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2133773002 Review-Url: https://codereview.chromium.org/2133773002
* Fixed error when normal.z = 1 in GPUs with binary16 floatsGravatar dvonbeck2016-07-08
| | | | | | | | | Check failed in GPUs with low-precision floats since 0.9999 was too small a difference from 1 to be detected by a 16-bit float comparison. Changed it to 0.999 which fixed the issue and results in indistinguishable correct behavior. BUG=skia:5499 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2124183004 Review-Url: https://codereview.chromium.org/2124183004
* deferred canvasGravatar reed2016-07-08
| | | | | | | | | tries to eliminate unneeded clipRects and concats (and their associated save/restores). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120333002 Review-Url: https://codereview.chromium.org/2120333002
* Don't scissor draws overlapping the render target's edgesGravatar bsalomon2016-07-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135673002 Review-Url: https://codereview.chromium.org/2135673002
* Consolidate handling of infinitely thin primitives and aa bloat handing WRT ↵Gravatar bsalomon2016-07-08
| | | | | | | | batch bounds. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127673002 Review-Url: https://codereview.chromium.org/2127673002
* Move sRGB <-> linear conversion components to their own files.Gravatar mtklein2016-07-08
| | | | | | | | | | | | | | | This makes them a little easier to use outside SkColorXform code. I've added some notes about how best to use them and their eccentricities, and added a test. Ultimately any software sRGB <-> linear conversion should funnel somehow through here. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128893002 CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot;client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/45e58c8807179638980aae8503573b950b844e4c Review-Url: https://codereview.chromium.org/2128893002
* Revert of Abstracted diffuse color map out of SkLightingShaderImpl into a ↵Gravatar rmistry2016-07-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | generic SkShader (patchset #11 id:200001 of https://codereview.chromium.org/2062703003/ ) Reason for revert: Causing the Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind builder to fail. Started failing at this build: https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind/builds/1214 Snippet from build log: ==3016== Invalid read of size 4 ==3016== at 0xCD1901: GrFragmentProcessor::registerChildProcessor(sk_sp<GrFragmentProcessor>) (SkTArray.h:163) ==3016== by 0xA58B47: _Z10sk_make_spI11NormalMapFPI5sk_spI19GrFragmentProcessorERK8SkMatrixEES1_IT_EDpOT0_ (SkNormalSource.cpp:84) ==3016== by 0xA582E8: NormalMapSourceImpl::asFragmentProcessor(GrContext*, SkMatrix const&, SkMatrix const*, SkFilterQuality, SkSourceGammaTreatment) const (SkNormalSource.cpp:187) ==3016== by 0xA0ADB5: SkLightingShaderImpl::asFragmentProcessor(GrContext*, SkMatrix const&, SkMatrix const*, SkFilterQuality, SkSourceGammaTreatment) const (SkLightingShader.cpp:268) ==3016== by 0xDA17E6: skpaint_to_grpaint_impl(GrContext*, SkPaint const&, SkMatrix const&, sk_sp<GrFragmentProcessor>*, SkXfermode::Mode*, bool, bool, GrPaint*) (SkGr.cpp:552) ==3016== by 0xDA4532: SkPaintToGrPaint(GrContext*, SkPaint const&, SkMatrix const&, bool, GrPaint*) (SkGr.cpp:668) ==3016== by 0xD99B51: SkGpuDevice::drawRect(SkDraw const&, SkRect const&, SkPaint const&) (SkGpuDevice.cpp:534) ==3016== by 0x9DDB1C: SkCanvas::onDrawRect(SkRect const&, SkPaint const&) (SkCanvas.cpp:2148) ==3016== by 0x9DBF40: SkCanvas::drawRect(SkRect const&, SkPaint const&) (SkCanvas.cpp:1919) ==3016== by 0x8D2A55: skiagm::LightingShaderGM::onDraw(SkCanvas*) (lightingshader.cpp:110) ==3016== by 0x625659: skiagm::GM::drawContent(SkCanvas*) (gm.cpp:32) ==3016== by 0x6256AD: skiagm::GM::draw(SkCanvas*) (gm.cpp:24) ==3016== by 0x61B747: DM::GMSrc::draw(SkCanvas*) const (DMSrcSink.cpp:61) ==3016== by 0x61F37B: DM::GPUSink::draw(DM::Src const&, SkBitmap*, SkWStream*, SkString*) const (DMSrcSink.cpp:1115) ==3016== by 0x619261: dm_main() (DM.cpp:1016) ==3016== by 0x619841: main (DM.cpp:1409) ==3016== Address 0xf4 is not stack'd, malloc'd or (recently) free'd ==3016== Caught signal 11 [Segmentation fault], was running: gpu gm lightingshader Original issue's description: > Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader > > Will not run until after landing https://codereview.chromium.org/2106893003/ > > This CL's base is the CL for the addition of NormalSource to the API: https://codereview.chromium.org/2063793002/ > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062703003 > > Committed: https://skia.googlesource.com/skia/+/3f58cd0eb8bf4499c4f179aa6111d7e005809df8 TBR=egdaniel@google.com,robertphillips@google.com,dvonbeck@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: NOTRY=true Review-Url: https://codereview.chromium.org/2137513002
* Use sRGB pixel config for ARGB masks (color emoji)Gravatar brianosman2016-07-08
| | | | | | | | | | Fixes over-bright color emoji and GM:colortype in sRGB mode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 Committed: https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a Review-Url: https://codereview.chromium.org/2129913004
* Reland of Better encapsulate oval/rrect batchs. (patchset #1 id:1 of ↵Gravatar bsalomon2016-07-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2121313004/ ) Reason for revert: Workaround for compiler/stdlib bug landed: https://codereview.chromium.org/2135453002 Original issue's description: > Revert of Better encapsulate oval/rrect batchs. (patchset #5 id:80001 of https://codereview.chromium.org/2104423003/ ) > > Reason for revert: > This CL is suspected to break compilation on arm64. > https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/5851/steps/compile/logs/stdio > > Original issue's description: > > Better encapsulate oval/rrect batchs. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003 > > > > Committed: https://skia.googlesource.com/skia/+/5fd209e8ee477c703bc5c11b008f247d515fc0fc > > Committed: https://skia.googlesource.com/skia/+/7f06c6947a3bef78dc57b9252779567c33604c90 > > Committed: https://skia.googlesource.com/skia/+/11bf8b2eae7d1780cb969146422a2ab3b933047a > > TBR=robertphillips@google.com,bsalomon@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/c79fc33d3e83664ffbd3651df3131c3e9e0b635c TBR=robertphillips@google.com,hush@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2134693002
* Promote the GCC/libc++/<memory> 'typedef float float32_t' workaround to ↵Gravatar bsalomon2016-07-08
| | | | | | | | | SkTypes.h BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135453002 Review-Url: https://codereview.chromium.org/2135453002
* Make all parameters reqiured to GrReducedClip::ReduceClipStackGravatar bsalomon2016-07-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130903002 Review-Url: https://codereview.chromium.org/2130903002
* Revert of Move sRGB <-> linear conversion components to their own files. ↵Gravatar mtklein2016-07-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #5 id:80001 of https://codereview.chromium.org/2128893002/ ) Reason for revert: Monotonicity assert is failing on ARM. (Different rsqrt() and invert() precision?) Will investigate a bit tomorrow... might reland with the test TODO. Original issue's description: > Move sRGB <-> linear conversion components to their own files. > > This makes them a little easier to use outside SkColorXform code. > > I've added some notes about how best to use them and their eccentricities, and added a test. > > Ultimately any software sRGB <-> linear conversion should funnel somehow through here. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128893002 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/45e58c8807179638980aae8503573b950b844e4c TBR=reed@google.com,msarett@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2131793002
* make some canvas utils virtual (for proxy based subclasses)Gravatar reed2016-07-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130973002 Review-Url: https://codereview.chromium.org/2130973002
* Move sRGB <-> linear conversion components to their own files.Gravatar mtklein2016-07-07
| | | | | | | | | | | | | | This makes them a little easier to use outside SkColorXform code. I've added some notes about how best to use them and their eccentricities, and added a test. Ultimately any software sRGB <-> linear conversion should funnel somehow through here. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128893002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2128893002
* Revert of Better encapsulate oval/rrect batchs. (patchset #5 id:80001 of ↵Gravatar hush2016-07-07
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2104423003/ ) Reason for revert: This CL is suspected to break compilation on arm64. https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/5851/steps/compile/logs/stdio Original issue's description: > Better encapsulate oval/rrect batchs. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003 > > Committed: https://skia.googlesource.com/skia/+/5fd209e8ee477c703bc5c11b008f247d515fc0fc > Committed: https://skia.googlesource.com/skia/+/7f06c6947a3bef78dc57b9252779567c33604c90 > Committed: https://skia.googlesource.com/skia/+/11bf8b2eae7d1780cb969146422a2ab3b933047a TBR=robertphillips@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2121313004
* Revert of Use sRGB pixel config for ARGB masks (color emoji) (patchset #1 ↵Gravatar brianosman2016-07-07
| | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/2129913004/ ) Reason for revert: Color text rendering failing on ANGLE Original issue's description: > Use sRGB pixel config for ARGB masks (color emoji) > > Fixes over-bright color emoji and GM:colortype in sRGB mode > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 > > Committed: https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a TBR=bungeman@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2128583007
* drawTextRSXformGravatar reed2016-07-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004 Review-Url: https://codereview.chromium.org/2130643004
* SkPDF: Fix encoding of unichr outside of basic planeGravatar halcanary2016-07-07
| | | | | | | | | | | | | | In ToUnicode table, write unicode codepoints as one or two UTF16BE values, rather than a single hex, as the standard requires. Factor out uint16 -> big-endian hex code. SkUtils is now a namespace. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120533002 Review-Url: https://codereview.chromium.org/2120533002
* SkPDF: fix PDFA-only metadata errorGravatar halcanary2016-07-07
| | | | Review-Url: https://codereview.chromium.org/2119883002
* Use sRGB pixel config for ARGB masks (color emoji)Gravatar brianosman2016-07-07
| | | | | | | | | Fixes over-bright color emoji and GM:colortype in sRGB mode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 Review-Url: https://codereview.chromium.org/2129913004
* Check granularity in render pass boundsGravatar egdaniel2016-07-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126303002 Review-Url: https://codereview.chromium.org/2126303002
* Add offsets to GrVkBuffer.Gravatar jvanverth2016-07-07
| | | | | | | BUG=skia:5031 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2127183002 Review-Url: https://codereview.chromium.org/2127183002
* Begin instanced rendering for simple shapesGravatar csmartdalton2016-07-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a module that performs instanced rendering and starts using it for a select subset of draws on Mac GL platforms. The instance processor can currently handle rects, ovals, round rects, and double round rects. It can generalize shapes as round rects in order to improve batching. The instance processor also employs new drawing algorithms, irrespective of instanced rendering, that improve GPU-side performance (e.g. sample mask, different triangle layouts, etc.). This change only scratches the surface of instanced rendering. The majority of draws still only have one instance. Future work may include: * Passing coord transforms through the texel buffer. * Sending FP uniforms through instanced vertex attribs. * Using instanced rendering for more draws (stencil writes, drawAtlas, etc.). * Adding more shapes to the instance processor’s repertoire. * Batching draws that have mismatched scissors (analyzing draw bounds, inserting clip planes, etc.). * Bindless textures. * Uber shaders. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003 Committed: https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891 Review-Url: https://codereview.chromium.org/2066993003
* Only check resource tracking on program shutdown, not context shutdownGravatar jvanverth2016-07-07
| | | | | | | BUG=skia:5496 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128273002 Review-Url: https://codereview.chromium.org/2128273002
* Fix vulkan compileGravatar egdaniel2016-07-07
| | | | | | | | TBR=jvanverth@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2122263003 Review-Url: https://codereview.chromium.org/2122263003
* centralize VECTORCALL as SK_VECTORCALLGravatar mtklein2016-07-07
| | | | | | | | | | | | Gonna start using this, might as well define it once centrally. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126253002 No public API changes. TBR=reed@google.com Review-Url: https://codereview.chromium.org/2126253002
* Correctly handle mat2x2 in VulkanGravatar egdaniel2016-07-07
| | | | | | | BUG=skia:5497 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129953002 Review-Url: https://codereview.chromium.org/2129953002
* Better encapsulate oval/rrect batchs.Gravatar bsalomon2016-07-07
| | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003 Committed: https://skia.googlesource.com/skia/+/5fd209e8ee477c703bc5c11b008f247d515fc0fc Committed: https://skia.googlesource.com/skia/+/7f06c6947a3bef78dc57b9252779567c33604c90 Review-Url: https://codereview.chromium.org/2104423003
* Remove fColor from PathRenderer DrawPathArgs structGravatar robertphillips2016-07-07
| | | | | | | | This was getting in the way of other refactorings. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126083002 Review-Url: https://codereview.chromium.org/2126083002
* Pull out freelist allocation from GrVkSubHeapGravatar jvanverth2016-07-07
| | | | | | | BUG=skia:5031 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2128673002 Review-Url: https://codereview.chromium.org/2128673002
* fix for SkSL producing invalid branch after an OpKillGravatar ethannicholas2016-07-07
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913002 Review-Url: https://codereview.chromium.org/2129913002
* Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShaderGravatar dvonbeck2016-07-06
| | | | | | | | | | | Will not run until after landing https://codereview.chromium.org/2106893003/ This CL's base is the CL for the addition of NormalSource to the API: https://codereview.chromium.org/2063793002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2062703003 Review-Url: https://codereview.chromium.org/2062703003
* Hide NonAAStrokeRectBatch Geometry class and cleanup class.Gravatar bsalomon2016-07-06
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126893002 Review-Url: https://codereview.chromium.org/2126893002
* Fix bounds computation for non-aa hairlines when snapping to pixel centersGravatar egdaniel2016-07-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126913002 Review-Url: https://codereview.chromium.org/2126913002
* Deleting void pointers is bad, mmmkay?Gravatar jvanverth2016-07-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129483003 Review-Url: https://codereview.chromium.org/2129483003
* API change to allow for NormalSource selection at the user level.Gravatar dvonbeck2016-07-06
| | | | | | | | | This CL's base is the CL for CPU handling: https://codereview.chromium.org/2050773002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2063793002 Review-Url: https://codereview.chromium.org/2063793002
* Hide geometry class in AAStrokeRectBatch and remove unused Append function.Gravatar bsalomon2016-07-06
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2119813004 Review-Url: https://codereview.chromium.org/2119813004
* Vulkan fixes for TesselatingPathRenderer testGravatar jvanverth2016-07-06
| | | | | | | | - Be sure to release all secondard command buffers on shutdown - Allow mapping of static buffers GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2123323002 Review-Url: https://codereview.chromium.org/2123323002
* check for zero scale in SkDraw::ComputeResScaleForStrokingGravatar lsalzman2016-07-06
| | | | | | | | | | | | | | If the transform used to compute the res scale has both 0 scale and skew, then it will currently compute a 0 res scale. This causes getFillPath to trigger an assertion while using SkStroke since that can't handle a 0 res scale. Downstream Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1284356 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125933003 Review-Url: https://codereview.chromium.org/2125933003
* Grow descriptor pools by 1.5Gravatar egdaniel2016-07-06
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2121243002 Review-Url: https://codereview.chromium.org/2121243002
* Fixed crash when RunInSeriesFP's color input is nilGravatar dvonbeck2016-07-06
| | | | | | | | | SeriesFragmentProcessor would call emitChild with "" input color as opposed to nil input color when ginven a nil input color. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2106893003 Review-Url: https://codereview.chromium.org/2106893003
* Add gm that tests shaded stroked rectangles.Gravatar bsalomon2016-07-06
| | | | | | | | | | | Fix GPU handling of previously untested cases. Move rect->path fallback from SkGpuDevice to GrDrawContext. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125663003 Review-Url: https://codereview.chromium.org/2125663003
* Fix caching of sample locationsGravatar csmartdalton2016-07-06
| | | | | | | | | | | | | | | The original caching logic for sample locations wishfully assumed that the GPU would always use the same sample pattern for render targets that had the same number of samples. It turns out we can't rely on that. This change improves the caching logic to handle mismatched simple patterns with the same count, and adds a unit test that emulates different sample patterns observed on real hardware. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2111423002 Committed: https://skia.googlesource.com/skia/+/09d49a3bfe2d1e652a648ce1ea0962b38d10d166 Review-Url: https://codereview.chromium.org/2111423002